News:

Support the VirtueMart project and become a member

Main Menu

Updated VM configuration file

Started by RolandD, November 26, 2011, 02:47:02 AM

Previous topic - Next topic

RolandD

Guys,

I see that the new configuration file is actually an INI based file. However it is not fully according to the PHP standards. If you replace the # with a ; and enclose all values in double quotes, you can use the parse_ini_file() command to parse the config file into an array. This might be easier than the current code.

Just a suggestion.
Regards,

RolandD

CSVI
http://www.csvimproved.com/

Milbo

Good idea, no question,
but some explanations, why we wont do it next time. The idea of the config file is to have a possibility to reset a store to default values with ftp and phpmyadmin. For us developers it is nice, because we can set then as standard the debug output and enable the "risky db tools).
Oscar wrote in that time his own parser and the whole trouble started with that. It is now working and in a normal store this file is only read one time, so I dont see any need to change it. I just named it .ini to show that is a file with initialising values.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

DRACULINOS

Max I follow your posts times to times.
Why always have an excuse for everything ?! I really wonder.

I think sometimes its good to say that is a Good idea, no question , we will do it and thats it !
Don't try to excuse everything !
Roland makes a clean and absolutely nice suggestion that you have to follow and thats it!

Milbo

I have to follow it?
Exactly not. If someone is making it, we can test what is better. But most people do not know that the config is normally only readed one time.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

RolandD

As for me, I don't really care. It was merely a suggestion and I can work around it ;)
Regards,

RolandD

CSVI
http://www.csvimproved.com/