Author Topic: Updated VM configuration file  (Read 1491 times)

RolandD

  • Full Member
  • ***
  • Posts: 780
    • Home of CSVI
Updated VM configuration file
« on: November 26, 2011, 02:47:02 am »
Guys,

I see that the new configuration file is actually an INI based file. However it is not fully according to the PHP standards. If you replace the # with a ; and enclose all values in double quotes, you can use the parse_ini_file() command to parse the config file into an array. This might be easier than the current code.

Just a suggestion.
Regards,

RolandD

CSVI
http://www.csvimproved.com/

Milbo

  • Virtuemart Projectleader
  • Administrator
  • Super Hero
  • *
  • Posts: 9853
  • VM3.2 Cached and Optimized
    • VM3 Extensions
  • VirtueMart Version: VirtueMart 3 on joomla 3
Re: Updated VM configuration file
« Reply #1 on: November 26, 2011, 10:33:48 am »
Good idea, no question,
but some explanations, why we wont do it next time. The idea of the config file is to have a possibility to reset a store to default values with ftp and phpmyadmin. For us developers it is nice, because we can set then as standard the debug output and enable the "risky db tools).
Oscar wrote in that time his own parser and the whole trouble started with that. It is now working and in a normal store this file is only read one time, so I dont see any need to change it. I just named it .ini to show that is a file with initialising values.
I should fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

DRACULINOS

  • Contributing Developer
  • Jr. Member
  • *
  • Posts: 206
  • Theo
Re: Updated VM configuration file
« Reply #2 on: November 27, 2011, 00:19:37 am »
Max I follow your posts times to times.
Why always have an excuse for everything ?! I really wonder.

I think sometimes its good to say that is a Good idea, no question , we will do it and thats it !
Don't try to excuse everything !
Roland makes a clean and absolutely nice suggestion that you have to follow and thats it!

Milbo

  • Virtuemart Projectleader
  • Administrator
  • Super Hero
  • *
  • Posts: 9853
  • VM3.2 Cached and Optimized
    • VM3 Extensions
  • VirtueMart Version: VirtueMart 3 on joomla 3
Re: Updated VM configuration file
« Reply #3 on: November 27, 2011, 02:19:38 am »
I have to follow it?
Exactly not. If someone is making it, we can test what is better. But most people do not know that the config is normally only readed one time.
I should fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

RolandD

  • Full Member
  • ***
  • Posts: 780
    • Home of CSVI
Re: Updated VM configuration file
« Reply #4 on: November 28, 2011, 08:32:00 am »
As for me, I don't really care. It was merely a suggestion and I can work around it ;)
Regards,

RolandD

CSVI
http://www.csvimproved.com/