Author Topic: [fixed] Checkout link incorrect  (Read 4460 times)

milstan

  • Beginner
  • *
  • Posts: 32
    • VirtueMart templates
[fixed] Checkout link incorrect
« on: October 07, 2011, 11:32:04 am »
2.0.0-RC-2G

After click CHECKOUT button, & is not good in the link
index.php?option=com_virtuemart&view=user&task=editaddresscheckout&addrtype=BT&Itemid=166
and should be
index.php?option=com_virtuemart&view=user&task=editaddresscheckout&addrtype=BT&Itemid=166

That causes modules that's published on the VM's  menu item(s) not showing.

PRO

  • Global Moderator
  • Super Hero
  • *
  • Posts: 10337
  • VirtueMart Version: 3+
Re: Checkout link incorrect
« Reply #1 on: October 07, 2011, 19:09:13 pm »
I have been looking whats wrong here, and cant find it.

I do see the page has a couple of html errors that might cause it.

J3.9+ VM 3.4.2
Slowest Page Speed Score (88) (Category)
Fastest Page Speed Score (94-96) (productdetails)

PRO

  • Global Moderator
  • Super Hero
  • *
  • Posts: 10337
  • VirtueMart Version: 3+
Re: Checkout link incorrect
« Reply #2 on: October 07, 2011, 19:20:48 pm »
I did find these in
cart/view.html.php

      $continue_link_html = '<a class="continue_link" href="'.$continue_link.'" />'.JText::_('COM_VIRTUEMART_CONTINUE_SHOPPING').'</a>';

should be this
$continue_link_html = '<a class="continue_link" href="'.$continue_link.'" >'.JText::_('COM_VIRTUEMART_CONTINUE_SHOPPING').'</a>';

and this
            $checkout_link_html = '<a class="checkout_link" href="javascript:document.checkoutForm.submit();" /><span>'.$text.'</span></a>';
should be this
            $checkout_link_html = '<a class="checkout_link" href="javascript:document.checkoutForm.submit();" ><span>'.$text.'</span></a>';


BUT, that still did not fix the problem
J3.9+ VM 3.4.2
Slowest Page Speed Score (88) (Category)
Fastest Page Speed Score (94-96) (productdetails)

Milbo

  • Virtuemart Projectleader
  • Administrator
  • Super Hero
  • *
  • Posts: 9853
  • VM3.2 Cached and Optimized
    • VM3 Extensions
  • VirtueMart Version: VirtueMart 3 on joomla 3
Re: Checkout link incorrect
« Reply #3 on: October 07, 2011, 21:23:48 pm »
thx
I should fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

tez

  • Jr. Member
  • **
  • Posts: 130
Re: [fixed] Checkout link incorrect
« Reply #4 on: June 28, 2012, 03:49:35 am »
that code being in view.html.php means we can't customise the checkout / continue button with an override.

PRO

  • Global Moderator
  • Super Hero
  • *
  • Posts: 10337
  • VirtueMart Version: 3+
Re: [fixed] Checkout link incorrect
« Reply #5 on: June 28, 2012, 22:08:00 pm »
that code being in view.html.php means we can't customise the checkout / continue button with an override.

tez, what do you want to do to it?

J3.9+ VM 3.4.2
Slowest Page Speed Score (88) (Category)
Fastest Page Speed Score (94-96) (productdetails)

tez

  • Jr. Member
  • **
  • Posts: 130
Re: [fixed] Checkout link incorrect
« Reply #6 on: July 02, 2012, 04:31:20 am »
Put a span tag around the text so I can hide it with CSS and use a different images in the background of each link.

Eugen S.

  • 3rd party VirtueMart Developer
  • Jr. Member
  • *
  • Posts: 255
  • Hire me for individual customization work => info
    • Virtuemart Themes
Re: [fixed] Checkout link incorrect
« Reply #7 on: July 03, 2012, 12:12:10 pm »
I did find these in
cart/view.html.php

      $continue_link_html = '<a class="continue_link" href="'.$continue_link.'" />'.JText::_('COM_VIRTUEMART_CONTINUE_SHOPPING').'</a>';

should be this
$continue_link_html = '<a class="continue_link" href="'.$continue_link.'" >'.JText::_('COM_VIRTUEMART_CONTINUE_SHOPPING').'</a>';

and this
            $checkout_link_html = '<a class="checkout_link" href="javascript:document.checkoutForm.submit();" /><span>'.$text.'</span></a>';
should be this
            $checkout_link_html = '<a class="checkout_link" href="javascript:document.checkoutForm.submit();" ><span>'.$text.'</span></a>';


BUT, that still did not fix the problem


I added a <span> tag within the <a> tag for continue link. Checkout button already had this...
Send me a pm ;-)