Author Topic: Sending serial number by e-mail  (Read 51976 times)

chaosvg

  • Beginner
  • *
  • Posts: 36
Re: Sending serial number by e-mail
« Reply #30 on: September 13, 2005, 18:10:12 pm »
Hi esteve,

I am fast ;-). Thing is I need to get this thing in a production-ready state real soon. I will be selling software and besides a working online shop in involves developing software to sell too  ;D

I would really like to thank you again for your code. Without this it would have taken me a lot more time to create a system like this.

I do have a few concerns though, I hope you don't mind me saying this

I honestly think you shouldn't work on the cvs version but on the latest stable release. Other peeps trying to use this will run into problems and might not be able to work around the issues i came to and get frustrated.

Are you (or anyone else) positive that the user_info_id field in phpshop_orders is filled in the current (pl3) release? If feel (will investigate) that the database structure is ok but the code isn't updated to fill this field. This 'feeling' makes me nervous for future compatibility/version soup. Maybe I'll switch to the cvs version (which is, running in php safe mode, a bit of a pain)


Anyway, thank you for your work, will keep you updated.


esteve

  • Jr. Member
  • **
  • Posts: 65
Re: Sending serial number by e-mail
« Reply #31 on: September 13, 2005, 18:31:56 pm »
Hi,

i understand what you say.
But merging code is easier from cvs version (for Soeren).

My 1st suggestion is based on your speed. :)
Remove the changes which come from cvs. (As I can remember it affects only ps_product.php)

2nd suggestion: use older version, and your mail function.
Newest version (which you have tested :) thanks!) does not help you: it is for simple (identifier) serials.
Software serials was implemented in the first version (this was enough for me, too), but there was claim to add other type, too.

cheers,
Steve

esteve

  • Jr. Member
  • **
  • Posts: 65
Re: Sending serial number by e-mail
« Reply #32 on: September 14, 2005, 10:53:40 am »
Hi,

one day after: if versions seem to be a jungle: don't panic. :)

I created a version which is based on last stable version.
If mail sending is not working, please use mod described in Reply #22.

pserial.zip: based on last stable version
pserial_cvs.zip: based on cvs version

Steve

[attachment deleted by admin]

chaosvg

  • Beginner
  • *
  • Posts: 36
Re: Sending serial number by e-mail
« Reply #33 on: September 14, 2005, 11:07:37 am »
thanks esteve, i think that will prevent confusion with other users.

(i installed cvs yesterday, screwed up big time last night, started all over. hmmm bad night )

chaosvg

  • Beginner
  • *
  • Posts: 36
Re: Sending serial number by e-mail
« Reply #34 on: September 15, 2005, 05:21:32 am »
steve,

there's a thing about me always trying to figure out things I don't really need ... But you should really verify your code before posting! conserning the non-cvs version:

- basket.php calls unexisting it_has_product_serial() on line 126
i changed this to (what i guess it's supposed to be) is_only_product_serial

- account.order_details calls unexisting print_product_serial()on 339
I copied this ps_product_serial function from your cvs version

the above made it work in the frontend for an existing product with serial. Now the backend

when saving a product, unexisting it_has_product_serial is called from ps_product on line 572. changed that to is_only_product_serial too, which fixed it

then I get
Notice: Undefined index: product_code in /home/httpd/vhosts/mcprep.net/httpdocs/administrator/components/com_phpshop/classes/ps_product_serial.php on line 103

Notice: Undefined index: type in /home/httpd/vhosts/mcprep.net/httpdocs/administrator/components/com_phpshop/html/product.product_form.php on line 122

The product code field is read only and i'm anable to save serial data

I give up now,cannot get this fixed, will stick to the first version

bye

esteve

  • Jr. Member
  • **
  • Posts: 65
Re: Sending serial number by e-mail
« Reply #35 on: September 15, 2005, 14:58:24 pm »
Hi,

I'm sorry, it was my fault. Thanks for trying it out.

1 error caused the problems: ps_product_serial.php should be the same in
the 2 package, but non cvs version contained the older one. :(

If you copy the newer ps_product_serial.php into your shop, all
errors would be solved.
But do not test, as i can judge you are sad: so do something else.
Something interesting. :)

bye,
Steve

[attachment cleanup by admin]

chaosvg

  • Beginner
  • *
  • Posts: 36
Re: Sending serial number by e-mail
« Reply #36 on: September 15, 2005, 20:25:26 pm »
as i can judge you are sad: so do something else.

 ::) oops I didn't read that right before. No I'm not sad, I was just tired and fighting bad deadlines. I'm still very happy I have this code from you!
I will test and probably use the update in time. As for now, other things to do ...

bye

esteve

  • Jr. Member
  • **
  • Posts: 65
Re: Sending serial number by e-mail
« Reply #37 on: September 16, 2005, 09:03:38 am »
 :)

John.Kain

  • Beginner
  • *
  • Posts: 11
Re: Sending serial number by e-mail
« Reply #38 on: September 20, 2005, 14:59:09 pm »
Hi Steve,

Thanks for the code, I think this should be part of the next release. Will email you once i get all the other errors sorted out with mambo  ;).

Thanks again

John

esteve

  • Jr. Member
  • **
  • Posts: 65
Re: Sending serial number by e-mail
« Reply #39 on: September 20, 2005, 15:26:00 pm »
Hi John,

is it working? (in the way that you want)
Steve

John.Kain

  • Beginner
  • *
  • Posts: 11
Re: Sending serial number by e-mail
« Reply #40 on: September 26, 2005, 10:02:04 am »
Hi Steve,

Firstly i am using the latest stable release by mambo-phpshop.

I am having trouble getting the code to work. I installed a new phpshop after i couldn't get it working with the old one, but it is the same result. The problem is that on the Product Dimensions and Weight page when i select "physical, to identify the product" the product code box gets disabled. Even if i manage to add the product code before clicking on the radio button next to "physical, to identify the product", it still won't work.

The product code added doesn't display on the account section for that particular product. It also treats products having different product codes separately.(i.e you can't enter for the same product multiple entries in the product code box.)

Regards
John

esteve

  • Jr. Member
  • **
  • Posts: 65
Re: Sending serial number by e-mail
« Reply #41 on: September 26, 2005, 11:04:10 am »
Hi John,

-set "physical, to identify the product" (and product code will be disabled)
-give the amount of this product in stock
-go in admin menu to Products/Other Product List/View Inventory
-those products who have physical serials, will have a link on their amount in the table. Click on it, and you can give serials manually.

I hope this helps.
Steve

John.Kain

  • Beginner
  • *
  • Posts: 11
Re: Sending serial number by e-mail
« Reply #42 on: September 26, 2005, 15:36:37 pm »
Now i understand a bit better will try it.

Thanks for the help.  ;)

Regards
John

John.Kain

  • Beginner
  • *
  • Posts: 11
Re: Sending serial number by e-mail
« Reply #43 on: September 27, 2005, 17:35:24 pm »
Hi Steve,

It works  :D and it is the thing i was asking. it should be a great help.
Thanks again for all your hard work.

Regards,

John :D

esteve

  • Jr. Member
  • **
  • Posts: 65
Re: Sending serial number by e-mail
« Reply #44 on: September 27, 2005, 17:48:44 pm »
 ;D