News:

Support the VirtueMart project and become a member

Main Menu

[FIXED] "'" instead of "apostrophe" in title tags

Started by meisay, December 07, 2006, 01:03:29 AM

Previous topic - Next topic

meisay

Description:
"Apostrophe" in product name becomes "'" in title tags on product detail page/flypage.

VirtueMart Version:
1.0.7

Joomla/Mambo Version:
1.0.11

Steps to replicate:
1. add new product
2. type an "apostrophe" in product information -> name (ex. Jeff's Bloody Mary Mix)
3. Save
4. View new product detail page/flypage source
5. title tags = "Jeff's bloody mary mix"

Proposed fix(es):
none

System info:
System info = (Linux, Apache, php 4.3.3, mysql 3.23.58)

meisay

Nobody?  This is a pretty HUGE bug, terrible for search engines, and sales.

Soeren

Why didn't you report this as a bug on the bugtracker if it's so important for you?

change line 157 in shop.product_details.php

to:

$mainframe->setPageTitle( html_entity_decode( substr($product_name, 0, 60 ), ENT_QUOTES ));

That's it.
The future of eCommerce: VirtueMart & Joomla!
http://virtuemart.net

meisay

I didn't report a bug because I was following the instructions here: http://virtuemart.net/index.php?option=com_smf&Itemid=71&topic=21474.msg53274#msg53274
QuoteWhen submitting a bug report for a VirtueMart beta release, please report it in this forum before adding a task to the bug tracker.

jeeez brother! thanks for your help.

RCheesley

Soeren,

Was this ever fixed as I am getting this happening with 1.1.2 on my product name in the breadcrumb - everything else is fine and I just happened to notice it in passing, it's saying "Cadbury&<amp>#039;s Hot Chocolates Hot Chocolate" here: http://www.theukvendingcompany.co.uk/shop/hot-chocolate/cadburys-hot-chocolate.html

aravot

@RCheesly, that is a Joomla breadcrumb, VirtueMart has it's own breadcrumb, to enable go to Configuration -> Site (tab) -> Layout (Configuration) -> Show additional Pathway on the Product Page?

ledom

Hi aravot,

Got the same problem on virtuemart 1.1.2 with joomla 1.5.9 breadcrumb module.

The problem is that I need only one breadcrumb for all the website, and virtuemart breadcrumb does not show for the blog and other menus.

Is there any way to solve this problem with ' ?

trsander

I am having the same issue.  I made the code change suggested above but it just made the product breadcrumb item disappear.  Do we know when this will be corrected?
Thank you

fire2

I'm using VM 1.1.3 on Joomla 1.5.10 and I'm having the same problem. I changed the suggested code above, but it only made the product name dissapear from the breadcrumb/pathway.

Any suggestion to fix this?

Thanks.
Yh
currently using:
Joomla 2.5.8
VM 2.0.14


kIsa_camel

here's the breadcrumb solution for VM 1.1.3 i just did a few seconds ago :

go to line 303 or find the below lines in the file administrator/components/com_virtuemart/html/shop.product_details.php :



// Add this product's name to the pathway, with no link

$item = new stdClass();

$item->name = $product_name;

$item->link = '';

$pathway[] = $item;



change the $item->name = $product_name;  line with the below line :



$item->name = html_entity_decode( $product_name, ENT_QUOTES );



The single quote characters (or any other html encoded characters) in the product name will display correctly on your breadcrumb.

8)
http://www.sanalpos-tr.com
custom payment mods, modification projects, installation-configuration-migration support for vm