Author Topic: VM - Custom, Virtuemart Simple Download Plugin  (Read 390 times)

MAD King

  • Full Member
  • ***
  • Posts: 583
  • Supporter Membership - Gold
  • VirtueMart Version: Always the Latest
VM - Custom, Virtuemart Simple Download Plugin
« on: September 27, 2023, 19:34:18 PM »
What is this?
It comes up when migrating to J4.

Quote
VM - Custom, Virtuemart Simple Download Plugin Site   Plugin   ${PHING.VERSION}   September 06 2019   Max Milbers   vmcustom
Joomla! 4.3.4
VirtueMart 4.2.4 10922

Studio 42

  • Contributing Developer
  • Sr. Member
  • *
  • Posts: 4728
  • Joomla & Virtuemart developper
    • Studio 42 - Virtuemart & Joomla extentions
  • VirtueMart Version: 2.6 & 3
Re: VM - Custom, Virtuemart Simple Download Plugin
« Reply #1 on: September 28, 2023, 08:16:21 AM »
It's a download plugin from VM team

MAD King

  • Full Member
  • ***
  • Posts: 583
  • Supporter Membership - Gold
  • VirtueMart Version: Always the Latest
Re: VM - Custom, Virtuemart Simple Download Plugin
« Reply #2 on: September 28, 2023, 13:28:42 PM »
This cannot be correct: ${PHING.VERSION}
It will probably mess up the migration to J4.
Joomla! 4.3.4
VirtueMart 4.2.4 10922

Studio 42

  • Contributing Developer
  • Sr. Member
  • *
  • Posts: 4728
  • Joomla & Virtuemart developper
    • Studio 42 - Virtuemart & Joomla extentions
  • VirtueMart Version: 2.6 & 3
Re: VM - Custom, Virtuemart Simple Download Plugin
« Reply #3 on: September 28, 2023, 14:05:03 PM »
This is because they use SVN and not used a version to create the package

MAD King

  • Full Member
  • ***
  • Posts: 583
  • Supporter Membership - Gold
  • VirtueMart Version: Always the Latest
Re: VM - Custom, Virtuemart Simple Download Plugin
« Reply #4 on: September 28, 2023, 14:16:53 PM »
I do not have this on my other 3 websites: ${PHING.VERSION}. Just checked.
Joomla! 4.3.4
VirtueMart 4.2.4 10922

Studio 42

  • Contributing Developer
  • Sr. Member
  • *
  • Posts: 4728
  • Joomla & Virtuemart developper
    • Studio 42 - Virtuemart & Joomla extentions
  • VirtueMart Version: 2.6 & 3
Re: VM - Custom, Virtuemart Simple Download Plugin
« Reply #5 on: September 28, 2023, 16:01:26 PM »
${PHING.VERSION} is modified when you create a package
If you compress directly the folder. Then the ${PHING.VERSION} is not modified using phing
So perhaps the phing VERSION variable is missing or the zip was created directly
This is  not a Joomla 4 problem. But a mistake from VM dev team

MAD King

  • Full Member
  • ***
  • Posts: 583
  • Supporter Membership - Gold
  • VirtueMart Version: Always the Latest
Re: VM - Custom, Virtuemart Simple Download Plugin
« Reply #6 on: September 28, 2023, 16:24:27 PM »

This is  not a Joomla 4 problem. But a mistake from VM dev team

That's why I posted it here and not on the Joomla forum.
Joomla! 4.3.4
VirtueMart 4.2.4 10922