News:

Support the VirtueMart project and become a member

Main Menu

IPs v6 truncated in the DB

Started by man.of.earth, December 19, 2019, 11:56:25 AM

Previous topic - Next topic

man.of.earth

Hello developers,

I noticed that the IPs are truncated in the database, in #__virtuemart_orders table, ip_address column, as its length is set to char(15) (supports only IPs v4). To remedy this, its length should be set to at least 39 (see https://stackoverflow.com/questions/166132/maximum-length-of-the-textual-representation-of-an-ipv6-address ).

I guess the maskIP routine should also be modified/updated a bit, as the last group of digits for IPs v6 is 4 in length (compared to 3 for the IPs v4).

AH

IMHO

We should not be storing customer IPs for PayPal payments

But that is just my view
Regards
A

Joomla 3.10.11
php 8.0

man.of.earth

That's a different subject. There is the default option to mask IP.
I was referring to the technical aspect of the lengths of IPs, v4 and v6.

AH

Yes - you are right VM should consider IP6



Regards
A

Joomla 3.10.11
php 8.0