Author Topic: VM BE report graph does not consider „completed” orders and products (code 'F')  (Read 121 times)

arcturus

  • Jr. Member
  • **
  • Posts: 110
  • VirtueMart Version: 3.6.10 10211
Hello developers,

I noticed that in VM cpanel ( /administrator/index.php?option=com_virtuemart&view=virtuemart ), that chart does not also consider the orders and works with the „completed” status ('F'), but only „shipped” and „confirmed by the store” (so not being accurate).
I found the remedy to this, in /administrator/components/com_virtuemart/models/report.php , line 137:
Code: [Select]
$orderstates = vRequest::getVar ('order_status_code', array('C','S','F'));instead of
Code: [Select]
$orderstates = vRequest::getVar ('order_status_code', array('C','S'));as it is now.

The same situation is in
/administrator/components/com_virtuemart/views/report/view.html.php on line 80:
Code: [Select]
$orderstates = vRequest::getVar ('order_status_code', array('C','S')); ->
Code: [Select]
$orderstates = vRequest::getVar ('order_status_code', array('C','S','F'));
and in
/plugins/vmcustom/istraxx_download_simple/istraxx_downloader_simple.php on line 68:
Code: [Select]
$os_download = array('C','S'); ->
Code: [Select]
$os_download = array('C','S','F');The last one is debatable, according to whether the users can download the files [again] (if they have downloads left) after their order has been marked as „completed”.
Cheers,
George
https://www.proxima-mundi.ro

Now I'm using Joomla! 3.9.14 and VM 3.6.10 10211 on PHP 7.3.9