Author Topic: "No shop currency defined" error  (Read 225 times)

dmb

  • Jr. Member
  • **
  • Posts: 80
  • A beginner
"No shop currency defined" error
« on: January 12, 2019, 13:03:56 pm »
I've upgraded to VM 3.4.2 in advance of upgrading from J3.8.11 and in testing everything look OK so far, though on successful checkout I see an error

"No Shop Currency defined! Go to https://site_url/administrator/index.php?option=com_virtuemart&view=user&task=editshop


The site currency is defined, as "Currency: British pound" and "List of accepted currencies: British pound"

I've found quite a few ancient posts with this error, but the recommended fix is to ensure that a currency is set, and I've done this without effect.

A bit of digging shows that the error is generated in line 291 of administrator/components/com_virtuemart/models/vendor.php in the function getVendorCurrency ($_vendorId), and that the vendorId parameter is set to 52. This seems wrong: 52 is the value of the GBP currency, and the vendor for the site has ID=1.

Any ideas ?

Thanks,

David


jenkinhill

  • UK Web Developer & Consultant
  • Global Moderator
  • Super Hero
  • *
  • Posts: 27150
  • Always on vacation
    • Jenkin Hill Internet
Re: "No shop currency defined" error
« Reply #1 on: January 12, 2019, 14:07:54 pm »
Is the currency in the Payment Method also set to British Pound?
Kelvyn

Jenkin Hill Internet,
Lowestoft, Suffolk, UK

Unsolicited PMs/emails will be ignored.

Please mention your VirtueMart, Joomla and PHP versions when asking a question in this forum

Currently using VM 3.4.3.9989 on Joomla 3.9.2 PHP 7.0.33
Testing VM 3.4.3.10005 on Joomla 3.9.2

dmb

  • Jr. Member
  • **
  • Posts: 80
  • A beginner
Re: "No shop currency defined" error
« Reply #2 on: January 12, 2019, 14:24:59 pm »
Yes, I checked all payment methods, all show British pound.

Cheers,

David

ElTrull

  • Beginner
  • *
  • Posts: 2
  • A beginner
Re: "No shop currency defined" error
« Reply #3 on: January 13, 2019, 21:28:16 pm »
Hi there,

unfortunately i have to report the same Error. You can see it at:
https://teichpiraten.de/index.php?option=com_virtuemart&view=vmplg&task=pluginresponsereceived&on=J2Y3022&pm=5&Itemid=113

I searched the whole day to fix this but no chance. Everything seems to be configured correct. It only appears if users pay via papal and are redirected to the shop.

I also activated the "automatic redirect" from paypal and linked it to a thank you page that a created. But even this redirect to the thank you (https://teichpiraten.de/kaufbestaetigung)page does not work. It still ends up here https://teichpiraten.de/index.php?option=com_virtuemart&view=vmplg&task=pluginresponsereceived&on=J2Y3022&pm=5&Itemid=113 with the currency warning at the top.

BTW: Also this is (even without the warning) a no really professioinal design of a thank you page - in my opinion. So i tried to find the template to modify this. I found /components/com_virtuemart/views/cart/tmpl/oder_done.php but this seems not to be the page where the redirect ends? Where can i modify this page?

I really hope we find a solution soon.

Greetz


GJC Web Design

  • 3rd party VirtueMart Developer
  • Super Hero
  • *
  • Posts: 8681
  • Virtuemart, Joomla & php developer
    • GJC Web Design
  • VirtueMart Version: 2.6.22 & 3.2.14
Re: "No shop currency defined" error
« Reply #4 on: January 13, 2019, 22:38:19 pm »
@ElTrull - is this VM 3.4.2 ??  versions matter

is com_virtuemart/views/cart/tmpl/oderdone.php ... no underscore ... order_done is there for back compat
GJC Web Design
VirtueMart and Joomla Developers - php developers http://www.gjcwebdesign.com
VM3 AusPost Shipping Plugin - e-go Shipping Plugin - VM3 Postcode Shipping Plugin - Radius Shipping Plugin - VM3 NZ Post Shipping Plugin - AusPost Estimator
Samport Payment Plugin - EcomMerchant Payment Plugin - ccBill payment Plugin
VM2 Product Lock Extension - VM2 Preconfig Adresses Extension - TaxCloud USA Taxes Plugin - Virtuemart  Product Review Component
http://extensions.joomla.org/profile/profile/details/67210
Contact for any VirtueMart or Joomla development & customisation

ElTrull

  • Beginner
  • *
  • Posts: 2
  • A beginner
Re: "No shop currency defined" error
« Reply #5 on: January 14, 2019, 18:16:29 pm »
Hi,

the VM version is 3.4.2, Joomla 3.9.1.

I hope this helps.

Greetz

dmb

  • Jr. Member
  • **
  • Posts: 80
  • A beginner
Re: "No shop currency defined" error
« Reply #6 on: January 15, 2019, 09:18:39 am »
Just to note that I agree that it seems linked to Paypal payments.

I've commented out line 291 of administrator/components/com_virtuemart/models/vendor.php for the moment so that the message is not displayed, as I can't actually find any problematic effect - all the data looks OK on the database, and the payments are going through OK. I suspect that some record, somewhere has a blank currency value but it doesn't seem to matter.

GJC Web Design

  • 3rd party VirtueMart Developer
  • Super Hero
  • *
  • Posts: 8681
  • Virtuemart, Joomla & php developer
    • GJC Web Design
  • VirtueMart Version: 2.6.22 & 3.2.14
Re: "No shop currency defined" error
« Reply #7 on: January 15, 2019, 11:23:24 am »
What about vendor settings?
If u have multi vendor or perhaps a misconfig ( 2 users marked as vendors  .- u should see a warning about this to fix) then the vendor comes into play with the payment methods
GJC Web Design
VirtueMart and Joomla Developers - php developers http://www.gjcwebdesign.com
VM3 AusPost Shipping Plugin - e-go Shipping Plugin - VM3 Postcode Shipping Plugin - Radius Shipping Plugin - VM3 NZ Post Shipping Plugin - AusPost Estimator
Samport Payment Plugin - EcomMerchant Payment Plugin - ccBill payment Plugin
VM2 Product Lock Extension - VM2 Preconfig Adresses Extension - TaxCloud USA Taxes Plugin - Virtuemart  Product Review Component
http://extensions.joomla.org/profile/profile/details/67210
Contact for any VirtueMart or Joomla development & customisation