News:

Support the VirtueMart project and become a member

Main Menu

Vendor Comments Not Saving Unless Order Status Changed

Started by Creepzn, November 21, 2018, 11:40:15 AM

Previous topic - Next topic

Creepzn

Hi there

Not sure if anyone has a solution for this, but when I try add comments on orders without changing the order status, the comments do not save. When changing the status of orders and simultaneously add a comment, the comments save.

I was able to add multiple comments without changing the status of orders to keep track of follow up calls etc.

Joomla version 3.9
VM Version 3.4
Affordable web design, banners, flyers and logos + IT sales https://webits.co.za

Jörgen

In order list view or single order view ?

Jörgen @ Kreativ Fotografi
Joomla 3.9.18
Virtuemart 3.4.x
Olympiantheme Hera (customized)
This reflects current status when viewing old post.

GJC Web Design

Yes .. if the status isn't changed the "update" does nothing

it fails the check in the orders model

public function updateOrderHistory($inputOrder)

if(empty($oldHistoryRow) or $oldHistoryRow->order_status_code!=$inputOrder['order_status_code'])

if(empty($oldHistoryRow) or $oldHistoryRow->order_status_code!=$inputOrder['order_status_code']){
$_orderHist = $this->getTable('order_histories');
$inputOrder['comments'] = nl2br($inputOrder['comments']); //would be cooler in the table check function
$_orderHist->bindChecknStore($inputOrder);
}


You could mark this as a feature request as some sort of case or switch here to just save comments without  status change might be useful

or hack and comment out the if

or set it to another status with the comment then put it back to the previous
GJC Web Design
VirtueMart and Joomla Developers - php developers https://www.gjcwebdesign.com
VM4 AusPost Shipping Plugin - e-go Shipping Plugin - VM4 Postcode Shipping Plugin - Radius Shipping Plugin - VM4 NZ Post Shipping Plugin - AusPost Estimator
Samport Payment Plugin - EcomMerchant Payment Plugin - ccBill payment Plugin
VM2 Product Lock Extension - VM2 Preconfig Adresses Extension - TaxCloud USA Taxes Plugin - Virtuemart  Product Review Component
https://extensions.joomla.org/profile/profile/details/67210
Contact for any VirtueMart or Joomla development & customisation

Creepzn

Thanks for your responses. This happens in both single and list order view.
Affordable web design, banners, flyers and logos + IT sales https://webits.co.za

Creepzn

The switching to another status is a temporary solution for now, but obviously not a great one at all. Will try comment out the "if", but where is that script?
Affordable web design, banners, flyers and logos + IT sales https://webits.co.za

GJC Web Design

Quoteit fails the check in the orders model

public function updateOrderHistory($inputOrder)

if(empty($oldHistoryRow) or $oldHistoryRow->order_status_code!=$inputOrder['order_status_code'])


admin - vm - models - orders.php
GJC Web Design
VirtueMart and Joomla Developers - php developers https://www.gjcwebdesign.com
VM4 AusPost Shipping Plugin - e-go Shipping Plugin - VM4 Postcode Shipping Plugin - Radius Shipping Plugin - VM4 NZ Post Shipping Plugin - AusPost Estimator
Samport Payment Plugin - EcomMerchant Payment Plugin - ccBill payment Plugin
VM2 Product Lock Extension - VM2 Preconfig Adresses Extension - TaxCloud USA Taxes Plugin - Virtuemart  Product Review Component
https://extensions.joomla.org/profile/profile/details/67210
Contact for any VirtueMart or Joomla development & customisation

Creepzn

Thank you

I tried commenting that out, but the function of the order comments remained the same
Affordable web design, banners, flyers and logos + IT sales https://webits.co.za

GJC Web Design

GJC Web Design
VirtueMart and Joomla Developers - php developers https://www.gjcwebdesign.com
VM4 AusPost Shipping Plugin - e-go Shipping Plugin - VM4 Postcode Shipping Plugin - Radius Shipping Plugin - VM4 NZ Post Shipping Plugin - AusPost Estimator
Samport Payment Plugin - EcomMerchant Payment Plugin - ccBill payment Plugin
VM2 Product Lock Extension - VM2 Preconfig Adresses Extension - TaxCloud USA Taxes Plugin - Virtuemart  Product Review Component
https://extensions.joomla.org/profile/profile/details/67210
Contact for any VirtueMart or Joomla development & customisation

mohtashimj

By commenting the if condition works for me.

Thank you!