Author Topic: Only VatTax (VAT tax per product) works when updating an order  (Read 1103 times)

Robert_ITMan

  • Jr. Member
  • **
  • Posts: 160
    • websites developed and managed @ ourfingertips.com
  • VirtueMart Version: LIVE 3.2.12 and testing latest
Only VatTax (VAT tax per product) works when updating an order
« on: October 14, 2018, 15:47:48 pm »
Only VatTax (VAT tax per product) works when updating an order – the other options TaxBill (Tax per order) and Tax (Tax per product) will not calculate the taxes when updating an order. Even with suggested work around to instead use VatTax … that only works for new orders received. (more info see: http://forum.virtuemart.net/index.php?topic=136852.msg497109#msg497109)

I need a solution that works for the orders I have in the system now… and so will all the other VM users not using VatTax (VAT tax per product) who want to update an order.

Unfortunately this needs fixing in the VM core - and seeing as I'm the only one asking for it to be fixed it is not a priority and might not be fixed anytime soon ...

So if you ever want to update an order and realize the totals did not add up correctly then let us know by replying here.

FYI - Notice even when not selecting the calculate boxes the taxes still need to be updated manually in the database directly as they are zeroed out when saving order item changes… depending on which tax was used when the order was created need to either update (1) TaxBill (Tax per order): both #__virtuemart_orders and #__virtuemart_order_calc_rules or (2) Tax (Tax per product): both #__virtuemart_orders and #__virtuemart_order_items
Let me know if I can help in anyway!

Hope all is good with you and yours - stay safe! So far all is good with me and mine.

www.ourfingertips.com - websites developed and managed @ ourfingertips

Let me help you make the most of the technology at our fingertips

AH

  • Global Moderator
  • Sr. Member
  • *
  • Posts: 3280
  • VirtueMart Version: 3.8.4
Re: Only VatTax (VAT tax per product) works when updating an order
« Reply #1 on: October 14, 2018, 17:46:32 pm »
Quote
Notice even when not selecting the calculate boxes the taxes still need to be updated manually in the database directly as they are zeroed out when saving order item changes

You may wish to run this test again - when I uncheck the boxes the tax is not modified in any way.  It certainly is not zeroed out?
regards
A

Joomla 3.9.20
php 7.3

Robert_ITMan

  • Jr. Member
  • **
  • Posts: 160
    • websites developed and managed @ ourfingertips.com
  • VirtueMart Version: LIVE 3.2.12 and testing latest
Re: Only VatTax (VAT tax per product) works when updating an order
« Reply #2 on: October 14, 2018, 18:27:36 pm »
You may wish to run this test again - when I uncheck the boxes the tax is not modified in any way.  It certainly is not zeroed out?

Yes, I have tested this - again it only works when original order was with VatTax (VAT tax per product)
Let me know if I can help in anyway!

Hope all is good with you and yours - stay safe! So far all is good with me and mine.

www.ourfingertips.com - websites developed and managed @ ourfingertips

Let me help you make the most of the technology at our fingertips

AH

  • Global Moderator
  • Sr. Member
  • *
  • Posts: 3280
  • VirtueMart Version: 3.8.4
Re: Only VatTax (VAT tax per product) works when updating an order
« Reply #3 on: October 15, 2018, 11:21:14 am »
Quote
Notice even when not selecting the calculate boxes the taxes still need to be updated manually in the database directly as they are zeroed out when saving order item changes

I tested a new order with taxes set as tax per bill - when I uncheck all the check boxes including the total and not just the product - the tax per bill is not changed

The issue is now that you have a variety of orders saved in your order tables with varying calculation methods - so it is unlikely to work for back orders
regards
A

Joomla 3.9.20
php 7.3

Robert_ITMan

  • Jr. Member
  • **
  • Posts: 160
    • websites developed and managed @ ourfingertips.com
  • VirtueMart Version: LIVE 3.2.12 and testing latest
Re: Only VatTax (VAT tax per product) works when updating an order
« Reply #4 on: October 15, 2018, 14:34:47 pm »
I tested a new order with taxes set as tax per bill - when I uncheck all the check boxes including the total and not just the product - the tax per bill is not changed
Lucky you - as I said this does not work for my sites - so there is something more at play here?
The issue is now that you have a variety of orders saved in your order tables with varying calculation methods - so it is unlikely to work for back orders
Yes - this is a problem, should not matter which tax method we choose it should work. I have now 3 types:
  • TaxBill (Tax per order) - what I want but does not work
  • Tax (Tax per product) - changed so products with no taxes calculated OK, see topic 'VirtueMart 3 product select 'apply no rule' does not work - need 'tax exempt'!' http://forum.virtuemart.net/index.php?topic=141123
  • VatTax (VAT tax per product) - just started using this as we learned this is the only one that works
Let me know if I can help in anyway!

Hope all is good with you and yours - stay safe! So far all is good with me and mine.

www.ourfingertips.com - websites developed and managed @ ourfingertips

Let me help you make the most of the technology at our fingertips