Author Topic: Cloning products warning  (Read 584 times)

Studio 42

  • Contributing Developer
  • Sr. Member
  • *
  • Posts: 3522
  • Joomla & Virtuemart addon developper
    • Studio 42 - Virtuemart & Joomla extentions
  • VirtueMart Version: 2.6 & 3.0.x.y
Cloning products warning
« on: January 08, 2018, 18:34:00 pm »
Warning on clone product
Notice: Undefined index: myroot/administrator/components/com_virtuemart/models/customfields.php on line <i>1102</i>
line is :
Code: [Select]
if($fields['field_type']=='C'){Note that with luck, this permit to not clone the "C" field type on cloning because this need child before.
Notice: Undefined index: field_type in myroot/administrator/components/com_virtuemart/models/customfields.php on line <i>1160
line is :
Code: [Select]
VirtueMartModelCustom::setParameterableByFieldType($tableCustomfields,$fields['field_type'],$fields['custom_element'],$fields['custom_jplugin_id']);I think this is a bigger problem when you clone customfields plugins.
Note that if you log this in a file, you have 3 errors per customfields on clone.
Perhaps dev team understand better why warning messages are so important to check to prevent bad values ?

Note that i have other case as dev where i need myself to prevent bad values in VM(eg child creation), but of course this is low priority, so i don't want to bore you with it.

Joomla 3.8.3 + VirtueMart 3.2.12

Milbo

  • Virtuemart Projectleader
  • Administrator
  • Super Hero
  • *
  • Posts: 9743
  • VM3.2 Cached and Optimized
    • VM3 Extensions
  • VirtueMart Version: VirtueMart 3 on joomla 3
Re: Cloning products warning
« Reply #1 on: January 09, 2018, 01:00:22 am »
Thank you for reporting. This error is fixed, but not in svn yet.
I should fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

Milbo

  • Virtuemart Projectleader
  • Administrator
  • Super Hero
  • *
  • Posts: 9743
  • VM3.2 Cached and Optimized
    • VM3 Extensions
  • VirtueMart Version: VirtueMart 3 on joomla 3
Re: Cloning products warning
« Reply #2 on: January 09, 2018, 11:25:11 am »
committed. Btw I often said, that we are intersted in any  warning, notice or just deprecated message. I really wonder why you all the time repeat the false information, that we are not interested. When we wrote vm2 and worked with vm1.9 I said that our focus does not rely on removing deprecated notes.
I should fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

Studio 42

  • Contributing Developer
  • Sr. Member
  • *
  • Posts: 3522
  • Joomla & Virtuemart addon developper
    • Studio 42 - Virtuemart & Joomla extentions
  • VirtueMart Version: 2.6 &amp; 3.0.x.y
Re: Cloning products warning
« Reply #3 on: January 09, 2018, 16:00:18 pm »
How you want i send you bugs, if you blame me always ?
You mean that i like to find problems, i have to work with it and other developers to.
For me the priority is to have a PRO virtuemart safe and without any bugs!
It's not the priority of the team and other users ?