Author Topic: Do we need this? from mediahandler.php  (Read 1995 times)

aha

  • Beginner
  • *
  • Posts: 4
  • A beginner
Do we need this? from mediahandler.php
« on: April 02, 2016, 05:43:43 am »
In file
\administrator\components\com_virtuemart\helpers\mediahandler.php
line 

279 //Do we need this?
280   /*   if(!empty($this->file_url) && empty($this->file_url_thumb)){
281         $this->displayMediaThumb('',true,'',false);
282      }*/

off
Why?

But They Need
without them the second and subsequent picture in the administrative part of the list of products displayed incomprehensible delay.
If you make the line active all works well.

Jörgen

  • Global Moderator
  • Sr. Member
  • *
  • Posts: 2910
    • Kreativ Fotografi
  • VirtueMart Version: 3.4.x
Re: Do we need this? from mediahandler.php
« Reply #1 on: April 02, 2016, 14:22:40 pm »
Hello

I can see that this has been commented out since 3.0.12. Right now I use 3.0.8 and if I try to comment these lines in 3.0.8 I get the same results. What version are You using? I just can´t believe that this has been malfunctioning since ver 3.0.12 :)

When started this to show for You ?

regards

Jörgen @ Kreativ Fotografi

Joomla 3.9.18
Virtuemart 3.4.x
Olympiantheme Hera (customized)

aha

  • Beginner
  • *
  • Posts: 4
  • A beginner
Re: Do we need this? from mediahandler.php
« Reply #2 on: April 03, 2016, 07:58:51 am »
Hello

I can see that this has been commented out since 3.0.12. Right now I use 3.0.8 and if I try to comment these lines in 3.0.8 I get the same results. What version are You using? I just can´t believe that this has been malfunctioning since ver 3.0.12 :)

When started this to show for You ?

regards

Jörgen @ Kreativ Fotografi

That's right. It started with version 3.0.12.
Up to version 3.0.11.4 is operating normally.

Regards
aha

Milbo

  • Virtuemart Projectleader
  • Administrator
  • Super Hero
  • *
  • Posts: 10070
  • VM3.2 Cached and Optimized
    • VM3 Extensions
  • VirtueMart Version: VirtueMart 3 on joomla 3
Re: Do we need this? from mediahandler.php
« Reply #3 on: April 04, 2016, 12:56:55 pm »
In file
\administrator\components\com_virtuemart\helpers\mediahandler.php
line 

279 //Do we need this?
280   /*   if(!empty($this->file_url) && empty($this->file_url_thumb)){
281         $this->displayMediaThumb('',true,'',false);
282      }*/

off
Why?

Because the file_url_thumb is dynamically generated in displayMediaThumb by $file_url_thumb = $this -> getFileUrlThumb($width, $height); and so the $this->file_url_thumb is empty. It is now always empty, except an override is defined.
I should fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

jenkinhill

  • UK Web Developer & Consultant
  • Global Moderator
  • Super Hero
  • *
  • Posts: 27798
  • Always on vacation
    • Jenkin Hill Internet
Re: Do we need this? from mediahandler.php
« Reply #4 on: April 04, 2016, 13:07:12 pm »
After a second/third etc image is uploaded & saved for a product it does not appear in the BE until the FE product page with that image is viewed. On refreshing the BE page the new thumb then appears.
Kelvyn

Jenkin Hill Internet,
Lowestoft, Suffolk, UK

Unsolicited PMs/emails will be ignored.

Please mention your VirtueMart, Joomla and PHP versions when asking a question in this forum

Currently using VM 3.8.4.10335 on Joomla 3.9.19 PHP 7.3.18

GJC Web Design

  • 3rd party VirtueMart Developer
  • Super Hero
  • *
  • Posts: 9747
  • Virtuemart, Joomla & php developer
    • GJC Web Design
  • VirtueMart Version: 3.6.8
Re: Do we need this? from mediahandler.php
« Reply #5 on: April 04, 2016, 17:08:21 pm »
ah .. so the thumb is only created when FE accessed .. makes sense i guess
GJC Web Design
VirtueMart and Joomla Developers - php developers http://www.gjcwebdesign.com
VM3 AusPost Shipping Plugin - e-go Shipping Plugin - VM3 Postcode Shipping Plugin - Radius Shipping Plugin - VM3 NZ Post Shipping Plugin - AusPost Estimator
Samport Payment Plugin - EcomMerchant Payment Plugin - ccBill payment Plugin
VM2 Product Lock Extension - VM2 Preconfig Adresses Extension - TaxCloud USA Taxes Plugin - Virtuemart  Product Review Component
http://extensions.joomla.org/profile/profile/details/67210
Contact for any VirtueMart or Joomla development & customisation