Author Topic: Update VirtueMart 3.0.12 to 3.0.14 - add to cart POPUP Facebox not work  (Read 5355 times)

Doomas

  • Beginner
  • *
  • Posts: 11
Re: Update VirtueMart 3.0.12 to 3.0.14 - add to cart POPUP Facebox not work
« Reply #15 on: April 20, 2016, 12:11:33 pm »
Quote
I found the problem is the "Show cart" link in the "Add to Cart" Pop-up. My customers site runs on https, but the "Show cart" link in the Pop-up points to http://....

Never mind....I found the Problem.
"Enable SSL for sensitive areas (recommended)" in the VM configuration was not enabled.

BUT, in my view it's a very strange behaviour. If your whole site is running over SSL( Forced by the Joomla configuration). The above VM config option should not be allowed to override it back to http, if it is not enabled.

@Thomas Kuschel
Thanks! I did not test your code yet, but it lead my to the correct solution of my problem.

Thomas Kuschel

  • Jr. Member
  • **
  • Posts: 81
    • LOYTEC electronics GmbH
Re: Update VirtueMart 3.0.12 to 3.0.14 - add to cart POPUP Facebox not work
« Reply #16 on: April 20, 2016, 12:40:31 pm »
The problem is that code at components/com_virtuemart/helpers/vmview.php, possibly it appears more than once in VM:
Code: [Select]
$scheme = 'http';
if(VmConfig::get('useSSL',false)){
$scheme .='s';
}

A solution: http://forum.virtuemart.net/index.php?topic=133941.0   - With JRoute, it does not change back to http if you're on https. It's better using Joomla core functions then the obove code which implies to have set useSSL=1.

Milbo

  • Virtuemart Projectleader
  • Administrator
  • Super Hero
  • *
  • Posts: 9997
  • VM3.2 Cached and Optimized
    • VM3 Extensions
  • VirtueMart Version: VirtueMart 3 on joomla 3
Re: Update VirtueMart 3.0.12 to 3.0.14 - add to cart POPUP Facebox not work
« Reply #17 on: April 20, 2016, 20:37:53 pm »
Thank you for pointing that out. I agree a common function would be better.
I should fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/