New stable Release Candidate 3.0.13 released, please anyone test.

Started by Milbo, February 09, 2016, 23:44:53 PM

Previous topic - Next topic

Milbo

This is a very matured release. The maintrunk is already working with the new VMF system which should help to write a bridge for Wordpress. I decided to create a new branch and to release an interims version. It has any fixes and features enhancements until 5. January. Any bug or feature related code got backported.
You should in any case make a backup of your database. The tableupdater got strongly enhanced and should handle tables with broken or missing primary fields (fields with auto_increment) a lot better. But it is due the logic of enhancement just not 1 Million times tested as the old one.

Changes from vm3.0.13.0 - vm3.0.13.4:

r9170
Paypal IPN in case payment type='cart' and payment_currency=order_currency
---------------------
r9169
Minors for vm3.0.13.4
---------------------
r9168
Updated router, works now without product suffix
---------------------
r9166
Important code adjustment for avatax  added ssl support for add to cart popup
---------------------
r9164
Backport to vm3.0.14 cache for language loading, so we can use "reload=true" Removed the , in sort keys (check product.php) removed unnecessary vmText in the list for userfield names
---------------------
r9162
- Swapped parameters for vmError messages in function getMyOrderDetails to prevent that normal users sensitive information
- fixed mod_virtuemart_product, added divs for price js and added vmJsApi::writeJS() for cached modules content (cant be cached).
---------------------
r9160
adjusted html.php for php7 http://forum.virtuemart.net/index.php?topic=133113.msg461282#msg461282
---------------------
r9159
product filter in BE should be kept in session
---------------------
r9156
fixed language loading of invoices found again something in tableupdater, added UNIQUE to the condition checking for KEYS enhanced function getMyOrderDetails, also registered users can now visit a guest order, if they enter correct order pw
---------------------
r9154
tableupdater added now that the dropPrimary is only executed if either the old, or the new definition has an auto_increment and the dropPrimary functions also removes the auto_increment from any field before. But if new and old definition h...
fixed small error in product listing, lists media 0 if no media is attached.
---------------------

Changes since vm3.0.12:
in "short":
- MV as radio
- new layout for category module
- cleaned css
- security and rights managment, (mainly already done for vm3.0.12)
- fixes for tos.php, to set it unrequired
- create Product Clone sets the clone unpublished and product_ordered, product_sales to 0
- Router has new option, to create links without CategoryName
- absolute urls for canonical
- alternative layotus for FE modules
- js validator also for shipment addresses
- Enhanced js validation of country/state combo
- max_cats_per_product
- added hidden config product.published, which determines if a new product is already published. (by default not published)
- browse page shows generic child variants
- Added perms for order editing to the model
- better and robust code for vmvalidator js
- Fix for vmuploader.php, when exif_imagetype is not supported
- added bulk set order status
- captcha only for guests
- Added that the top category uses the set metadata
- added loading of product images for invoice
- orderDetails are now accessible in order_done.php
- enhanced tableupdater, also correcting missing Primary Keys

as raw:
r9153
Enhanced again the tableupdater. Primary keys are now directly created with the new auto_increment field, and if already existing dropped. So we could even change now the Primary column. This should prevent errors that sometimes users get a...
---------------------
r9152
for vm3.0, synchro, fixed tableupdater. Can add now missing Primaries, workaround is to create the field without Auto_increment, to create the key in the blue and to alter the field for the primary after
---------------------
r9147
virtumart.cfg parser understands // inline comments
---------------------
r9146
check if translation of COM_VIRTUEMART_PLUGIN_COST_DISPLAY has actually a / and must be split Added vendor Id to coupon sample
---------------------
r9145
little fix in migrator for related products fixed sampledata, Unit was missing for the root product and so for almost any product and so the shipment weight calculation failed
Added missing language keys added back port of links without cat...
---------------------
r9144
Updated heidelpay and  added weight unit for root product of the sampledata
---------------------
r9104
add Marge rules to OrderCalcRules
---------------------
r9103
New layout for the category module, a grid of the top level categories with images like the vm frontpage.
---------------------
r9102
add marge rules to product prices
---------------------
r9101
amazon: After synchronous AmazonRejected TransactionTimeout, cancel order on Amazon side
---------------------
r9098
Removed some duplicate css rules. Corrected the .right class.
Virtuemart.updateContent function updates now also the page title tag. 
---------------------
r9097
changed more smallint to int fixed small error, in generic child, which did not check the products for shoppergroups (was loaded for BE) added prodimg_browse and catimg_browse to define how many images should be loaded for browsing more rep...
---------------------
r9096
Customer_number: adding security
---------------------
r9095
Customer number: can be changed
---------------------
r9094
small error in sublayout tos.php, was not correctly set to unrequired reverted changes for registration mail
---------------------
r9092
amazon: refund
---------------------
r9091
amazon: getallheaders
---------------------
r9090
little typo in vmsjapi, which created "Virtuemart not defined" js error
create Product Clone sets the clone unpublished and product_ordered, product_sales to 0
Router has new option, to create links without CategoryName
---------------------
r9089
Canonical: absolute URLs
---------------------
r9084
Added option for alternative layouts to FE modules (search, currencies, cart, manufacturer). 
Reformatted all module xml files for readability.
---------------------
r9083
amazon: close reference when no more authorization will be created
---------------------
r9081
Realex: handling of 501: order already processed: do not change previous order status
---------------------
r9079
mediahandler displays and keeps thumbnail override path removed accidently added vmdebug better compatibility for js vars
---------------------
r9078
js validator also for shipment addresses
---------------------
r9077
Enhanced js validation of country/state combo added KEYS for product_in_stock and product_ordered
added JResponse::sendHeaders(); before echo json_encode
---------------------
r9076
Fixed php error when product has no rating.
---------------------
r9075
Enhanced handling of tasks with . by assigning task in the constructor Added more general handling of vm js variables. added inline to the header now.
Added vmJsApi::loadPopUpLib, to reuse the code loading the popup js Added check in store ...
---------------------
r9074
Added perms for order editing to the model better and robust code for vmvalidator js
Fix for vmuploader.php, when exif_imagetype is not supported fix when joomlaAddsubmitbutton was used twice
Added max cats per product for vendors  required...
---------------------
r9072
amazon: CaptureNotification: do not sen email to customer OrderReferenceNotification : get  reason code and update order language file: replacing "  by "_QQ_"
---------------------
r9071
countries codes / names fixes
---------------------
r9070
Correcting typo in BE en-GB.com_virtuemart.ini
---------------------
r9069
Changed a language string again in BE en-GB.com_virtuemart.ini and de-DE.com_virtuemart.ini
---------------------
r9068
Update of BE en-GB.com_virtuemart.ini and en-GB.com_virtuemart_config.ini plus corresponding de-DE files
---------------------
r9067
captcha only for guests
---------------------
r9065
amazon: fix for  ipn url when live and admin= https
---------------------
r9063
Added variable for active joomla language count  changed JPaginationObject in VmPagination to vPaginationObject Added fallback in media uploader for servers without exif_imagetype enhanced storing of calculation rules in orders added order ...
---------------------
r9061
amazon email fixes, countries => multiple
---------------------
r9059
amazon DE language file: wrong '
---------------------


by Alatak, JJK, kkmediaproduction, Milbo, and yourgeek
http://dev.virtuemart.net/attachments/download/991/com_virtuemart.3.0.13.4_extract_first.zip
http://dev.virtuemart.net/attachments/download/988/VirtueMart3.0.13_Joomla_2.5.29-Stable-Full_Package.zip
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

sandomatyas

Great imrovements :)
Some notices after few minutes in the BE:

  • After installing the component I got this message: Incorrect table definition; there can be only one auto column and it must be defined as a key SQL=ALTER TABLE `vm3_virtuemart_calcs` DROP PRIMARY KEY;
  • There is a pagination on the bottom of the list views but the limit box is missing: http://i.imgur.com/3MPvcx7.png
  • If I filter the products on the BE and do something with a product (publish, delete, etc) the filter is empty again: http://screencast.com/t/Ve00bRnilItP
  • The product list view displays 1 media if I haven't upload any
  • Shipment methods and payment methods have List Order field but I can't reorder them from the list view only if I open the method and write an integer to the field. Maybe it should be reorderable with arrows like other lists
  • Minor notice but the "noimage" image should be language independent. "Product Image unavailable" fits for English stores and also it's only for products but if I want to display category images, I get the "Product" noimage
  • The ordingering fields in the category are a bit messy: http://i.imgur.com/J4wVMdK.png
  • Most of my partners wants to see the final price in the product list views instead of the base price. I don't know if it is possible
But great job indeed :)

Milbo

Quote from: sandomatyas on February 10, 2016, 07:39:45 AM
After installing the component I got this message: Incorrect table definition; there can be only one auto column and it must be defined as a key SQL=ALTER TABLE `vm3_virtuemart_calcs` DROP PRIMARY KEY;
Hmm, I worked exactly on that. It seems you had the case, that the system meant to drop the Primary, while an auto_increment is still defined. In case you did a db backup it would be very good to have your table definition, before the update.

Quote from: sandomatyas on February 10, 2016, 07:39:45 AM
There is a pagination on the bottom of the list views but the limit box is missing: http://i.imgur.com/3MPvcx7.png
I am sorry, but I do not understand, what you mean. The list box is missing in j3 in general. It is an unresolved bug.

Quote from: sandomatyas on February 10, 2016, 07:39:45 AM
If I filter the products on the BE and do something with a product (publish, delete, etc) the filter is empty again: http://screencast.com/t/Ve00bRnilItP
Interesting question if we want to keep the filter, after execution of a task.

Quote from: sandomatyas on February 10, 2016, 07:39:45 AM
The product list view displays 1 media if I haven't upload any
yeh and when you click on it, you end up in an empty list, thank you for this observation.

Quote from: sandomatyas on February 10, 2016, 07:39:45 AM
Most of my partners wants to see the final price in the product list views instead of the base price. I don't know if it is possible
That is definitly possible and a normal forum question (templating/price building)
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

VMTemplates.net

Quote from: sandomatyas on February 10, 2016, 07:39:45 AM
After installing the component I got this message: Incorrect table definition; there can be only one auto column and it must be defined as a key SQL=ALTER TABLE `vm3_virtuemart_calcs` DROP PRIMARY KEY;
I'm getting the same issue on a number of an installation
We develop VirtueMart templates since 2008
https://www.virtuemarttemplates.net/
Join the VirtueMart Templates Club today and get an access to over 60 VirtueMart templates
https://www.virtuemarttemplates.net/template-club.html
If you need a custom VirtueMart Template design please visit https://www.virtuemarttemplates.net/custom-virtuemart-template-design.html
Visit our new shop https://demo.virtuemarttemplates.net/
Join the VirtueMart Templates Club, purchase the template or order one of our services like Hosting, Website Maintenance, Security and Optimization, Template Customization and more

sandomatyas

Thanks.
About the limit box:
If I check some core compontent list I can select how many items I want to display per page. Like Joomla plugin list: http://i.imgur.com/XDsDiGH.png
But there isn't a dropdown like this in VM

Milbo

Quote from: VMTemplates.net on February 10, 2016, 10:49:45 AM
Quote from: sandomatyas on February 10, 2016, 07:39:45 AM
After installing the component I got this message: Incorrect table definition; there can be only one auto column and it must be defined as a key SQL=ALTER TABLE `vm3_virtuemart_calcs` DROP PRIMARY KEY;
I'm getting the same issue on a number of an installation

I found the problem. As I explained, I enhanced the tableupdater, but missed the case, when both fields are auto_increment and only the field definition itself has changed. In our case it is from smallint to int.

I added now that the dropPrimary is only executed if either the old, or the new definition has an auto_increment and the dropPrimary functions also removes the auto_increment from any field before. But if new and old definition have an autoincrement attribute, then the primary key is untouched.

Btw, uploaded the new version
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

Milbo

Quote from: sandomatyas on February 10, 2016, 11:06:11 AM
Thanks.
About the limit box:
If I check some core compontent list I can select how many items I want to display per page. Like Joomla plugin list: http://i.imgur.com/XDsDiGH.png
But there isn't a dropdown like this in VM

Yepp, but that is atm not solved in general and not part of the feature/bug list.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

lindapowers

Quote from: Milbo on February 10, 2016, 12:04:56 PM
Quote from: sandomatyas on February 10, 2016, 11:06:11 AM
Thanks.
About the limit box:
If I check some core compontent list I can select how many items I want to display per page. Like Joomla plugin list: http://i.imgur.com/XDsDiGH.png
But there isn't a dropdown like this in VM

Yepp, but that is atm not solved in general and not part of the feature/bug list.

This works in core joomla, in every section and in every component, you have it in the user list at top right, in the article manager etc and is working also in components for VM like CSVIpro or vmrewardpoints.

So yes is not solved in vm but no is not a bug in joomla and not missing there sorry.

franayala

www.cuidadicos.es - Natural suplements and beauty

Milbo

It is for whatever reason not compatible with the old one and seen as minor problem. You can still change the general listing. It is not a new bug, nor part of the list, that is all what I said. So I was looking for a new problem. I  take a look for vm3.0.14. I think anyway it is more a template problem.

Btw, product listing should show now 0 media
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

franayala

template issue? we all use ISIS and this only fails in VM

?!?!?
www.cuidadicos.es - Natural suplements and beauty

franayala

and the button for reordering categories doesn't work either, you have to order them manually, in general every ordering function is not working :(
www.cuidadicos.es - Natural suplements and beauty

Milbo

Quote from: franayala on February 10, 2016, 13:13:14 PM
template issue? we all use ISIS and this only fails in VM

?!?!?

I just checked it again. It is definitly a template issue! If you use the ISIS template, then it uses for the list footer an override function, which does NOT show the limitlist. Instead they show the limitlist on the top.

So we could provide overrides, which also have an additional display of the limitbox on top. Or we add the limitlist on top in general, but then the top box would be overwritten by the bottom box and we would need a js, else people complain that they change the topbox without result. Disabling, or displaying the box if it is joomla 3 would create problems on templates without the override and are not clean.

We could also use always the ISIS method, also in j2.5. It would mean that we have to change any layout, just because ISIS did an override. Somehow all of this is silly.

You can test this yourself, just disabling the override of the ISIS template /administrator/templates/isis/html/pagination.php
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

Milbo

Quote from: franayala on February 10, 2016, 13:15:58 PM
and the button for reordering categories doesn't work either, you have to order them manually, in general every ordering function is not working :(

I cannot confirm.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/