News:

Support the VirtueMart project and become a member

Main Menu

Children

Started by Topknotch, November 29, 2015, 19:09:00 PM

Previous topic - Next topic

GJC Web Design

...  out of ideas.. they work for me.. the only dif I can see is there is no spaces etc in the test products

have u tried with just a word -- no spaces
GJC Web Design
VirtueMart and Joomla Developers - php developers https://www.gjcwebdesign.com
VM4 AusPost Shipping Plugin - e-go Shipping Plugin - VM4 Postcode Shipping Plugin - Radius Shipping Plugin - VM4 NZ Post Shipping Plugin - AusPost Estimator
Samport Payment Plugin - EcomMerchant Payment Plugin - ccBill payment Plugin
VM2 Product Lock Extension - VM2 Preconfig Adresses Extension - TaxCloud USA Taxes Plugin - Virtuemart  Product Review Component
https://extensions.joomla.org/profile/profile/details/67210
Contact for any VirtueMart or Joomla development & customisation

Topknotch

have now and still its the same, I cant work it out at all

Topknotch

Ok I have paid someone to fix this issue.
Now, as we all know overides must always be used incase of upgrading.
However, this guy has only modified the core -
component/virtuemart/sublayout/customfield.php
The adapted file can be downloaded here - https://www.dropbox.com/s/kbcdi0vz3i3cz8w/customfield.php?dl=0
Obviously I pointed out that whenever an upgrade is done it will be overwritten and he just said 'yes'
Unfortuanately I am not a PHP wiz by a long way, so if someone has a few mins to scan through the attached coding they might see what has been altered and why the problem excisted in the first place, also if possible how I can create an over ride for it.
Many many thanks


Milbo

 
Quote from: Topknotch on December 08, 2015, 20:00:44 PM
The adapted file can be downloaded here - https://www.dropbox.com/s/kbcdi0vz3i3cz8w/customfield.php?dl=0
Thank you, I take a look on what he did.

Quote from: Topknotch on December 08, 2015, 20:00:44 PM
Obviously I pointed out that whenever an upgrade is done it will be overwritten and he just said 'yes'
This is wrong, any files in the sublayouts folder are OVERRIDEABLE! http://docs.virtuemart.net/tutorials/templating-layouts/199-sublayouts.html
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

Milbo

I cannot follow this fix. When I go on your test page to http://topknotch-solutions.co.uk/testatandg/home-image/tester-with-variants-detail.html

Then I get
Uncaught ReferenceError: mobilecheck is not defined

=> when the js is broken, the whole js stops,... old js rule
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

Topknotch

Hi,
Yes that error was always there, it is quite strange as I believed it to be a JS error = vmprices.js, but the fix he provided didn't even touch that and he only altered the customfield.php , which I believe was only added in version 3.0.12 anyway ?
I have put the old customfield.php back on the test site so you can see what the error was originally doing.
Thanks

Topknotch

can you help me understand what that error means and how to fix it please?
Thanks

Milbo

" which I believe was only added in version 3.0.12 anyway ? "

it was before in the model and gives now the possibility to adjust it via override.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

Topknotch

QuoteThen I get
Uncaught ReferenceError: mobilecheck is not defined

=> when the js is broken, the whole js stops,... old js rule
It is that area i do not understand.
Thanks

GJC Web Design

not saying that is the reason .. but as soon as JS hits an error it stops.. nothing after is run

so u must eliminate all JS errors

sometimes your lucky and they occur at the end of the page render and so effect very little.. but ...
GJC Web Design
VirtueMart and Joomla Developers - php developers https://www.gjcwebdesign.com
VM4 AusPost Shipping Plugin - e-go Shipping Plugin - VM4 Postcode Shipping Plugin - Radius Shipping Plugin - VM4 NZ Post Shipping Plugin - AusPost Estimator
Samport Payment Plugin - EcomMerchant Payment Plugin - ccBill payment Plugin
VM2 Product Lock Extension - VM2 Preconfig Adresses Extension - TaxCloud USA Taxes Plugin - Virtuemart  Product Review Component
https://extensions.joomla.org/profile/profile/details/67210
Contact for any VirtueMart or Joomla development & customisation