News:

Support the VirtueMart project and become a member

Main Menu

Cache is turned off, but VM gets still cached

Started by MAD King, May 24, 2015, 00:07:54 AM

Previous topic - Next topic

MAD King

I just noticed that Joomla 3.4.1 is still caching some of VM 3.0.9 with the configuration Cache off.
Always cached is com_onepage and com_virtuemart_cats
Joomla! 4.3.4
VirtueMart 4.2.4 10922

d0ublezer0

Confirmed. Same problem with mod_virtuemart_product , for example, on product detail page.
I have Joomla cache is on, but module caching is off:


But, module still caching. As a result on all pages i see same "featured" products. When i do cache clean, module displayed new products. But, there are not changed before i go to clean cache again
Example page: http://www.zebra-tara.ru/catalogue/plastic-boxes/pb-300/400300270-02-524-detail

there is not changed when you serfing this site:

borro

I also confirm it. Dear developers please pay attention to it. Did somebody find any solutions to fix that?
Wish you happiness!

franzpeter

I can confirm that. Even if switching the cache off inside the VM category module it always creates cache entries.

Studio 42

#4
Hi,
This is the fix for correct caching:
file : JOOMLAROOT\modules\mod_virtuemart_product\mod_virtuemart_product.php
after the line 55 :
$key = 'products'.$category_id.'.'.$max_items.'.'.$filter_category.'.'.$display_style.'.'.$products_per_row.'.'.$show_price.'.'.$show_addtocart.'.'.$Product_group.'.'.$virtuemart_currency_id;

add:
if($filter_category) $key .= 'c'.vRequest::getInt('virtuemart_category_id', 0);

The current bug comes because cache key does not includes current category.

This bug should only when you use category filter.

Greets,
Patrick

P.S: THis is fix for product module.
For the categories, i have give a fix to the team, but because they don''t understand the fix, they have never added my fix(or another fix) for this problem.

MAD King

Cannot confirm this. I do not use category filter.
Joomla! 4.3.4
VirtueMart 4.2.4 10922

franzpeter

There is something inside the Joomla cache configuration called JLIB_FORM_VALUE_CACHE_vmfile what seems to be active even if not activated.

franzpeter

@studio 42: which file do you mean to add the code?

Studio 42

Quote from: MAD King on June 30, 2015, 16:50:07 PM
Cannot confirm this. I do not use category filter.
this is not the same cache.
My fix is for 'mod_product' cache, for your problem, i have reported the bug seens 1 month, but noone in the current team, tried to apply(or fix with another solution) this bug for com_virtuemart_cats

Studio 42

Sorry file is :
YOURJOOMLA\modules\mod_virtuemart_product\mod_virtuemart_product.php


Milbo

Quote from: franzpeter on June 30, 2015, 16:58:16 PM
There is something inside the Joomla cache configuration called JLIB_FORM_VALUE_CACHE_vmfile what seems to be active even if not activated.

It is just a copy of the cache "file", with 2-3 fixes in it.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

Milbo

Quote from: Studio 42 on June 30, 2015, 16:46:02 PM
P.S: THis is fix for product module.
For the categories, i have give a fix to the team, but because they don''t understand the fix, they have never added my fix(or another fix) for this problem.

I dont remind that I got a fix, or the hint that the category id is missing
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

Studio 42

#13
Hi,
i speak for com_virtuemart_cats, follow the link : https://forum.virtuemart.net/index.php?topic=129548.msg445874#msg445874
Quote from: Milbo on July 02, 2015, 15:30:30 PM
Quote from: Studio 42 on June 30, 2015, 16:46:02 PM
P.S: THis is fix for product module.
For the categories, i have give a fix to the team, but because they don''t understand the fix, they have never added my fix(or another fix) for this problem.

I dont remind that I got a fix, or the hint that the category id is missing


The problem is we're talking about two different bugs

Milbo

yes and your construction was not working. I took the hint to delete not just virtuemart_cats but also mod_virtuemart_category
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/