News:

Support the VirtueMart project and become a member

Main Menu

Currency Details - Code 2 letters

Started by Rune Rasmussen, April 22, 2015, 14:14:21 PM

Previous topic - Next topic

Rune Rasmussen

In later versions of VirtueMart there has been added a new field in "Currency Details", named "Code 2 letters".

This field is empty for all as fare as I can see, but it's REQURED to fill if you want to do any changes and save.

But what is this actually, and why is it required?

I have never seen used. or heard about, anything else than a 3 letter code (ISO 4217)...?

Not even Wikipedia refer to anything else than the 3 letter ISO 4217 code:
http://en.wikipedia.org/wiki/United_States_dollar
http://en.wikipedia.org/wiki/Euro
http://en.wikipedia.org/wiki/Norwegian_krone

???
Rune Rasmussen - https://www.syntaxerror.no/

Norwegian Translation Team

Studio 42

Hi,
If this is a blocker, then simply use the same that 3 letter code and remove the last letter.

Milbo

Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

Rune Rasmussen

#3
Yes, I did actually use the country code for it.

But what I wonder is what this actually is? What's the idea behind it, what is it used for? What ISO standard is it based on? :)
Rune Rasmussen - https://www.syntaxerror.no/

Norwegian Translation Team

Milbo

It is just the analogy to the countries.

The idea is that if people use the country_2 code, that they can directly read the corresponding currency. Integrated xref.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

Rune Rasmussen

OK, so it's based on the  "ISO 3166 two letter country code". And then the text for that field should probably be "Country Code 2 letters" instead - to avoid confusion...?
Rune Rasmussen - https://www.syntaxerror.no/

Norwegian Translation Team

Studio 42

I think is based on what you need.
Some web service for eg. service  as perhaps google product, facebook or perhaps another site only use 2 letter code, if you need to set manually the 2 letter code for you needs then simply change this, i don't think this follow iso 3166

Rune Rasmussen

#7
Huh ...? Tell me anyone using a two letter currency code... It's just a confusing abnormality in VM it seems. :)
Anyhow  the country_2 code should always be ISO 3166.
Rune Rasmussen - https://www.syntaxerror.no/

Norwegian Translation Team


Studio 42

How work currency code,
extracted from a page:
QuoteCurrency codes are composed of a country's two-character Internet country code plus a third character denoting the currency unit. For example, the Canadian Dollar code (CAD) is made up of Canada's Internet code ("CA") plus a currency designator ("D"). For a list of currency symbols like the dollar sign "$", the Pound sign "£", and the Euro sign "€", refer to our Currency Symbols page.

this mean remonving the last letter is always right.

Rune Rasmussen

#10
Always right for what? Btw! If it was always right, the setting wouldn't be needed as it could have been done automatically by the system.

Anyhow the  two-character Internet country code should always be ISO 3166, and there is no such thing as a two-character currency code. ;)
Rune Rasmussen - https://www.syntaxerror.no/

Norwegian Translation Team

Studio 42

Rune Rasmussen, i don't know why this was added ?
Certainly a paid member, because i don't have any idea why this is in the currency table.

Milbo

Rune it is just the country_2 code of the currency, or remove the last char
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

Rune Rasmussen

That's fine Max, but this is just not about me or what I should/can do with it.

I have proposed that you change the naming of the field, and I now also propose that you clarify in the help text for the field, add something about what it is - and what purpose it has.

Btw! Did you notice that you changed the wrong line, removed requirement for 3 character currency code, instead of removing it for the 2 character "thing"?

Quote from: Rune Rasmussen on April 24, 2015, 13:58:51 PM
Wrong line: http://dev.virtuemart.net/projects/virtuemart/repository/revisions/8838/diff/trunk/virtuemart/administrator/components/com_virtuemart/views/currency/tmpl/edit.php ? ;)
Rune Rasmussen - https://www.syntaxerror.no/

Norwegian Translation Team