News:

Looking for documentation? Take a look on our wiki

Main Menu

VM 3.0.10 Facebox malfunction

Started by n3t, October 03, 2015, 00:12:24 AM

Previous topic - Next topic

GJC Web Design

what if u just remove the fancybox call from

plugins\content\jw_sigpro\jw_sigpro\includes\js\jquery_fancybox\popup.php ~ line 24


/* $scripts = array(
'fancybox/lib/jquery.mousewheel-3.0.6.pack.js',
'fancybox/jquery.fancybox.js?v=2.1.5',
'fancybox/helpers/jquery.fancybox-buttons.js?v=2.1.5',
'fancybox/helpers/jquery.fancybox-thumbs.js?v=2.1.5'
);
*/
$scripts = array(
'fancybox/lib/jquery.mousewheel-3.0.6.pack.js',
'fancybox/helpers/jquery.fancybox-buttons.js?v=2.1.5',
'fancybox/helpers/jquery.fancybox-thumbs.js?v=2.1.5'
);
GJC Web Design
VirtueMart and Joomla Developers - php developers https://www.gjcwebdesign.com
VM4 AusPost Shipping Plugin - e-go Shipping Plugin - VM4 Postcode Shipping Plugin - Radius Shipping Plugin - VM4 NZ Post Shipping Plugin - AusPost Estimator
Samport Payment Plugin - EcomMerchant Payment Plugin - ccBill payment Plugin
VM2 Product Lock Extension - VM2 Preconfig Adresses Extension - TaxCloud USA Taxes Plugin - Virtuemart  Product Review Component
https://extensions.joomla.org/profile/profile/details/67210
Contact for any VirtueMart or Joomla development & customisation

wonderland


GJC Web Design

they are still both loading


maybe try loose the vm one
GJC Web Design
VirtueMart and Joomla Developers - php developers https://www.gjcwebdesign.com
VM4 AusPost Shipping Plugin - e-go Shipping Plugin - VM4 Postcode Shipping Plugin - Radius Shipping Plugin - VM4 NZ Post Shipping Plugin - AusPost Estimator
Samport Payment Plugin - EcomMerchant Payment Plugin - ccBill payment Plugin
VM2 Product Lock Extension - VM2 Preconfig Adresses Extension - TaxCloud USA Taxes Plugin - Virtuemart  Product Review Component
https://extensions.joomla.org/profile/profile/details/67210
Contact for any VirtueMart or Joomla development & customisation

wonderland

I actually did remove that piece of code, but since it didn't change anything, I put it back.

How would I best go about removing vm fancybox. In which file does call to js file is located?

GJC Web Design

administrator\components\com_virtuemart\helpers\vmjsapi.php  ~ line 426
GJC Web Design
VirtueMart and Joomla Developers - php developers https://www.gjcwebdesign.com
VM4 AusPost Shipping Plugin - e-go Shipping Plugin - VM4 Postcode Shipping Plugin - Radius Shipping Plugin - VM4 NZ Post Shipping Plugin - AusPost Estimator
Samport Payment Plugin - EcomMerchant Payment Plugin - ccBill payment Plugin
VM2 Product Lock Extension - VM2 Preconfig Adresses Extension - TaxCloud USA Taxes Plugin - Virtuemart  Product Review Component
https://extensions.joomla.org/profile/profile/details/67210
Contact for any VirtueMart or Joomla development & customisation

Milbo

Quote from: n3t on October 03, 2015, 00:12:24 AM
Solution
Change in vmprices.js this line of code

jQuery.facebox({ text: txt }, 'my-groovy-style');

to

jQuery.facebox(txt, 'my-groovy-style');


I tried that and it works. So the Facebox will be back in vm3.0.12. i had to fix also the popups loading html, but it works now.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

wonderland

Those are quite good news, thank you very much!

Milbo

Please try http://dev.virtuemart.net/attachments/download/976/com_virtuemart.3.0.11.4_extract_first.zip

But be aware, when you use for example, one time the "ask a question popup", you cannot use it again, or use the "add to cart". Your customer need to reload. I was not able to find this error, maybe someone else can fix it.

Anyway facebox is deprecated.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

luislpv22

#23
Why don't you just replace facebox with Bootstrap / Joomla modals?

Fancybox works fine but its design is not consistent, we need a good alternative.

AH

QuoteFancybox works fine but its design is not consistent, we need a good alternative.

The thread was about the removal of facebox.

Fancybox is the current popup handler.

QuoteWhy don't you just replace facebox with Bootstrap / Joomla modals?

Consider that not every person wants to load up a bootstrap framework just for a popup.
Regards
A

Joomla 3.10.11
php 8.0

luislpv22

#25
Quote from: AH on November 07, 2015, 17:59:45 PM
QuoteFancybox works fine but its design is not consistent, we need a good alternative.

The thread was about the removal of facebox.

That's what I'm talking about, if they remove facebox we'll need a new alternative for those who have problems with Fancybox.

Quote
QuoteWhy don't you just replace facebox with Bootstrap / Joomla modals?

Consider that not every person wants to load up a bootstrap framework just for a popup.

Most Joomla templates use bootstrap, and as I mentioned before it would be an alternative, if you don't use bootstrap in your site you shouldn't enable it.

Anyway I'm pretty sure there are lots of good jquery plugins out of there.

F.E: http://www.jacklmoore.com/colorbox/ used in MijoShop

https://plugins.jquery.com/tag/lightbox/