New Paybox (the new one using HMAC on VM 2.6.6) bug causing error 500

[Yann Charlou]

Hi,

Since update to 2.6.6 using the new paybox plugin included in standard VM, Paybox send me mail alerts about they found error 500 when notifying payment to my website.

I've found this in my apache logs :

Code Select Expand


[Tue Jul 15 10:36:22.081272 2014] [fcgid:warn] [pid 3631] [client XXX.XXX.XXX.XXX:XXXXX] mod_fcgid: stderr: PHP Notice:  Undefined index: option in /var/www/clients/client1/web1/web/plugins/vmpayment/paybox/paybox/helpers/paybox.php on line 725
[Tue Jul 15 10:36:22.081327 2014] [fcgid:warn] [pid 3631] [client XXX.XXX.XXX.XXX:XXXXX] mod_fcgid: stderr: PHP Notice:  Undefined index: view in /var/www/clients/client1/web1/web/plugins/vmpayment/paybox/paybox/helpers/paybox.php on line 725
[Tue Jul 15 10:36:22.081332 2014] [fcgid:warn] [pid 3631] [client XXX.XXX.XXX.XXX:XXXXX] mod_fcgid: stderr: PHP Notice:  Undefined index: task in /var/www/clients/client1/web1/web/plugins/vmpayment/paybox/paybox/helpers/paybox.php on line 725
[Tue Jul 15 10:36:22.081337 2014] [fcgid:warn] [pid 3631] [client XXX.XXX.XXX.XXX:XXXXX] mod_fcgid: stderr: PHP Notice:  Undefined index: pm in /var/www/clients/client1/web1/web/plugins/vmpayment/paybox/paybox/helpers/paybox.php on line 725
[Tue Jul 15 10:36:22.081341 2014] [fcgid:warn] [pid 3631] [client XXX.XXX.XXX.XXX:XXXXX] mod_fcgid: stderr: PHP Notice:  Undefined index: lang in /var/www/clients/client1/web1/web/plugins/vmpayment/paybox/paybox/helpers/paybox.php on line 725
[Tue Jul 15 10:36:22.081346 2014] [fcgid:warn] [pid 3631] [client XXX.XXX.XXX.XXX:XXXXX] mod_fcgid: stderr: PHP Notice:  Undefined index: Itemid in /var/www/clients/client1/web1/web/plugins/vmpayment/paybox/paybox/helpers/paybox.php on line 725
[Tue Jul 15 10:36:22.081350 2014] [fcgid:warn] [pid 3631] [client XXX.XXX.XXX.XXX:XXXXX] mod_fcgid: stderr: PHP Fatal error:  Call to undefined method PayboxHelperPaybox::emptyCart() in /var/www/clients/client1/web1/web/plugins/vmpayment/paybox/paybox/helpers/paybox.php on line 276


Taking a look into in the file plugins/vmpayment/paybox/paybox/helpers/paybox.php on line 276 I found this :

Code Select Expand


if (!empty($payments[0]->paybox_custom)) {
$this->emptyCart($payments[0]->paybox_custom, $order['details']['BT']->order_number);
$this->setEmptyCartDone($payments[0]);
}


emptyCart method and setEmptyCartDone doesn't exists in the current class !!! (and this class doesn't extend any parent)

setEmptyCartDone exists only in another file having the same name : plugins/vmpayment/paybox/paybox.php .
Is there some mistake somewhere ?
Can I simply comment out this lines ? (not emptying cart seems not to be too dangerous)
Any idea about how to correct this ?

Sorry for my bad english, I'm French. ;-)

Thank you in advance for any help.

Best regards,
Yann