Author Topic: Language strings missing in vendor confirmation mail  (Read 2309 times)

zanardi

  • Contributing Developer
  • Full Member
  • *
  • Posts: 878
    • GiBiLogic
Language strings missing in vendor confirmation mail
« on: May 04, 2014, 15:48:18 pm »
While testing the mail confirmation on different order status I have incidentally found a possible language strings error.

Steps to reproduce:
* fresh install of J2.5.19 and VM2.6.0
* create a new "VMpayment - standard" payment method called "Bank transfer"
* configure this payment method so that it puts the order in "Pending" status instead of "Confirmed by shopper"
* complete a frontend order: correctly, no mail are sent to SHOPPER or VENDOR
* from backend, change manually the order status to "Confirmed"

Mail are correctly sent to SHOPPER and VENDOR, but the vendor message has two language errors:
* the subject is "COM_VIRTUEMART_MAIL_SUBJ_VENDOR_C"
* the first line of the content is "COM_VIRTUEMART_MAIL_VENDOR_CONTENT"

Hope you are able to reproduce and fix. Thanks!
--
Francesco (zanardi)
http://extensions.gibilogic.com
@gibilogic on Twitter

betterlead

  • Jr. Member
  • **
  • Posts: 167
    • LIVING STUDIO
  • VirtueMart Version: 3.2.12
Re: Language strings missing in vendor confirmation mail
« Reply #1 on: February 17, 2015, 11:30:12 am »
Hi

Did you ever find the solution to this problem? I still haven't figured out how.
COM_VIRTUEMART_MAIL_SUBJ_SHOPPER_Z (Might be other than _Z, of course, but that is the one that shows up in the Subject of the confirmation E-mails to the customers for a specific payment method - well it happens to be PayPal.)

I have tried to fix it in the language override manager, but it doesn't do the trick.

Cheers

SOLVED! But read instructions carefully, by Hutson (Scroll down). Read first post on the second page of this thread, if you want to know how I emarressed myself...
Live site runs on Joomla 3.8.13 & VM 3.2.12

PHP: 7.0.22

AH

  • Global Moderator
  • Sr. Member
  • *
  • Posts: 2915
  • VirtueMart Version: 3.6.0
Re: Language strings missing in vendor confirmation mail
« Reply #2 on: February 17, 2015, 12:33:09 pm »
This can and will occur if you have introduced a new order status

You will need to add the new language variables fro the new status codes manually in the frontend and backend language overrides

language\overrides\en-GB.override.ini
AND
administrator\language\overrides\en-GB.override.ini

Code: [Select]
COM_VIRTUEMART_MAIL_SUBJ_SHOPPER_Z="YOUR TEXT"
COM_VIRTUEMART_MAIL_SUBJ_VENDOR_Z="YOUR TEXT"

Note that the %1s and %2s contain details of order information if you want to include them

e.g.
COM_VIRTUEMART_MAIL_SUBJ_SHOPPER_C="[%3$s], Confirmed order at %1$s, total %2$s"
regards
A

Joomla 3.9.8
php 7.1

betterlead

  • Jr. Member
  • **
  • Posts: 167
    • LIVING STUDIO
  • VirtueMart Version: 3.2.12
Re: Language strings missing in vendor confirmation mail
« Reply #3 on: February 17, 2015, 12:57:55 pm »
Aah! So I need to copy and paste the variable and the value from
language\overrides\en-GB.override.ini to here:
administrator\language\overrides\en-GB.override.ini

???

Note: I already made the value in the override manager and copied the value from the standard statuses. Never new I needed to fix this also in the admin part.

Have I got it right, Hutson?

Many thanks. I think this is a very important information to many more who still struggles with this.
Live site runs on Joomla 3.8.13 & VM 3.2.12

PHP: 7.0.22

AH

  • Global Moderator
  • Sr. Member
  • *
  • Posts: 2915
  • VirtueMart Version: 3.6.0
Re: Language strings missing in vendor confirmation mail
« Reply #4 on: February 17, 2015, 13:01:48 pm »
Yes that is correct - make sure the language variable is available in both admin and frontend overrides file

language\overrides\en-GB.override.ini
AND
administrator\language\overrides\en-GB.override.ini
regards
A

Joomla 3.9.8
php 7.1

betterlead

  • Jr. Member
  • **
  • Posts: 167
    • LIVING STUDIO
  • VirtueMart Version: 3.2.12
Re: Language strings missing in vendor confirmation mail
« Reply #5 on: February 17, 2015, 13:06:03 pm »
Super! Many thanks again.
Live site runs on Joomla 3.8.13 & VM 3.2.12

PHP: 7.0.22

betterlead

  • Jr. Member
  • **
  • Posts: 167
    • LIVING STUDIO
  • VirtueMart Version: 3.2.12
Re: Language strings missing in vendor confirmation mail
« Reply #6 on: February 28, 2015, 21:08:16 pm »
Sorry, but this didn't solve the problem. Still the same in the subject line. :(

I suppose it doesn't make any difference if I use these override files, since my language is Swedish: sv-SE.override.ini
Live site runs on Joomla 3.8.13 & VM 3.2.12

PHP: 7.0.22

Milbo

  • Virtuemart Projectleader
  • Administrator
  • Super Hero
  • *
  • Posts: 9853
  • VM3.2 Cached and Optimized
    • VM3 Extensions
  • VirtueMart Version: VirtueMart 3 on joomla 3
Re: Language strings missing in vendor confirmation mail
« Reply #7 on: March 01, 2015, 10:49:49 am »
Then you must of course use the override for Sv. You can also do that in joomla itself, with GUI and all that.
I should fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

betterlead

  • Jr. Member
  • **
  • Posts: 167
    • LIVING STUDIO
  • VirtueMart Version: 3.2.12
Re: Language strings missing in vendor confirmation mail
« Reply #8 on: March 01, 2015, 14:02:20 pm »
Of course I used the SV -override file. Just received another subject like this, in confirmation mail with a Paypal payment... Doh!
Live site runs on Joomla 3.8.13 & VM 3.2.12

PHP: 7.0.22

betterlead

  • Jr. Member
  • **
  • Posts: 167
    • LIVING STUDIO
  • VirtueMart Version: 3.2.12
Re: Language strings missing in vendor confirmation mail
« Reply #9 on: March 01, 2015, 14:07:57 pm »
Screen shot of today's confirmation mail with a Paypal payment. There must be some kind of bug,,, or?
Live site runs on Joomla 3.8.13 & VM 3.2.12

PHP: 7.0.22

betterlead

  • Jr. Member
  • **
  • Posts: 167
    • LIVING STUDIO
  • VirtueMart Version: 3.2.12
Re: Language strings missing in vendor confirmation mail
« Reply #10 on: March 01, 2015, 14:14:56 pm »
And here is the screen shot from the Language manager. I have as instructed above by Hutson, even added the string and value in the backend language file - also the SV-SE.
Live site runs on Joomla 3.8.13 & VM 3.2.12

PHP: 7.0.22

betterlead

  • Jr. Member
  • **
  • Posts: 167
    • LIVING STUDIO
  • VirtueMart Version: 3.2.12
Re: Language strings missing in vendor confirmation mail
« Reply #11 on: March 01, 2015, 14:23:22 pm »
Does it look ok?
I can also add, when I make a refund all is ok. Subject is as it should. String and value looks like this:                         
 COM_VIRTUEMART_MAIL_SUBJ_VENDOR_R
[%3$s], Återbetalning beställning %1$s, totalt %2$s
Live site runs on Joomla 3.8.13 & VM 3.2.12

PHP: 7.0.22

Milbo

  • Virtuemart Projectleader
  • Administrator
  • Super Hero
  • *
  • Posts: 9853
  • VM3.2 Cached and Optimized
    • VM3 Extensions
  • VirtueMart Version: VirtueMart 3 on joomla 3
Re: Language strings missing in vendor confirmation mail
« Reply #12 on: March 02, 2015, 09:36:52 am »
What happens when you add the language to your original files?
I should fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

betterlead

  • Jr. Member
  • **
  • Posts: 167
    • LIVING STUDIO
  • VirtueMart Version: 3.2.12
Re: Language strings missing in vendor confirmation mail
« Reply #13 on: March 02, 2015, 09:43:33 am »
Thought about that. Good. I'll do it and then we'll see... (If I got it right: Add the value and the string to the EN files in both backend and frontend? Hmm?)
Live site runs on Joomla 3.8.13 & VM 3.2.12

PHP: 7.0.22

Milbo

  • Virtuemart Projectleader
  • Administrator
  • Super Hero
  • *
  • Posts: 9853
  • VM3.2 Cached and Optimized
    • VM3 Extensions
  • VirtueMart Version: VirtueMart 3 on joomla 3
Re: Language strings missing in vendor confirmation mail
« Reply #14 on: March 02, 2015, 10:38:54 am »
yeh EN, SV, for all languages you are using.
I should fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/