Author Topic: VM2 allows checkout of out of stock products  (Read 10446 times)

GJC Web Design

  • 3rd party VirtueMart Developer
  • Super Hero
  • *
  • Posts: 9230
  • Virtuemart, Joomla & php developer
    • GJC Web Design
  • VirtueMart Version: 3.6.8
Re: VM2 allows checkout of out of stock products
« Reply #15 on: May 13, 2014, 10:51:56 am »
Checked this in 2.6.0a -

Make a product with stock level 1
Action when a Product is Out of Stock - Do not display Product
Open two browsers
You can add the product to both carts simultaneosly.... i.e. add to one - then the other -- there is no check on whether the product has been added to a cart and no limit to the number of visitors to do this..
Then it is a race to the line

When one is checked out the others fail on Product out of Stock.. so this is fixed in 2.6.0a - in previous versions you could also happily checkout as many as had them in their carts

This I guess is fine for shops where stock runs out but hardly ideal for shops selling one off products..
Especially as a couple of my clients run their shops as a time limited selling .. i.e. the shop only opens at a specified time till that batch of products are sold

hence http://forum.virtuemart.net/index.php?topic=119859.0

GJC Web Design
VirtueMart and Joomla Developers - php developers http://www.gjcwebdesign.com
VM3 AusPost Shipping Plugin - e-go Shipping Plugin - VM3 Postcode Shipping Plugin - Radius Shipping Plugin - VM3 NZ Post Shipping Plugin - AusPost Estimator
Samport Payment Plugin - EcomMerchant Payment Plugin - ccBill payment Plugin
VM2 Product Lock Extension - VM2 Preconfig Adresses Extension - TaxCloud USA Taxes Plugin - Virtuemart  Product Review Component
http://extensions.joomla.org/profile/profile/details/67210
Contact for any VirtueMart or Joomla development & customisation

bunglehaze

  • Jr. Member
  • **
  • Posts: 487
Re: VM2 allows checkout of out of stock products
« Reply #16 on: May 14, 2014, 22:52:14 pm »
It is not fixed for me in 2.6.0a - I am getting people are able to add low stock items to the cart beyond the in stock values.

GJC Web Design

  • 3rd party VirtueMart Developer
  • Super Hero
  • *
  • Posts: 9230
  • Virtuemart, Joomla & php developer
    • GJC Web Design
  • VirtueMart Version: 3.6.8
Re: VM2 allows checkout of out of stock products
« Reply #17 on: May 15, 2014, 00:01:14 am »
just checked on clean 2.6.0a
stock 3

can add up to 3 in cart
4th gives  ->  Product out of stock Nice Saw

2 browsers - each can add 3 - but if one checks out 2nd can not -> Product out of stock Nice Saw

Are you sure you have: Product is Out of Stock - Do not display Product ?
GJC Web Design
VirtueMart and Joomla Developers - php developers http://www.gjcwebdesign.com
VM3 AusPost Shipping Plugin - e-go Shipping Plugin - VM3 Postcode Shipping Plugin - Radius Shipping Plugin - VM3 NZ Post Shipping Plugin - AusPost Estimator
Samport Payment Plugin - EcomMerchant Payment Plugin - ccBill payment Plugin
VM2 Product Lock Extension - VM2 Preconfig Adresses Extension - TaxCloud USA Taxes Plugin - Virtuemart  Product Review Component
http://extensions.joomla.org/profile/profile/details/67210
Contact for any VirtueMart or Joomla development & customisation

bunglehaze

  • Jr. Member
  • **
  • Posts: 487
Re: VM2 allows checkout of out of stock products
« Reply #18 on: May 15, 2014, 13:03:45 pm »
My site is exactly setup as it has since the first version of VM 2.x so the do not display product setting is correct - another issue I have also found is that since upgrading to 2.6.0a all of my parent items in one category had their stock values reset to zero. The child products within had the correct stock levels but due to the parent showing as zero stock it was causing problems ordering.

Personally I would like to see a checkbox of some form or intelligent configuration that can specify that a parent child can be ignored for stock control - in my case and I suspect many others, the parent item is only used to contain the child products so there is no need to check the stock in this regard.

GJC Web Design

  • 3rd party VirtueMart Developer
  • Super Hero
  • *
  • Posts: 9230
  • Virtuemart, Joomla & php developer
    • GJC Web Design
  • VirtueMart Version: 3.6.8
Re: VM2 allows checkout of out of stock products
« Reply #19 on: May 15, 2014, 13:20:26 pm »
Quote
Personally I would like to see a checkbox of some form or intelligent configuration that can specify that a parent child can be ignored for stock control - in my case and I suspect many others, the parent item is only used to contain the child products so there is no need to check the stock in this regard.

Agree fully with this - have only ever used parents as holders for children if I use Parent-child relations
GJC Web Design
VirtueMart and Joomla Developers - php developers http://www.gjcwebdesign.com
VM3 AusPost Shipping Plugin - e-go Shipping Plugin - VM3 Postcode Shipping Plugin - Radius Shipping Plugin - VM3 NZ Post Shipping Plugin - AusPost Estimator
Samport Payment Plugin - EcomMerchant Payment Plugin - ccBill payment Plugin
VM2 Product Lock Extension - VM2 Preconfig Adresses Extension - TaxCloud USA Taxes Plugin - Virtuemart  Product Review Component
http://extensions.joomla.org/profile/profile/details/67210
Contact for any VirtueMart or Joomla development & customisation

Milbo

  • Virtuemart Projectleader
  • Administrator
  • Super Hero
  • *
  • Posts: 9997
  • VM3.2 Cached and Optimized
    • VM3 Extensions
  • VirtueMart Version: VirtueMart 3 on joomla 3
Re: VM2 allows checkout of out of stock products
« Reply #20 on: May 16, 2014, 21:45:41 pm »
There is an option for that
I should fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

GJC Web Design

  • 3rd party VirtueMart Developer
  • Super Hero
  • *
  • Posts: 9230
  • Virtuemart, Joomla & php developer
    • GJC Web Design
  • VirtueMart Version: 3.6.8
Re: VM2 allows checkout of out of stock products
« Reply #21 on: May 16, 2014, 22:11:23 pm »
See - we never investigate properly...  ;)   :D
GJC Web Design
VirtueMart and Joomla Developers - php developers http://www.gjcwebdesign.com
VM3 AusPost Shipping Plugin - e-go Shipping Plugin - VM3 Postcode Shipping Plugin - Radius Shipping Plugin - VM3 NZ Post Shipping Plugin - AusPost Estimator
Samport Payment Plugin - EcomMerchant Payment Plugin - ccBill payment Plugin
VM2 Product Lock Extension - VM2 Preconfig Adresses Extension - TaxCloud USA Taxes Plugin - Virtuemart  Product Review Component
http://extensions.joomla.org/profile/profile/details/67210
Contact for any VirtueMart or Joomla development & customisation

bunglehaze

  • Jr. Member
  • **
  • Posts: 487
Re: VM2 allows checkout of out of stock products
« Reply #22 on: May 17, 2014, 00:05:51 am »
Milbo, where is that as I have never seen one?

Milbo

  • Virtuemart Projectleader
  • Administrator
  • Super Hero
  • *
  • Posts: 9997
  • VM3.2 Cached and Optimized
    • VM3 Extensions
  • VirtueMart Version: VirtueMart 3 on joomla 3
Re: VM2 allows checkout of out of stock products
« Reply #23 on: May 17, 2014, 11:10:46 am »
VmConfig => Tab shopfront => inventory => "Do not Display Product, if child products also out of stock"

This should show a parent product with stock 0, IF one of the childs has a positive stock.
I should fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

bunglehaze

  • Jr. Member
  • **
  • Posts: 487
Re: VM2 allows checkout of out of stock products
« Reply #24 on: May 18, 2014, 00:42:27 am »
That does not work for me Milbo, parent products have to have a stock of 1 or more for the child to display. I am using the stockable plugin for child products though (if that makes a difference) as the other way to display child products needs a page load for each option and is just frustrating (and can be slow)

bunglehaze

  • Jr. Member
  • **
  • Posts: 487
Re: VM2 allows checkout of out of stock products
« Reply #25 on: May 19, 2014, 15:56:40 pm »
I just tested the setting again Milbo, the product does display corrently but if the parent stock is 0 you cannot order any of the child products - you get a product out of stock message when adding to cart. If just 1 item is added to the parent stock, the customer cannot add more than 1 item to their cart either as they get the same error which means that all parent items need to have multiples set at their stock (I choose 50 for this reason) in order for 5,10, 20 items in the child products to be orderable

bunglehaze

  • Jr. Member
  • **
  • Posts: 487
Re: VM2 allows checkout of out of stock products
« Reply #26 on: May 20, 2014, 14:39:37 pm »
To update this thread again. I had 1 product in stock in a certain size yesterday (child product), a customer has managed again to purchase 2 of this child product somehow.

I have also had an order this morning of a product that was out of stock (I know it was out of stock as I manually adjusted it again yesterday). If the parent product was working with stock @0 then the child products would not even show as in stock, that said though there should be no way to order a child product with stock 0 and I am confused how this keeps happening.

vaistik

  • Beginner
  • *
  • Posts: 14
Re: VM2 allows checkout of out of stock products
« Reply #27 on: June 04, 2014, 14:43:46 pm »
I'm having similar issues running on an older version (2.0.10).

Of course I can't expect a fix for this but could you give me any pointers as to where I should look if I wanna add a small booked/stock check when the user checks out? This is the way we want to go and do the check at checkout while allowing multiple users to have the same product in their carts, thus the aforementioned plugin won't work for us.

I've been looking around the cart model/helper, checking the dataValidated vars etc but as far as I can tell there is not a single check for product status after it's in the cart.

Any pointers to functions/files would be greatly appreciated.

GJC Web Design

  • 3rd party VirtueMart Developer
  • Super Hero
  • *
  • Posts: 9230
  • Virtuemart, Joomla & php developer
    • GJC Web Design
  • VirtueMart Version: 3.6.8
Re: VM2 allows checkout of out of stock products
« Reply #28 on: June 04, 2014, 16:42:43 pm »
Quote
I've been looking around the cart model/helper, checking the dataValidated vars etc but as far as I can tell there is not a single check for product status after it's in the cart.

correct in the VM version you mention  - this is why I went with my system - to attach a flag as soon as it enters a cart.

Haven't checked the VM2.6.x series...

If you want to check it at Confirm purchase your going to have to write your own check in the cart system.
GJC Web Design
VirtueMart and Joomla Developers - php developers http://www.gjcwebdesign.com
VM3 AusPost Shipping Plugin - e-go Shipping Plugin - VM3 Postcode Shipping Plugin - Radius Shipping Plugin - VM3 NZ Post Shipping Plugin - AusPost Estimator
Samport Payment Plugin - EcomMerchant Payment Plugin - ccBill payment Plugin
VM2 Product Lock Extension - VM2 Preconfig Adresses Extension - TaxCloud USA Taxes Plugin - Virtuemart  Product Review Component
http://extensions.joomla.org/profile/profile/details/67210
Contact for any VirtueMart or Joomla development & customisation

bunglehaze

  • Jr. Member
  • **
  • Posts: 487
Re: VM2 allows checkout of out of stock products
« Reply #29 on: June 04, 2014, 22:49:49 pm »
As it happens I set tonight to one side to try and test if the parent product stock@zero and child products all carrying stock worked as Milbo mentioned before and can confirm again that even on standard Virtuemart (no overrrides) and basic Joomla atomic template I get an out of stock warning when trying to add child products that are in stock.

To clarify the situation:

Parent Item  = stock of zero
Child Item 1 = stock of 10
Child item 2 = stock of 5

I go to the parent and select the child from the dropdown, click add to cart and get 'product out of stock'. Same situation happens on any child product selected.

If this is the intended functionality of the parent/child relationship and having the do not show parent while child products out of stock option being selected it would appear that this is not working.

How we have been working around this based on what I read  on this forum is that shop owners have to have the parent item as always carrying stock, this is counterproductive as it means other addons that look to remove out of stock items will always display the parent even when child items are all out of stock.

Any idea how to fix this or where to even begin? I would understand if this was happening using overrides but certainly not on a basic VM2 install and native Joomla template

Ignore the above - fix was found today that I can confirm works:
http://www.rupostel.com/phpBB3/viewtopic.php?f=5&t=937&sid=1b5d2e395866210264df3bf3f077ebbc