Text only | Text with Images

VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Topic started by: cas on October 19, 2011, 23:32:38 PM

Title: Media File editor removes the Role (File Type) from the database
Post by: cas on October 19, 2011, 23:32:38 PM
When using the Media File editor, the Role (File Type in database) does not save in the database.   When changing any media field values (Displayed title, Displayed description, Role, etc), the Role (File Type) gets removed.   
Title: Re: Media File editor removes the Role (File Type) from the database
Post by: cas on October 21, 2011, 20:00:15 PM
I updated to version J, and this problem is still occurring
Title: Re: Media File editor removes the Role (File Type) from the database
Post by: cas on October 28, 2011, 23:29:30 PM
I updated to version K, and this problem is still occurring.   Any estimate how soon this will be fixed?  I have a lot of custom field images to enter. 

Thanks,
Chuck
Title: Re: Media File editor removes the Role (File Type) from the database
Post by: Milbo on October 28, 2011, 23:44:47 PM
Thanks, just missed this bug.
Title: Re: Media File editor removes the Role (File Type) from the database
Post by: cas on October 29, 2011, 00:33:11 AM
Thanks Milbo.   Any idea on the timing for a fix?   I'm trying to plan my product loading schedule. 
Title: Re: Media File editor removes the Role (File Type) from the database
Post by: Milbo on November 01, 2011, 14:55:01 PM
Should be fixed now
Title: Re: Media File editor removes the Role (File Type) from the database
Post by: cas on November 01, 2011, 19:19:13 PM
Thanks Milbo!  I'll check it out when version L comes out. 
Title: Re: Media File editor removes the Role (File Type) from the database
Post by: cas on November 09, 2011, 04:36:17 AM
I checked it with version M.  It saves the the Role (File Type in database) so that's fixed, but now it changes the Displayed Title when another image has the same Display Title.  It appends '_product' to the end of the Displayed Title.  Does Displayed Title need to be unique across all the images?  Also, Displayed Title is not displayed on the website for images... it displays Displayed Description.  What is Displayed Title used for?
Title: Re: Media File editor removes the Role (File Type) from the database
Post by: Milbo on November 09, 2011, 12:45:40 PM
The displayed title must be unique and is the title which you use to choose a media in the BE. The displayed description is for the user. But we should rename it to title, because it is not "displayed".
Title: Re: Media File editor removes the Role (File Type) from the database
Post by: cas on November 09, 2011, 18:44:36 PM
Thanks Milbo.  Now it all makes sense how it should work.   And I agree with your that Displayed Title should be renamed to Title to clear up the confusion. 

Thanks for all your help!
Chuck
Title: Re: Media File editor removes the Role (File Type) from the database
Post by: jjk on November 09, 2011, 21:16:14 PM
I just had a look at the strings again after some time and my suggestion would be to rename strings as follows:

Change "Displayed Title" to "Unique Filename" or "Unique File Title" in order to avoid confusion with the "Title" meta tag (personally I would prefer "Unique Filename").
Change "Displayed Description" to "Displayed Image Title" (as it shows up in the page source code as an image "Title" tag.
Change "Meta Tags" to "Image Alt-Text"
Title: Re: Media File editor removes the Role (File Type) from the database
Post by: Milbo on November 10, 2011, 03:23:11 AM
done
Title: Re: Media File editor removes the Role (File Type) from the database
Post by: cas on November 10, 2011, 04:59:51 AM
Hi Milbo,

Thanks for making it less confusing.   I'm not sure which name you decided to use for the 'Displayed Title', but could I suggest not using the word 'Filename' in the name because 'Filename' represents to most people the physical filename stored on disk.  I would suggest using the name 'Unique Image Name' so it does not get confused with the actual filename on disk.     

Thanks,
Chuck 
Title: Re: Media File editor removes the Role (File Type) from the database
Post by: jjk on November 10, 2011, 09:43:18 AM
Quote from: cas on November 10, 2011, 04:59:51 AM
... I would suggest using the name 'Unique Image Name' so it does not get confused with the actual filename on disk...
Hi Chuck,

Whatever you prefer, you can easily change the text string in the file ...\administrator\language\en-GB\en-GB.com_virtuemart.ini, or even better copy the line COM_VIRTUEMART_FILES_FORM_FILE_TITLE="Displayed title " into ...\administrator\language\overrides\en-GB.override.ini (so it doesn't become overwritten when you update to a new version) and change it to COM_VIRTUEMART_FILES_FORM_FILE_TITLE="Unique Image Name "
Title: Re: Media File editor removes the Role (File Type) from the database
Post by: cas on November 10, 2011, 10:18:51 AM
Thanks jjk,

I know I can change it for me, but my recommendation to Milbo was really intended to help everyone else going forward.  Using the word filename will be confusing for others.  I hope there is time to make the change to the base.

Thanks again,
Chuck
Text only | Text with Images