VirtueMart Forum

VirtueMart Dev/Coding Central: VM1 (old version) => Virtuemart 1.1 Development (Archiv) => Quality & Testing VirtueMart 1.1.x => Topic started by: DDPaul on July 12, 2008, 02:26:29 am

Title: JSCook bug and partial fix
Post by: DDPaul on July 12, 2008, 02:26:29 am
Found a bug in root/modules/mod_virtuemart/vm__JSCook.php at about line 80. The line currently is

$mymenu_content.= "\n['<img src=\"$mosConfig_live_site/components/com_virtuemart/js/ThemeXP/darrow.png\">','".$db->f("category_name",false)."','".sefRelToAbs('index.php?option=com_virtuemart&page=shop.browse&category_id='.$db->f("category_id").$itemid)."',null,'".$db->f("category_name",false)."'\n ";

and it should be

$mymenu_content.= "\n['<img src=\"$mosConfig_live_site/modules/mod_virtuemart/ThemeXP/darrow.png\">','".$db->f("category_name",false)."','".sefRelToAbs('index.php?option=com_virtuemart&page=shop.browse&category_id='.$db->f("category_id").$itemid)."',null,'".$db->f("category_name",false)."'\n ";

Alternately you could add the ThemeXP folder to the js folder. As it stands now the image path points to a  non-existent image.

The JSCook menu still doesn't work right but IE7 no longer display that annoying non-image image.

   DDPaul

I believe after further testing that the above modification completely fixes the problem.
Title: Re: JSCook bug and partial fix
Post by: aravot on July 12, 2008, 07:11:20 am
When reporting bug please specify what the bug is, if the bug is missing arrow images than it has been fixed in v1.1.2
Title: Re: JSCook bug and partial fix
Post by: jirwan on August 26, 2008, 06:41:53 am
Good thing I found out this post. I posted on another thread:

http://forum.virtuemart.net/index.php?topic=44252.0

By changing:

$mymenu_content.= "\n[ '<img src=\"' + ctThemeXPBase + 'darrow.png\" alt=\"arr\" />','".$db->f("category_name",false)."','".sefRelToAbs('index.php?option=com_virtuemart&page=shop.browse&category_id='.$db->f("category_id").$itemid)."',null,'".$db->f("category_name",false)."'\n ";

TO:

         $mymenu_content.= "\n[ '<img src=\"$mosConfig_live_site/components/com_virtuemart/js/ThemeXP/darrow.png\" alt=\"arr\" />','".$db->f("category_name",false)."','".sefRelToAbs('index.php?option=com_virtuemart&page=shop.browse&category_id='.$db->f("category_id").$itemid)."',null,'".$db->f("category_name",false)."'\n ";

fixes the "arr" problem. Hope this helps


Title: Re: JSCook bug and partial fix
Post by: LuckyTom on September 01, 2008, 23:54:41 pm
I use VM 1.1.2
The problem exists only when SEO is activated...

I solved the problem with the following replacement in line 99

Original:
   $js_src = 'modules/mod_virtuemart';

My Changes:
   $js_src = '/modules/mod_virtuemart';

Hope this helps :-)
Title: Re: JSCook bug and partial fix
Post by: mulito on November 12, 2008, 22:26:55 pm
Hey,
I have tryed these two solutions and they worked partially.
Still in IE7 its showing an X on the right side of the subcategory menu item.
Anyone ?

Regards,
Manolo
Title: Re: JSCook bug and partial fix
Post by: rrommel on January 11, 2009, 00:55:31 am
I use VM 1.1.2
The problem exists only when SEO is activated...
I solved the problem with the following replacement in line 99
Original:
$js_src = 'modules/mod_virtuemart';
My Changes:
$js_src = '/modules/mod_virtuemart';
Hope this helps :-)

This solved my mising arrow but as Mulito I also got a trailing "x" (missing image??!) in rightside of submenu when using IE.

Has anyone solved this?

--------------------
I have found the source of the "X" in IE. This is cause by a missing "blank.png" because the base directory is incorrect. I hav solved this problem by modifying the theme.js in: \includes\js\ThemeOffice

Change the second line as follows:

original:
// directory of where all the images are
var cmThemeOfficeBase = 'includes/js/ThemeOffice/';

to

// directory of where all the images are
var cmThemeOfficeBase = '/includes/js/ThemeOffice/';


(yes, I mean theme.js not theme.css)
Title: Re: JSCook bug and partial fix
Post by: cinos on January 15, 2009, 17:47:57 pm
I think rrommel meant theme.js  8)
Title: Re: JSCook bug and partial fix
Post by: herbcap on January 27, 2009, 23:53:12 pm
I have got joomla 1.5.9 and vm 1.13

The solutions don't work for me. Anybody with a suggestion?
Title: Re: JSCook bug and partial fix
Post by: rrommel on January 28, 2009, 09:28:17 am
In configuration.php (jl 1.5.9) change:

var $live_site = 'http://www.yourdomain.xx';

to

$ var live_site = 'http://www.yourdomain.xx/';

It's working for me after upgrade to 1.5.9
Title: Re: JSCook bug and partial fix
Post by: herbcap on January 28, 2009, 10:40:44 am
I found a simple solution:

hack modules/mod_virtuemart/vm_JSCook.php

replace
80: '<img src=\"' + ctThemeXPBase + 'darrow.png\" alt=\"arr\" />'

with
80: '<img src=\"modules/mod_virtuemart/ThemeXP/darrow.png\" alt=\"arr\" />'

does the job for me.
Title: Re: JSCook bug and partial fix
Post by: mtvsound on February 17, 2009, 12:17:03 pm
great worked perfect :)
Title: Re: JSCook bug and partial fix
Post by: aomegax on October 13, 2009, 13:54:08 pm
Hi...all these don't work for me...
this is my site. (http://www.privatesys.com/index.php?option=com_virtuemart&Itemid=148)

thanks
Title: Re: JSCook bug and partial fix
Post by: dorriGa on January 27, 2010, 22:10:12 pm
--->    /includes/js/ThemeOffice/';  work for me


work in IE and Chrome also I get a JSCook compatible with SEO.
Title: Re: JSCook bug and partial fix
Post by: ruben-sp on April 12, 2010, 01:22:24 am
I found a simple solution:

hack modules/mod_virtuemart/vm_JSCook.php

replace
80: '<img src=\"' + ctThemeXPBase + 'darrow.png\" alt=\"arr\" />'

with
80: '<img src=\"modules/mod_virtuemart/ThemeXP/darrow.png\" alt=\"arr\" />'

does the job for me.

This one works great for me!!

THANKS!!!
Title: Re: JSCook bug and partial fix
Post by: frankie n on April 25, 2010, 20:08:08 pm
i tried all these methods and still got the red x to the right so went into includes/js/ThemeOffice/theme.js and changed line 34 from

// 3, HTML code to the right of the regular item
   itemRight: '<img alt="" src="' + cmThemeOfficeBase + 'blank.png">',

to

// 3, HTML code to the right of the regular item
   itemRight: '&nbsp;',

this took away the blank image
Title: Re: JSCook bug and partial fix
Post by: ruben-sp on November 21, 2010, 22:57:24 pm
I found a simple solution:

hack modules/mod_virtuemart/vm_JSCook.php

replace
80: '<img src=\"' + ctThemeXPBase + 'darrow.png\" alt=\"arr\" />'

with
80: '<img src=\"modules/mod_virtuemart/ThemeXP/darrow.png\" alt=\"arr\" />'

does the job for me.

This one works great for me!!

THANKS!!!

checking my site with page speed i just realized that image size is not set, so to improve SEO i just make this small modification in line 80

         $mymenu_content.= "\n[ '<img src=\"modules/mod_virtuemart/ThemeXP/darrow.png\" width=14px height=14px alt=\"arr\" />','".$db->f("category_name",false)."','".sefRelToAbs('index.php?option=com_virtuemart&page=shop.browse&category_id='.$db->f("category_id").$itemid)."',null,'".$db->f("category_name",false)."'\n ";