VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Topic started by: scriner on March 16, 2023, 10:56:59 AM

Title: Continue of discuss about /results,1-0 and ?clearCart=0 problem in category URL
Post by: scriner on March 16, 2023, 10:56:59 AM
Hello,

I can't answer to https://forum.virtuemart.net/index.php?topic=149553.msg534087#msg534087 (https://forum.virtuemart.net/index.php?topic=149553.msg534087#msg534087) and have to start new topic.

I tried to use instructions described in topic above but still have /results,1-0 tail in every category URL and ?clearCart=0 sometimes.

Dear Milbo, maybe you can update package here http://dev.virtuemart.net/projects/virtuemart/files (http://dev.virtuemart.net/projects/virtuemart/files) for everyone can download fixed version?

And review again topic https://forum.virtuemart.net/index.php?topic=148713.0 (https://forum.virtuemart.net/index.php?topic=148713.0). May be this problem have same routing roots.

J 4.2.9 / VM 4.0.12 10777
Title: Re: Continue of discuss about /results,1-0 and ?clearCart=0 problem in category URL
Post by: jenkinhill on March 16, 2023, 15:41:48 PM
You can get the revised router.php from the SVN repository:  http://dev.virtuemart.net/projects/virtuemart/repository/revisions/10796
Title: Re: Continue of discuss about /results,1-0 and ?clearCart=0 problem in category URL
Post by: scriner on March 17, 2023, 08:10:33 AM
Big thanks @Jenkinhill, this version of router really great for solve problem with /results,1-0

may be you can help me to solve other problem with ?clearCart=0 ?

I have two absolutely similar categories, first have url:

index.php?option=com_virtuemart&view=category&virtuemart_category_id=1&virtuemart_manufacturer_id=0
and sef is site.com/category-one

second is:

index.php?option=com_virtuemart&view=category&virtuemart_category_id=10&virtuemart_manufacturer_id=0&clearCart=0
and sef is site.com/category-ten?clearCart=0

I really don't understand what is difference and why I have clearCart=0 is some URLs.

Changing of option "Using this menu item clears the cart" just changes clearCart=0 to clearCart=1.

Title: Re: Continue of discuss about /results,1-0 and ?clearCart=0 problem in category URL
Post by: jenkinhill on March 17, 2023, 13:01:12 PM
No idea. I have not encountered /results,1-0   or  ?clearCart=0 on any of my tests
Title: Re: Continue of discuss about /results,1-0 and ?clearCart=0 problem in category URL
Post by: hazael on March 18, 2023, 10:03:24 AM
Just turn it off in the main menu of the selected category
Title: Re: Continue of discuss about /results,1-0 and ?clearCart=0 problem in category URL
Post by: scriner on March 18, 2023, 17:35:26 PM
Quote from: hazael on March 18, 2023, 10:03:24 AM
Just turn it off in the main menu of the selected category

As I wrote before: Changing of option "Using this menu item clears the cart" just changes clearCart=0 to clearCart=1.

This option don't remove clearCart from URL anyway.
Title: Re: Continue of discuss about /results,1-0 and ?clearCart=0 problem in category URL
Post by: Milbo on March 20, 2023, 11:37:57 AM
Please use this file https://dev.virtuemart.net/projects/virtuemart/repository/revisions/10805/entry/trunk/virtuemart/components/com_virtuemart/router.php
Title: Re: Continue of discuss about /results,1-0 and ?clearCart=0 problem in category URL
Post by: kiro789 on March 22, 2023, 08:06:59 AM
It is not workin on my site.

Regards!
Title: Re: Continue of discuss about /results,1-0 and ?clearCart=0 problem in category URL
Post by: Kuubs on March 22, 2023, 11:52:15 AM
Quote from: Milbo on March 20, 2023, 11:37:57 AM
Please use this file https://dev.virtuemart.net/projects/virtuemart/repository/revisions/10805/entry/trunk/virtuemart/components/com_virtuemart/router.php
Is it possible to include this fix in the upcoming release?
Title: Re: Continue of discuss about /results,1-0 and ?clearCart=0 problem in category URL
Post by: StefanSTS on March 23, 2023, 17:25:41 PM
The fix should be in 4.0.14.10805. It was fixed Sunday night.

STS
Title: Re: Continue of discuss about /results,1-0 and ?clearCart=0 problem in category URL
Post by: ViPeS on April 08, 2023, 21:23:04 PM
Quote from: StefanSTS on March 23, 2023, 17:25:41 PM
The fix should be in 4.0.14.10805. It was fixed Sunday night.

STS

VirtueMart 4.0.16 10812, Joomla 4.2.9, PHP 8.0.26
bug /results,1-0 not fixed
https://www.virtuvinis.lt/shop/kategorijos/results,1-0
Title: Re: Continue of discuss about /results,1-0 and ?clearCart=0 problem in category URL
Post by: StefanSTS on April 09, 2023, 12:09:19 PM
The issue came back in 4.0.16.
There was a problem with the first page of pagination not showing.
I didn't properly read through what was done, but after changes in the router, it is working in the latest dev version now.
Should be fixed again in the next release.

I guess 4.0.16 was put out too quickly because the fix seemed so easy, but router stuff is never easy.

Stefan