VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Topic started by: man.of.earth on July 05, 2021, 17:47:00 PM

Title: Package 3.8.9 10514 throws an error when sending order
Post by: man.of.earth on July 05, 2021, 17:47:00 PM
Hello everyone,

I noticed that the 3.8.9 10514 version of VM throws an error right when confirming/sending the order.

Call to a member function setConvertDecimal() on int

The temporary solution I found is replacing the 4 files modified here http://dev.virtuemart.net/projects/virtuemart/repository/revisions/10514 with their previous versions. It still throws errors, but at least it works.
Title: Re: Package 3.8.9 10514 throws an error when sending order
Post by: sirius on July 16, 2021, 18:48:06 PM
Hi

I confirm this bug on 3.8.9 10514
Title: Re: Package 3.8.9 10514 throws an error when sending order
Post by: LeandroM on August 03, 2021, 21:19:38 PM
I´m facing this issue in my website, did this bug is already solved?
Title: Re: Package 3.8.9 10514 throws an error when sending order
Post by: sirius on August 25, 2021, 10:14:20 AM
I suppose that Révision 10521 (http://dev.virtuemart.net/projects/virtuemart/repository/revisions/10521) and Révision 10522 (http://dev.virtuemart.net/projects/virtuemart/repository/revisions/10522) could be related to this issue.
Just waiting for the new package to test it.
Title: Re: Package 3.8.9 10514 throws an error when sending order
Post by: GJC Web Design on August 25, 2021, 17:15:26 PM
QuoteI´m facing this issue in my website, did this bug is already solved?

I hope u mean your test site?  odd numbered releases like 3.8.9 are NOT intended for production .. they are pre releases
Title: Re: Package 3.8.9 10514 throws an error when sending order
Post by: sirius on September 24, 2021, 11:09:23 AM
Does someone already test the last com_virtuemart.3.8.9.10544 to see if this bug is fixed ?
Title: Re: Package 3.8.9 10514 throws an error when sending order
Post by: Bob James on December 31, 2021, 06:56:06 AM
Hello. I also have this issue

Fatal error: Call to a member function setConvertDecimal() on integer in administrator/components/com_virtuemart/plugins/vmplugin.php on line 722

if($this->_toConvertDec){
$this->_vmpItable->setConvertDecimal($this->_toConvertDec);
}


I deleted that and got to the payment gateway.

What is the code doing?
Title: Re: Package 3.8.9 10514 throws an error when sending order
Post by: jenkinhill on December 31, 2021, 10:37:51 AM
Is that with the latest community test version release, com_virtuemart.3.8.9.10564
Title: Re: Package 3.8.9 10514 throws an error when sending order
Post by: Bob James on December 31, 2021, 11:12:28 AM
It is not.
It is the one for J3.9 download at http://dev.virtuemart.net/projects/virtuemart/files
3.8.9 (stable, compatible J3.9)

Title: Re: Package 3.8.9 10514 throws an error when sending order
Post by: Bob James on December 31, 2021, 11:20:06 AM
this one com_virtuemart.3.8.9.10514_package_or_extract

do you know what the code is doing please?
Title: Re: Package 3.8.9 10514 throws an error when sending order
Post by: jenkinhill on December 31, 2021, 12:42:20 PM
I have not seen anyone else report this as a problem in VM3.8.9.10514   I don't know what it does.

The code is different in 10564  (this is also J3.9 compatible, + J3.10)

   public function setConvertDecimal(array $toConvert) {

      $this->_toConvertDec = $toConvert;
   }


(https://i.ibb.co/42MNfDz/Ashampoo-Snap-31-December-2021-11h21m52s-004.png)
Title: Re: Package 3.8.9 10514 throws an error when sending order
Post by: sirius on December 31, 2021, 15:02:14 PM
Hi jenkinhill

just tested the 10564 package, and the error is gone

(but I have another issue, the card payment (systempay) do not appear anymore on the cart, I only have the bank transfer payment option)

Quote from: sirius on July 16, 2021, 18:48:06 PM
Hi

I confirm this bug on 3.8.9 10514

Quote from: arcturus on July 05, 2021, 17:47:00 PM
Hello everyone,

I noticed that the 3.8.9 10514 version of VM throws an error right when confirming/sending the order.

Call to a member function setConvertDecimal() on int

The temporary solution I found is replacing the 4 files modified here http://dev.virtuemart.net/projects/virtuemart/repository/revisions/10514 with their previous versions. It still throws errors, but at least it works.
Title: Re: Package 3.8.9 10514 throws an error when sending order
Post by: Bob James on January 01, 2022, 07:06:55 AM
/*if($this->_toConvertDec){
$this->_vmpItable->setConvertDecimal($this->_toConvertDec);
}*/

if($this->_toConvertDec and is_array($this->_toConvertDec) ){
$table->setConvertDecimal($this->_toConvertDec);
}


Yes, this code change! (vmplugin.php Line 721)

Thank you very much guys.
Title: Re: Package 3.8.9 10514 throws an error when sending order
Post by: jenkinhill on January 01, 2022, 12:34:14 PM
Quote from: sirius on December 31, 2021, 15:02:14 PM

(but I have another issue, the card payment (systempay) do not appear anymore on the cart, I only have the bank transfer payment option)


I thought Systemplay stopped working when we went from VM2 to VM3. It is no longer part of VM so maybe you have a 3rd party plugin?
Title: Re: Package 3.8.9 10514 throws an error when sending order
Post by: sirius on January 01, 2022, 15:39:03 PM
yes sorry I did not specify, it is the lyra network plugin V 2.2.1 compatible with VM 3.X
Two links to get it
https://paiement.systempay.fr/doc/fr-FR/plugins/#virtuemart
https://www.lyra.com/fr/guides/virtuemart/

And happy new year  :D
Title: Re: Package 3.8.9 10514 throws an error when sending order
Post by: ec83 on May 28, 2023, 13:45:25 PM
Quote from: Bob James on January 01, 2022, 07:06:55 AM
/*if($this->_toConvertDec){
$this->_vmpItable->setConvertDecimal($this->_toConvertDec);
}*/

if($this->_toConvertDec and is_array($this->_toConvertDec) ){
$table->setConvertDecimal($this->_toConvertDec);
}


Yes, this code change! (vmplugin.php Line 721)

Thank you very much guys.

Thank you very much for this correction while waiting for the new stable version in 3.8.9
Have a good day
Title: Re: Package 3.8.9 10514 throws an error when sending order
Post by: Milbo on May 29, 2023, 21:09:26 PM
There wont be a new vm3.8.9. The next version is vm4.0.22