VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Topic started by: Robert_ITMan on September 23, 2019, 17:29:05 PM

Title: [SOLVED] updating status and sending customer an update / comment
Post by: Robert_ITMan on September 23, 2019, 17:29:05 PM
[SOLVED] Issue 1: with VM 3.6.2 noticed issue when updating status and sending customer an update / comment. The order status must be changed or it does not save new comment and sends last comment - need to fix this as we should not have to change the order status to save or send a new comment. Easy fix right?

Issue 2: Calculations are not correct - for example edit one line item and enter a value in 'Total Discount', clear: 'Base price with tax', 'Program Price (Gross)', and 'TAX' - click update. Notice the product_discountedPriceWithoutTax is calculated wrong and the 'Program Price (Cost)' discounted value is wrong

Question 1: What is Purchase Order? Where is the help / info on this?

Question 2: What is '0000-00-00 unpaid' / 'partial paid' / 'balance owing'? Where is the help / info on this? Nice idea! Notice The dates are missing and before adding a partial amount the date is showing as 0000-00-00 why is this? Also - is there a way to disable this and/or improve it so when order status is complete it shows as paid without our having to manually update each order?

Question 3: I suggest adding new unique class to tables and better formatting especially for header info 'Billing details' and 'Ship to' so these are not expanded and us admins can quickly see the order items without having to scroll down past this every time - and if we want to see or edit this header info we could simply click to expand it. As-is this table has no class !! <table width="100%">

Question 4: Need to be able to update coupon descriptions and amounts (per order) when editing - saving us from having to edit in the DB directly

Question 5: Would be great if we can also edit the item options (product_attribute) - saving us from having to edit in the DB directly

Question 6: Would be great to also create a way to display the percentage of the discounts (using javascript, i.e. also valid in cases where there are multiple prices involved), as also suggested here by Studio 42: http://forum.virtuemart.net/index.php?topic=134380.msg467090#msg467090
Title: Re: Editing Order questions
Post by: Robert_ITMan on September 24, 2019, 16:47:31 PM
[SOLVED] Issue: resolved with 3.6.2.10159 - order status does not need to be changed to send/save new comment

Still have questions unanswered above
Title: Re: Editing Order issues and questions
Post by: jenkinhill on September 24, 2019, 18:32:36 PM
Your 1 - asking about purchase order.   From WikiPedia (assuming you do mean being able to place an order through VM without having to pay ay the time of ordering - which is easy to set up)

A purchase order (PO) is a commercial document and first official offer issued by a buyer to a seller indicating types, quantities, and agreed prices for products or services. It is used to control the purchasing of products and services from external suppliers.
The difference between a purchase order and an invoice is that a purchase order is sent from a purchaser to a vendor to place an order while an invoice is sent from a vendor to a purchaser to request payment for an order.

As a rule of thumb, never ask more than one question in a single forum message!
Title: Re: Editing Order issues and questions
Post by: Robert_ITMan on September 24, 2019, 18:46:54 PM
Quote from: jenkinhill on September 24, 2019, 18:32:36 PM
Your 1 - asking about purchase order.

Thank you jenkinhill for describing what a Purchase Order is - not actually what I was asking for, I'm asking for VM to add instructions to the help page about HOW TO use this in VM and what are the options and how do we set them and what the settings do.

Quote from: jenkinhill on September 24, 2019, 18:32:36 PM
As a rule of thumb, never ask more than one question in a single forum message!

Again, thank you jenkinhill for pointing this out - Yes, I will split it up if nothing ever happens on these questions ... I really just needed to put this in writing somewhere so VM person responsible for editing this will make it happen.
Title: Re: Editing Order issues and questions
Post by: Robert_ITMan on September 25, 2019, 19:11:26 PM
Notice I found a 2nd issue

Issue 2: Calculations are not correct - for example edit one line item and enter a value in 'Total Discount', clear: 'Base price with tax', 'Program Price (Gross)', and 'TAX' - click update. Notice the product_discountedPriceWithoutTax is calculated wrong and the 'Program Price (Cost)' discounted value is wrong
Title: Re: Editing Order issues and questions
Post by: AH on September 25, 2019, 20:14:21 PM
Show the detail of this order edit line issue for us to see please

My tests show order line editing is working fine - but I may not be testing your specific case
Title: Re: Editing Order issues and questions
Post by: Robert_ITMan on September 25, 2019, 20:44:42 PM
See images
Title: Re: Editing Order issues and questions
Post by: AH on September 25, 2019, 21:30:08 PM
In image 3 - I am probably being stupid - but that all looks pretty much correct to me

How do you think those figures should work out for you

Gross is 10

Tax is 11%

Discount is 4

10 + Tax is 11.10

11.10 - 4 = 7.10
Title: Re: Editing Order issues and questions
Post by: Robert_ITMan on September 25, 2019, 22:03:27 PM
You missed 'Program Price (Cost)' discounted value is wrong:

?? 10.00 - 4.00 = 6.40 ??

Title: Re: Editing Order issues and questions
Post by: AH on September 26, 2019, 00:10:27 AM
why -4

Gross = 7.10
Nett= 7.10/1.11 = 6.40

Title: Re: Editing Order issues and questions
Post by: Robert_ITMan on September 26, 2019, 00:21:35 AM
See attached showing order and DB - and my red ink pointing out what I see

Math should be: 10.00 - 4.00 discount = 6.00
then tax at 11% = 6.00 * 1.11 = 6.66
Title: Re: Editing Order issues and questions
Post by: AH on September 26, 2019, 01:02:31 AM
IT MAN

Doing some more testing I can see that there is something odd in the entries when manually inputting discount

But it should be noted that this field is called product_subtotal_discount - It should therefore reflect the value adjustment from the line subtotal, not from the base price thus a -ve amount should be input

See any entries in the db for a reduction discount value

I understand this does not solve your problem - but I believe that it explains part of the issue with your edit
Title: Re: Editing Order issues and questions
Post by: Robert_ITMan on September 26, 2019, 01:09:00 AM
AH, Thank you for getting on this! Great that you now see we have something odd in the calculations. The discount has always been entered as positive and directly subtracts from the base price ('Product Price (Cost)' or product_item_price)

Entering a negative discount gives the same result regardless - all discounts in the DB are positive values to date.
Title: Re: Editing Order issues and questions
Post by: AH on September 26, 2019, 09:20:58 AM
Hi Robert

With discounts form the front end - I see them as negative in the dbase

And in order edit - if the discount was form the FE it shows as a negative

I will ask the team if they understand this behaviour with order edit
Title: Re: Editing Order issues and questions
Post by: Robert_ITMan on October 17, 2019, 21:19:08 PM
VirtueMart 3.6.3 10179 tested: issue and questions NOT addressed yet.
Title: Re: Editing Order issues and questions
Post by: Robert_ITMan on October 21, 2019, 14:34:14 PM
Added Question 6: Would be great to also create a way to display the percentage of the discounts (using javascript, i.e. also valid in cases where there are multiple prices involved), as also suggested here by Studio 42: http://forum.virtuemart.net/index.php?topic=134380.msg467090#msg467090
Title: Re: Editing Order issues and questions
Post by: AH on October 21, 2019, 15:22:10 PM
Not sure what your purpose for doing this list is -

Each issue/item should be separated - I suspect this list is not being monitored by anyone but you

A suggestion is just that, a suggestion - do not expect anything to happen as a result and please do not bump

Title: Re: Editing Order issues and questions
Post by: Robert_ITMan on October 21, 2019, 15:56:18 PM
Quote from: AH on October 21, 2019, 15:22:10 PM
do not expect anything to happen as a result
AH - please do not reply unless you are actually helping in some some way (maybe to acknowledge the issue and questions are valid or to say it has been brought to the attention of the VM development team). As I see it your comments are not helping and they only serve as lip service and to make this request look as answered - even though you did not answer anything.

VM Development Team - Why are we not seeing any improvements from you on this? When will someone take responsibility for the mess of calculations and how orders / invoices / emails are displayed - this stuff is core and VMs future success depends on this. Whom ever is responsible for the core back-end order editing & calculations & templates and front-end templates please private message me and I will help you fix all this ... I am not about to do all this in the templates only to have you mess it up with future updates on me again - we need to see this working now for everyone.
Title: Re: Editing Order issues and questions
Post by: AH on October 21, 2019, 16:35:59 PM
Robert

Since when do you get to tell others what they should be doing with their time.

I suggested you split your topics - to enable those deciding if they want to do anything with them - to respond to each element in turn.

You have been requested to do this before in this thread by Jenkinhill

With your limited input to this forum and project - I suggest you take a step back from the edge and understand that this forum is not your personal requirement list for others to work through and deliver and neither is it a place where you demand things.

Respect the forum and those that contribute to it - they do this for free.

Title: Re: Editing Order issues and questions
Post by: StefanSTS on October 21, 2019, 16:46:03 PM
Robert, I add that copy and pasting demands from one thread to another does not help either.

AH is a valuable member of the VirtueMart team for many years and has helped many on their issues.

I hereby issue a warning not to use language like "lip service" again in this forum, especially not taking about valuable members of this forum. We don't need that here.

Stefan


Title: Re: Editing Order issues and questions
Post by: Robert_ITMan on October 21, 2019, 17:20:52 PM
I hear you and I mean no disrespect - I appreciate your help and replies. I'm spending my time too and I'm trying to help and I'm offering to help more where it matters most in an unselfish way - not for my own specific needs. I do see how splitting these into separate things is a popular approach - and I will do that to make you all happy. Sorry I was thinking it would help more to keep a running list of all the issue and questions together in one thread as  they all relate to the same specific code that can be improved.

I am also sorry for offending in anyway - and I see I am in the wrong here to point out your comments are not addressing the issues or questions rather letting me know I'm doing it wrong ... so please forgive me for seeing things differently and trying to contribute and asking for help and offering to help in what I thought was done in a helpful way.

Again - I appreciate your help and replies.
Title: [SOLVED] updating status and sending customer an update / comment
Post by: Robert_ITMan on October 21, 2019, 18:45:13 PM
Editing Order issues and questions - I opened new topics and marked this one solved for issue 1 'updating status and sending customer an update / comment.'