VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Topic started by: inode64 on August 31, 2015, 17:19:59 PM

Title: Fix SEF in /components/com_virtuemart/helpers/vmview.php
Post by: inode64 on August 31, 2015, 17:19:59 PM
this fix remove $lang (is not need) and make SEF friendly in "continue_link" and "cart_link" hrefs
Title: Re: Fix SEF in /components/com_virtuemart/helpers/vmview.php
Post by: Studio 42 on August 31, 2015, 17:31:36 PM
Do you don't need it? or this is not needed ?
In case of multi-language, this is needed
Title: Re: Fix SEF in /components/com_virtuemart/helpers/vmview.php
Post by: inode64 on August 31, 2015, 22:09:59 PM
I check a site with 3 langs, and combination without SEF, Joomla SEF and Sef404 and run fine
Title: Re: Fix SEF in /components/com_virtuemart/helpers/vmview.php
Post by: Studio 42 on September 01, 2015, 21:32:28 PM
Ok, but you have checked in how many Joomla release ?
This fix Joomla problems in some release.
Title: Re: Fix SEF in /components/com_virtuemart/helpers/vmview.php
Post by: inode64 on September 01, 2015, 22:40:38 PM
This fix is for virtuemart > 3.0.9
Title: Re: Fix SEF in /components/com_virtuemart/helpers/vmview.php
Post by: inode64 on September 01, 2015, 22:41:00 PM
This fix is for virtuemart > 3.0.9
Title: Re: Fix SEF in /components/com_virtuemart/helpers/vmview.php
Post by: GJC Web Design on September 01, 2015, 23:03:54 PM
he meant which Joomla versions as there has been real lang compat probs with the various Joomla 3.4x releases
Title: Re: Fix SEF in /components/com_virtuemart/helpers/vmview.php
Post by: inode64 on September 01, 2015, 23:05:31 PM
Sorry, Joomla 3.4.3
Title: Re: Fix SEF in /components/com_virtuemart/helpers/vmview.php
Post by: Milbo on September 06, 2015, 12:00:35 PM
The lang is imho needed in some versions. The reason we had to add it. Imho it does not hurt to have it. And did you test with the new router of Hannes, also?