VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Topic started by: MarioP on November 21, 2013, 21:41:50 PM

Title: [SOLVED in 2.0.25e]Sort by fields problem with product name in VM.2.0.24b
Post by: MarioP on November 21, 2013, 21:41:50 PM
Hi,
VM BE 'default product sort order' settings: Product name: ascending
Available Sort-by fields : Product Name and  Product Price

In the VM front end category view defualt sort by Product name works fine (when it's show up as a default I can change the ascending and descending ordering and it works as it should). When I change to Product Price it also works, but when I try to come back to (I choose the option) sort by Product name, the feature doesn't work.
So when I sort by price the url is following
'my product category name'/by,product_price?language=en-GB&filter_product=
When I go to sort by name
'my product category name'?language=en-GB&filter_product=
Joomla 2.5.16
Please help.
Title: Re: Sort by fields problem with product name in VM.2.0.24b
Post by: Milbo on November 22, 2013, 12:14:20 PM
Found, thx. Seems we have todo a C version
Title: Re: Sort by fields problem with product name in VM.2.0.24b
Post by: MarioP on November 22, 2013, 19:42:43 PM
Updated to C and similar problem with the ordering :-[. When we try to come back to sort by 'product name' the feature becomes default, it shows up in the field 'sort by' but it still doesn't work. The url is following
'category_name'?language=en-GB&filter_product=
when you again click on 'product name' we have:
'category_name'/orderDesc?language=en-GB&filter_product=
Should not be something like this 'by,p.product_name' in the url?
Title: Re: Sort by fields problem with product name in VM.2.0.24b
Post by: michelming on November 23, 2013, 02:20:55 AM
Quote from: MarioP on November 21, 2013, 21:41:50 PM
Hi,
VM BE 'default product sort order' settings: Product name: ascending
Available Sort-by fields : Product Name and  Product Price

In the VM front end category view defualt sort by Product name works fine (when it's show up as a default I can change the ascending and descending ordering and it works as it should). When I change to Product Price it also works, but when I try to come back to (I choose the option) sort by Product name, the feature doesn't work.
So when I sort by price the url is following
'my product category name'/by,product_price?language=en-GB&filter_product=
When I go to sort by name
'my product category name'?language=en-GB&filter_product=
Joomla 2.5.16
Please help.

After testing, I have the same problem
Title: Re: Sort by fields problem with product name in VM.2.0.24b
Post by: MarioP on November 24, 2013, 17:19:35 PM
Has the problem been recognized as solved after C version released?  michelming did you try the new version? Did it solve your problem? For me it doesn't work.
QuoteWhen we try to come back to sort by 'product name' the feature becomes default, it shows up in the field 'sort by' but it still doesn't work. The url is following
'category_name'?language=en-GB&filter_product=
when you again click on 'product name' we have:
'category_name'/orderDesc?language=en-GB&filter_product=
Should not be something like this 'by,p.product_name' in the url?
Title: Re: Sort by fields problem with product name in VM.2.0.24b
Post by: Milbo on November 24, 2013, 19:27:40 PM
Did you store your vm config? I had to recheck the product name, then it worked.
Title: Re: Sort by fields problem with product name in VM.2.0.24b
Post by: MarioP on November 24, 2013, 20:30:03 PM
Yes, I stored it as you wrote in VM live update information "Just go in the vm config to the ordering settings, choose product name and store it one time". Ok, probably I managed to discover what is wrong. So when 'Default product sort order' is set to product name the feature still doesn't work. When I change it to 'Creation date' for example it works as it should. Could you please check it?
Title: Re: Sort by fields problem with product name in VM.2.0.24b
Post by: michelming on November 25, 2013, 01:50:05 AM
Quote from: MarioP on November 24, 2013, 17:19:35 PM
Has the problem been recognized as solved after C version released?  michelming did you try the new version? Did it solve your problem? For me it doesn't work.
QuoteWhen we try to come back to sort by 'product name' the feature becomes default, it shows up in the field 'sort by' but it still doesn't work. The url is following
'category_name'?language=en-GB&filter_product=
when you again click on 'product name' we have:
'category_name'/orderDesc?language=en-GB&filter_product=
Should not be something like this 'by,p.product_name' in the url?

Yes, I have upgraded to 24c, I repeatedly set a different default sort, but they are not working correctly in FE
Title: Re: Sort by fields problem with product name in VM.2.0.24b
Post by: Milbo on November 25, 2013, 18:42:42 PM
This is a new C version. ONLY for UPDATERS!

http://dev.virtuemart.net/attachments/download/659/com_virtuemart.2.0.24c.Updater.tar.gz

I had to change the model and the router again. sry. Please test.

- if the default ordering is used,
- if the default  ordering direction is used

in case of default, there shouldnt be any options in the URL, they should be only shown if you are not using standard.

Check also if the search is still working for you.
At best without SEF, with SEF and one time with URL rewrite.

Thank you
Title: Re: Sort by fields problem with product name in VM.2.0.24b
Post by: MarioP on November 25, 2013, 21:00:49 PM
Quote- if the default ordering is used,
- if the default  ordering direction is used
It's ok for me. Default ordering and it's directions work properly.
QuoteCheck also if the search is still working for you.
without SEF - ok, with SEF -ok  and one time with URL rewrite- ok.
Quotein case of default, there shouldnt be any options in the URL, they should be only shown if you are not using standard.
That's right.
Sorry if I unnecessarily repeat this (maybe the new C file is only preparation for new release) but for me the problem hasn't gone. When we, ( in VM FE) after change to one of available 'sort by fields' ( 'product price' e.g.), try to come back to the DEFAULT sort by 'product name' the feature doesn't work - it seems that the ordering is random. The url is following
'category_name'?language=en-GB&filter_product=
Title: Re: Sort by fields problem with product name in VM.2.0.24b
Post by: michelming on November 26, 2013, 04:08:53 AM
Yes, the problem still exists.
Now I return to 24c.
But I tried, I chose Available Sort-by fields as 'product name', 'product price' and 'ordering', and Default product sort order Choose 'Product id' in BE, you can work in FE
Title: Re: Sort by fields problem with product name in VM.2.0.24b
Post by: Milbo on November 26, 2013, 14:03:42 PM
Thank you MarioP for pointing that out and explaining.

Please try the attached product model, copy to /administrator/.../com_virtuemart/models

[attachment cleanup by admin]
Title: Re: Sort by fields problem with product name in VM.2.0.24b
Post by: michelming on November 26, 2013, 14:46:24 PM
Thank you Milbo

Now do not update to the new C version, just replace the attached product model, sorting tested, correct

Title: Re: Sort by fields problem with product name in VM.2.0.24b
Post by: MarioP on November 26, 2013, 15:02:05 PM
Of course it works :) Thanks Milbo.
Title: Re: [SOLVED]Sort by fields problem with product name in VM.2.0.24b
Post by: Milbo on November 26, 2013, 16:27:14 PM
in fact you should update AND use the new model, But we do a D no :-( grmblfix. You wont believe it, but the ordering was tested by different users. But testing all possibilities is not easy and to understand the small differences.
Also the reason I wrote down what to test, because the simple "it does not work" means just for me,.. "oh,... seems there is some case you miss, but which one", the last post of MarioP explained me the last problem.
Title: Re: [SOLVED]Sort by fields problem with product name in VM.2.0.24b
Post by: michelming on November 26, 2013, 19:03:46 PM
OK, I've updated, thank you very much!
Title: Re: [SOLVED]Sort by fields problem with product name in VM.2.0.24b
Post by: MarioP on December 05, 2013, 20:59:55 PM
Hello.
The problem came back in VM 2.0.25d test version. Or maybe that's why this is only the test version the problem occurs?
I've tried to replace the original file to that from this post
QuotePlease try the attached product model, copy to /administrator/.../com_virtuemart/models
But the problem still exists :(
So ( in VM FE) we change from default sort by 'product name' to 'product price' a then we choose again sort by 'product price" in order to gain descending order. Descending order works but in that moment sort by 'product price' appears as default in 'sort by' field - it's something wrong... Then when we choose sort by 'product name' the feature doesn't work.
The problem doesn't occur in 2.0.24c with the patch file implemented.
Title: Re: [SOLVED?]Sort by fields problem with product name in VM.2.0.24b
Post by: Milbo on December 06, 2013, 10:32:36 AM
Quote from: MarioP on December 05, 2013, 20:59:55 PM
So ( in VM FE) we change from default sort by 'product name' to 'product price'
You changed the default ordering in the FE? interesting, I am not aware of this. Fun aside, I think you mean that you just changed your ordering in the FE to product_price. and with "default" you mean that it is set on first position of the list? If you click again on it, it does not reorder?

Quote from: MarioP on December 05, 2013, 20:59:55 PM
a then we choose again sort by 'product price" in order to gain descending order. Descending order works but in that moment sort by 'product price' appears as default in 'sort by' field
Yes, that is correct.

Quote from: MarioP on December 05, 2013, 20:59:55 PM
- it's something wrong... Then when we choose sort by 'product name' the feature doesn't work.
The problem doesn't occur in 2.0.24c with the patch file implemented.
What is wrong? So you say you click in the list on product_name, but nothing happens? or what means the feature does not work? do you use SEF or not?
Title: Re: [SOLVED?]Sort by fields problem with product name in VM.2.0.24b
Post by: MarioP on December 06, 2013, 10:43:21 AM
QuoteSo ( in VM FE) we change from default sort by 'product name' to 'product price'
By default I mean  that it is set on the first position of the list ( is set as default in VM BE)
Quotea then we choose again sort by 'product price" in order to gain descending order. Descending order works but in that moment sort by 'product price' appears as default in 'sort by' field
Sorry, it should be: we choose again sort by 'product price" in order to gain descending order. Descending order works but in that moment sort by 'PRODUCT NAME' appears as default in 'sort by' field.
QuoteThen when we choose sort by 'product name' the feature doesn't work.
I have the following url: www.mydoamin.com/en/product-catalogue-en/passive-speaker-systems?language=en-GB
Ordering seems to be random.
I use SEF.
Title: Re: [SOLVED?]Sort by fields problem with product name in VM.2.0.24b
Post by: Milbo on December 06, 2013, 11:34:21 AM
I found it small error in the router. There will be a new version today, just for you to test

[attachment cleanup by admin]
Title: Re: [SOLVED?]Sort by fields problem with product name in VM.2.0.24b
Post by: MarioP on December 06, 2013, 11:46:06 AM
Thanks. Quick test with the patch file and it seems to work properly.