VirtueMart Forum

VirtueMart 2 + 3 => Virtuemart Development and bug reports => Development & Testing => Topic started by: Milbo on May 23, 2013, 19:17:15 pm

Title: [Updated] Release 2.0.21 G
Post by: Milbo on May 23, 2013, 19:17:15 pm
Latest version here http://dev.virtuemart.net/attachments/download/618/com_virtuemart.2.0.21g_extract_first.targz.zip and here
http://dev.virtuemart.net/attachments/download/619/com_virtuemart.2.0.21g_extract_first.zip

Yeha after a long time compared to our development cycle the last year, we have a new version. Please test.

Interesting for you:

almost full list (unsorted)
help menu
added ordering by dragn drop for categories and products  by StephanBais
fixed bug, that registered could unreveal orders of anonymous shoppers
configuration of header and footer (invoices, delivery notes, etc), delivery notes creation for orders, Thanks to Reinhold
Added an option to use fancy or facebox.
Added option to show related products in the cart popup to the config
add to cart popup is overridable using joomla
mediahandler, search enhanced and pagination works
order edit integration from trunk (thanks to Ondrej)
splitted language files
fixed canonical links
replaced $this->loadHelper('parameterparser'); and similiar with if(!class exist require pattern
cleaned more of the language files
added vm2.1 product_edit_customer.php to branch. Some enhancements by Seyin
some modifications and bug fixes on order edit
some fixes on order status update
emails send in the shoppers language
Product with price= 0  can be added to cart. New parameter for standard payment to send invoice on order total=0
small fix ...  product->created_on became sometimes 0
removed that it takes only 5 products per run in migration,
some format stuff.
Added to paypal refunded
fixes for display of + and - all discounts in cart with minus
Paypal email http://forum.virtuemart.net/index.php?topic=114514.0
By Reinhold, new filter in media for roles
More sorting options
getString for plugin controller, need for reenable downloads
shopfunctions fix for convertUnit
fixed for neighboured products for some sortings
Please accept tos is directly displayed, less redirects
neighboured products only loaded, if activated
Pagetitle has now menutitle and shopname as variable in the lang key
show title from custom field as option
Paypal : force UTF-8 encoding
Bug fixes for clone products.
product prices wasn't clone
after cloning the product shopper group was the shopper group from priceDisplay
JText fix for product availability
http://forum.virtuemart.net/index.php?topic=114771.0
W3C compliance fix
fix for external product image url on lightbox
show additional images after click on main image position
fixed an error in the calculator and calculation of rules per bill with categories. An index was used in two different foreach loops.
some code sniffing stuff. Just removed some warnings, made some functions to static, ...
removed free products from topten
replaced $this->loadHelper('image') by if class exists (FE completly, some in BE)
removed some old loadhelper pointing to non existing helpers
added hash based cache for AvaTax
changed behaviour of media thumbs, the path/url is not stored unless it is an overwrite
added resetThumbs to delete all entries and thumbs to adjust to new pattern or changed thumbnail size
removed Info: for the messages
added quantity to product, so that it can be used easier in the cart popup
fixed metaauthor for homepage
removed unecessary getProduct function in cart


version a?
mainly fixed the latest stuff, discussed in this thread. But also enhanced the cache.

version b
fixed images of related products, if image is set on parent
using the value default on agree is autosetting add to cart
removed &amp: from links
and more

version c and d
configuration for the mails to be send
and more

version E
- Avatax certified
- removed escaped html entities from the email subject
- Fixed country state list for shipto,.. is now usuable two times on the screen (easier cart checkout).
- Added the nice chosen.js to the FE dropdowns (not everywhere, but more as before)
- small fix for order editing, calculate discount automatically was not working for all and so it must be changed by hand
- Added two migration scripts from the forum, just beta, they work as they are provided, not false prove, not storing progress. But with correct tables and high execution time, everything should work.

Version G:
Better pagination,
enhanced migrator
Title: Re: Release 2.0.21
Post by: Alejandro Kurczyn on May 23, 2013, 23:42:39 pm
Does it require updating of existing template overrides?
Title: Re: Release 2.0.21
Post by: AH on May 23, 2013, 23:50:16 pm
Milbo

Just installed and started to test on dev server - some immediate feedback, hope this helps

Bill to and ship to field labels are not being converted to text - in admin and invoice/delivery notes
Drag and drop ordering is a nice user interface addition

Edit order is a good start:-
Will there be an option to add an item and adjust shipping cost?

Fancybox looks cool!
However, the CSS z-index will cause most users that have a product image mouseover zoom (cloudzoom) to have the fancybox appear beneath their product image, Facebox was fine:-
Fancybox z-index = 11xx;
Facebox z-index =   z-index: 65xxx;

You may want to adjust this to stop a whole load of post "moaning" about this


Title: Re: Release 2.0.21
Post by: fparker on May 24, 2013, 01:39:21 am
VirtueMart is a great system overall. Overall my clients really like it.

But there is something that changed with a recent update that is totally unacceptable to them. We talked to the people who did the theme and template but they said this is something that is in the core and they can't change it. They had disabled it, but there were problems when they did so and had to add it back in.

Here's what my client can't deal with:

When you add custom fields which they already had in place previously, btw, all of them now add "No Additional Charge" to the end of each and every custom field variable entry. They do not want those words in the custom field.

They sell lingerie and there are times that some larger sizes will need to reflect additional charges. Not to mention that they do not want those words at the end of each and every custom field variable. It looks so bad to see a bra size variable like 36D and the beside that, it also says No Additional Charge after each entry.

It makes the fields too big/wide, and can cause real issues especially if the bra is big enough to actually warrant an additional charge for that size.

How can we get this fixed?

Thanks so much for any help on this.
Title: Re: Release 2.0.21
Post by: lindapowers on May 24, 2013, 06:27:32 am
Great news,

The only problem I found is with translations, all the backend vm2 configuration tab appears in english (an all the text inside the different tabs at configuration) in our spanish version, even installing the language pack still appears in english.

Regards
Title: Re: Release 2.0.21
Post by: Milbo on May 24, 2013, 09:46:38 am
Bill to and ship to field labels are not being converted to text - in admin and invoice/delivery notes
We dont have anylonger only one language file. The keys are not missing, the language file seems not be loaded. Please explain

- which language do you use (english is not enough, we must know if you use en-US or en-GB)


Fancybox z-index = 11xx;
Facebox z-index =   z-index: 65xxx;

I think a z-index of 1100 is high enough. In fact I believe there exists no page with more than 20 different levels.

We talked to the people who did the theme and template but they said this is something that is in the core and they can't change it.
...................
When you add custom fields which they already had in place previously, btw, all of them now add "No Additional Charge" to the end of each and every custom field variable entry. They do not want those words in the custom field.

This is a totally beginner question and should be posted in the general forum. Your templaters are noobs, really. http://docs.virtuemart.net/tutorials/33-templating-layouts/107-customization-of-displayed-text.html

...all the backend vm2 configuration tab appears in english (an all the text inside the different tabs at configuration) in our spanish version, even installing the language pack still appears in english.

The reason is that the spain language files are not done. We have new language files for the config, the orders and shopperfields. You just must check the new files and copy paste the old translation to it.
Title: Re: Release 2.0.21
Post by: franzpeter on May 24, 2013, 10:17:08 am
@Alejandro Kurczyn,
It depends on the template. In my case - using MegaMart Template - it definitely needs a template update, because the add to cart for Homepage and category product listing does not work. I think before installing any update it is strongly recommended to take a look into the template developers website about compatibility. Especially if the template developers do not use the same javascript code for the VM functions as VM uses by default, I would try it first on a localhost install to see, if it works or not.
Title: Re: Release 2.0.21
Post by: Milbo on May 24, 2013, 10:21:27 am
it definitely needs a template update, because the add to cart for Homepage and category product listing does not work.

This is strange. First problem with the templaters is that the overwrite anything without checking if the overwrite is necessary. The add to cart button works the same as before, just choose facebox in the BE.
Title: Re: Release 2.0.21
Post by: atrus on May 24, 2013, 12:24:01 pm
Well done guys, it is becoming better and better every day!

Has the stockable variant children price display for various shopper groups bug been fixed?

http://forum.virtuemart.net/index.php?topic=111867.0

Rgrds,
Chris
Title: Re: Release 2.0.21
Post by: Milbo on May 24, 2013, 15:11:47 pm
ah yes Hutson. the order edit view was missing to load the shopper lang keys. Fixed.
Title: Re: Release 2.0.21
Post by: AH on May 24, 2013, 15:13:32 pm
Cool!  8)

Did you fix this?

"ADD SHIPMENT ADDRESS" after click SAVE Button ERROR:
check failed: ST has no name

"Address Nickname" field has to be enabled- Just another field that slows checkout and causes issues if disabled

PRO suggested a "fix"

Code: [Select]
views/user/eddit_address.php

AFTER
<input type="hidden" name="address_type" value="<?php echo $this->address_type?>" />

add this
<?php if (JRequest::getVar('addrtype')=='ST')   { echo '<input type="hidden" name="shipto_address_type_name" value="Shipping" />';}?>

THEN:
edit_address_userfields.php
AFTER:
echo '   <table  class="adminForm user-details">' . "\n";
      $_table = true;
       }
Add this
   if ($_field['name']=='shipto_address_type_name') continue;

But not sure if you have a better option?
Title: Re: Release 2.0.21
Post by: Milbo on May 24, 2013, 15:41:19 pm
We could use some automatism,.. creating a name by Company name and street or so. Or add as default Shipping.
Title: Re: Release 2.0.21
Post by: AH on May 24, 2013, 15:50:47 pm
Automation would be great:

Possibly concatenate:
Address_1 + Zip

Company_name is often removed or left blank so would not be the best.


On slightly related topic, I have been strugglling for days trying to do a test on the zip code for uk


Any help or direction is greatly appreciated, I know you are extremely busy

I sorted it in Vm 1.1 but and have no success in VM2 (pathetic I know  :'( )

Code: [Select]

Vm 1.1
[b]ps_userfield.php[/b]
if( isset( $required_fields['zip'] )) {
echo '
if( form.country.value == "GBR"  && !(/^([a-zA-Z]{1,2}[0-9rR][0-9a-zA-Z]? [0-9][abd-hjlnp-uw-zABD-HJLNP-UW-Z]{2})$/.test(form.zip.value))) {
alert( \'Please enter a valid UK post code - e.g. KA27 8AA \');
return false;
}';
}
   



I can see the use of validator in edit_address.php (but am failing to get i test to work!)


Code: [Select]
<script language="javascript">
function myValidator(f, t) {
f.task.value = t; //this is a method to set the task of the form on the fTask.
if (document.formvalidator.isValid(f)) {
f.submit();
return true;
} else {
var msg = '<?php echo addslashes (JText::('COM_VIRTUEMART_USER_FORM_MISSING_REQUIRED_JS')); ?>';
alert(msg + ' ');
}
return false;
}

function callValidatorForRegister(f) {

var elem = jQuery('#username_field');
elem.attr('class', "required");

var elem = jQuery('#name_field');
elem.attr('class', "required");

var elem = jQuery('#password_field');
elem.attr('class', "required");

var elem = jQuery('#password2_field');
elem.attr('class', "required");

var elem = jQuery('#userForm');

return myValidator(f, '<?php echo $rtask ?>');

}
</script>

Title: Re: Release 2.0.21
Post by: lindapowers on May 24, 2013, 16:35:48 pm

The reason is that the spain language files are not done. We have new language files for the config, the orders and shopperfields. You just must check the new files and copy paste the old translation to it.

So any chance we can get the language file packs updated from transifex and install them instead of changing the lines in those files? Big task for multilingual websites.

Regards

EDIT: Done it manually
Title: Re: Release 2.0.21
Post by: fparker on May 24, 2013, 18:06:36 pm
We talked to the people who did the theme and template but they said this is something that is in the core and they can't change it.
...................
When you add custom fields which they already had in place previously, btw, all of them now add "No Additional Charge" to the end of each and every custom field variable entry. They do not want those words in the custom field.

This is a totally beginner question and should be posted in the general forum. Your templaters are noobs, really. http://docs.virtuemart.net/tutorials/33-templating-layouts/107-customization-of-displayed-text.html

That worked great. I searched for No additional charge in the language overrides and removed it from the cart item it found in the search. All is well again. Thanks for the link to read over. Between that and a confirmation on where it would be located, I was able to get it done.

I think this is a great system and I have tons to learn!

Thanks again.
Title: Re: Release 2.0.21
Post by: Milbo on May 24, 2013, 21:22:33 pm
lol linda, the idea is that someone does this in transifex for all.
Title: Re: Release 2.0.21
Post by: Milbo on May 24, 2013, 21:54:00 pm
We talked to the people who did the theme and template but they said this is something that is in the core and they can't change it.
...................
When you add custom fields which they already had in place previously, btw, all of them now add "No Additional Charge" to the end of each and every custom field variable entry. They do not want those words in the custom field.

This is a totally beginner question and should be posted in the general forum. Your templaters are noobs, really. http://docs.virtuemart.net/tutorials/33-templating-layouts/107-customization-of-displayed-text.html

That worked great. I searched for No additional charge in the language overrides and removed it from the cart item it found in the search. All is well again. Thanks for the link to read over. Between that and a confirmation on where it would be located, I was able to get it done.

I think this is a great system and I have tons to learn!

Thanks again.

feel welcome
Title: Re: Release 2.0.21
Post by: jjk on May 24, 2013, 22:06:04 pm
lol linda, the idea is that someone does this in transifex for all.
I think he meant that the ctransifex files on the new VM site are not yet synchronized with Transifex. Will try to take care of that over the weekend.
Title: Re: Release 2.0.21
Post by: lindapowers on May 25, 2013, 09:07:27 am
lol linda, the idea is that someone does this in transifex for all.
I think he meant that the ctransifex files on the new VM site are not yet synchronized with Transifex. Will try to take care of that over the weekend.

Thanks jjk, that is exactly what I meant. Max I'm doing the spanish for months and is updated since the first day you added the recent changes at Transifex but the packages available for download are from February for all language packs! Is nearly June! that is the only thing im saying ;) http://virtuemart.net/community/translations?view=project&id=1

Regards
Title: Re: Release 2.0.21
Post by: keep on May 26, 2013, 15:20:43 pm
I have a problem with plugins\vmshipment\weight_countries\weight_countries.php
I have free shipping over 1000. The $cart_prices['salesPrice'] is 1100, the shipping cost is 0, this is great. But if I add a coupon code (e.g. 30%) the billtotal is under 1000 but the shipping cost is still 0, because I can't access to the coupon value in the plugin's getCost() method.
Can you (or I) change the code to check the real total to calculate shipping cost?
Title: Re: [Updated] Release 2.0.21 B
Post by: Jumbo! on May 27, 2013, 19:19:25 pm
Milbo, I need little help.

I am trying to override the layout of Add to Cart pop but unable to find the file. Can please help me with the path of the layout file which controls the layout of Add to Cart pop up?

I also noticed that the following scripts are now not getting loaded in VM FrontPage or Category Page or for Product Module.

Therefore Add to Cart functionality is not working from these pages. Do we need to always manually call vmJsApi::jPrice(); in the template overrides to load these scripts in these pages? Presently in Ver 2.0.21b they are only getting loaded in product details page.

Please advice so that we can update our templates accordingly.
Title: Re: [Updated] Release 2.0.21 B
Post by: Milbo on May 27, 2013, 19:30:13 pm
the add to cart popup layout is in view/cart layout padded.php.

The js should only be loaded, if used, correctly.
Title: Re: [Updated] Release 2.0.21 B
Post by: Jumbo! on May 27, 2013, 19:33:06 pm
Thanks Milbo for the quick response. :)
Title: Re: [Updated] Release 2.0.21 B
Post by: piru on May 28, 2013, 12:05:43 pm
Hallo,
I have the version 2.0.20b, and I try to sort the products, but doesn´t work like I think.

I don´t know how can I make to drag and drop the products, I can only move them with the arrow down or up.
I tried too, to write a new number by "reorder" and save, but it doesn´t work if I write a number, for example, 100, and the last was 23. I have to write 24. This is unconfortable if I have to insert a product, I have to change again all numbers. Or how can I do it simple?

Thanks! piru
Title: Re: [Updated] Release 2.0.21 B
Post by: lindapowers on May 28, 2013, 12:57:15 pm
Hallo,
I have the version 2.0.20b,

Topic: [Updated] Release 2.0.21 B
Title: Re: [Updated] Release 2.0.21 B
Post by: piru on May 28, 2013, 13:07:14 pm
Oh, sorry.
But in my VM says:
You have the latest version
2.0.20b
Title: Re: [Updated] Release 2.0.21 B
Post by: piru on May 28, 2013, 13:49:30 pm
@lindapowers,

updated and now it works  :)

Thank you!
Title: Re: [Updated] Release 2.0.21 B (configuration of header and footer)
Post by: CarlosC on May 28, 2013, 21:12:19 pm
At first, thanks to Reinold for the new invoice-tool.

But some things are working wrong.

The fields "Textfeld unterer Rand:" and "Brieffuß Rand" are interchanged. The left value have to be lower then the right to get them viewed. But that is not the logic of the site geometries.

Using the JCE-Editor comes to a fault. After deleting the HTML in the editor it works fine. It seams the footer takes the css inherit of the editor.

The note in the update status popup of the order edit view is no longer printed in the confirmation email in the pdf it is.

Some translations in the mails are not translated but in the pdf they are.
Title: Re: [Updated] Release 2.0.21 C
Post by: Milbo on May 29, 2013, 00:36:08 am
The question is if you see langkeys, or just english. Be sure that you activated the english fallback. Which mails?
Title: Re: [Updated] Release 2.0.21 C
Post by: CarlosC on May 29, 2013, 12:00:40 pm
Thanks Milbo for the quick response,

I see some english no langkeys, but most is korrect translated in german.

For example:
In the file details_items.php the "COM_VIRTUEMART_ORDER_PRINT_SUBTOTAL_DISCOUNT_AMOUNT" translation is in the de-DE.com_virtuemart.ini and it is printed korrect in the view cart\tmpl\default.php and in the php-documents.
But in the mails it is english.

Registration mail vendor: Title, First Name, Last Name, Zip, City, Country, :BT are not
Registration mail shopper:Title, First Name, Last Name, Zip, City, Country are not

Confirmation mail vendor: SKU, Product status Price Qty Tax Discount, Total are not
Confirmation mail shopper: same
so the same at Confirmation mail update.

I tryed to find the 3 new lang_files for config, the orders and shopperfields, but didn't find them. wich files did you mean?

Best regards Carlos
Title: Re: [Updated] Release 2.0.21 C
Post by: Jumbo! on May 29, 2013, 21:27:45 pm
Found another small bug.

"Category Form Initial Display Records" is not working. Unable to limit the initiate number of products to be displayed in Category Product Listing page. It was working fine till 2.0.20b. Please check.
Title: Re: [Updated] Release 2.0.21 C
Post by: lindapowers on May 30, 2013, 00:39:56 am
First of all thanks for the big improvements in the system.

Since I can't find any reference to this in the roadmap and using VM2 daily as we do in our shop please consider adding an order batch update in the list orders view, it would save hours of work for shop owners.

Is a bit of a pain having to click each order one by one selecting the new order status to update it.

If we could select orders a simple "change orders to" - shipped, confirmed, etc would be great.

Or if any of the coders and 3rd party developers use a patch for it please share it with the VM team, is one of those little things missing that really improves the daily work for shop owners,

Regards
Title: Re: [Updated] Release 2.0.21 C
Post by: vladsklyar on May 30, 2013, 22:44:50 pm
Custom fields - are not sorted virtuemart 2.0.20b
as affairs with 2.0.21c
Title: Re: [Updated] Release 2.0.21 C
Post by: konstantin-shkodskih on June 02, 2013, 04:41:26 am
a small bug in the code of backednd part: in 'Debug Language' mode, when the code is inserted into inbuild JavaScript tag from constant value 'COM_VIRTUEMART_JS_STRINGS' error occurs, because Joomla adds an asterisks '**' at the beginning and end of the line.

result:
(http://i.imgur.com/SfiQIsg.png)

page: /administrator/index.php?option=com_virtuemart&view=config
file: /administrator/components/com_virtuemart/helpers/adminui.php   
position: strings 58-60
Title: Re: [Updated] Release 2.0.21 B (configuration of header and footer)
Post by: reinhold on June 03, 2013, 00:20:18 am
At first, thanks to Reinold for the new invoice-tool.
You're welcome...

Quote
The fields "Textfeld unterer Rand:" and "Brieffuß Rand" are interchanged. The left value have to be lower then the right to get them viewed. But that is not the logic of the site geometries.

I can't reproduce the problem. The left value gives the margin of the invoice contents to the page border, while the right value specifies where the (top of the) footer will be placed.

Here, if the left value is smaller than the right, then the invoice contents will overprint the footer...

Quote
Using the JCE-Editor comes to a fault. After deleting the HTML in the editor it works fine. It seams the footer takes the css inherit of the editor.

Do you have an example?

Quote
The note in the update status popup of the order edit view is no longer printed in the confirmation email in the pdf it is.
The contents of the confirmation mail were not changed by my patch at all. But I noticed a while ago that the note didn't have any effect (I just assumed that this was one of the features not yet properly implemented in VM2).

Quote
Some translations in the mails are not translated but in the pdf they are.

Can you please list all untranslated strings you encountered?

Thanks,
Reinhold
Title: Re: [Updated] Release 2.0.21 C
Post by: Stonedfury on June 03, 2013, 20:02:27 pm
Did the add to cart URL or parameters get changed? This link works in 2.0.20b but in this version it adds the currently viewed product along with the item clicked in the link.
Code: [Select]
$addtocart_url = JRoute::_ ('index.php?option=com_virtuemart&view=cart&task=add&quantity[]=1&virtuemart_product_id[]=' . $product->virtuemart_product_id . '&virtuemart_category_id[]=' . $product->virtuemart_category_id); ?>
    <a href="<?php echo $addtocart_url ?>">Add to Cart</a></span>

The vm cart doesnt seem to update though. I am using the default Joomla Beez20 template (not the parks) with all default module locations. So far a major improvement on the VM product!
Title: Re: [Updated] Release 2.0.21 C
Post by: Milbo on June 03, 2013, 21:18:11 pm
Activate the Facebox, maybe it is in your case connected to it, because our button has no link. It is done by ajax or by the form. Which is in fact the "same".
Title: Re: [Updated] Release 2.0.21 C
Post by: CarlosC on June 04, 2013, 19:57:05 pm

Hallo Reinhold,


it is a bit obscure but at my testsite the footer will only be placed korrect  if the left value is smaller than the right one, othervise then the invoice contents will overprint the footer... .
But never mind, if there is no one else with this behavior, it seams to be a local problem. May be you could tell me the files wich are afected to this so that I could compare the orig. files with my installation.


"Using the JCE-Editor...."


My stupid beginner mistake. I made a copy and paste of the variables "{vm:pagecount}, {vm:vendorname}, {vm:vendorimage}, {vm:vendoraddress}" out of the explenation at the bottom. So I made also a copy of the Editor-HTML.
After doing a direct type in, it works!


Translations:


Thanks Milbo for the quick response,


I see some english no langkeys, but most is korrect translated in german.


For example:
In the file details_items.php the "COM_VIRTUEMART_ORDER_PRINT_SUBTOTAL_DISCOUNT_AMOUNT" translation is in the de-DE.com_virtuemart.ini and it is printed korrect in the view cart\tmpl\default.php and in the php-documents.
But in the mails it is english.


Registration mail vendor: Title, First Name, Last Name, Zip, City, Country, :BT are not
Registration mail shopper:Title, First Name, Last Name, Zip, City, Country are not


Confirmation mail vendor: SKU, Product status Price Qty Tax Discount, Total are not
Confirmation mail shopper: same
so the same at Confirmation mail update.


I tryed to find the 3 new lang_files for config, the orders and shopperfields, but didn't find them. wich files did you mean?


Best regards Carlos


I hope this will help.
Best regards Carlos
Title: Re: [Updated] Release 2.0.21 C
Post by: Jumbo! on June 04, 2013, 21:01:02 pm
Milbo, it looks like another bug.

If you try to call normal custom fields (non-cart attribute type) in Category page or in Product Module the custom field array ($product->customfields) sometimes return as null or empty. If only view the same product in product details view then it works fine. I tested this with VM 2.0.20b and it works fine.

This seems like a bug when you try to show of custom fields for all products in product listing pages / areas and when the call is made in loop for all products.

Can you please look into this? I will wait for your response.
Title: Re: [Updated] Release 2.0.21 C
Post by: Stonedfury on June 04, 2013, 21:22:20 pm
On an updated demo site I added 2 demo products to a new category and when I went to update the image, the thumb url was not returned to the db and the link included (Default URL)image/etc... When I removed the (Default URL) from the url params it was inserted as normal but again returned with (Default URL)image/etc... You can save with that text now and the url in the db table is still good. Does not save the (Default URL)

[attachment cleanup by admin]
Title: Re: [Updated] Release 2.0.21 C
Post by: Stonedfury on June 04, 2013, 21:24:42 pm
Activate the Facebox, maybe it is in your case connected to it, because our button has no link. It is done by ajax or by the form. Which is in fact the "same".
I had to disable the fancybox clear cache, then enable fancybox again. Now works just fine.
Title: Re: [Updated] Release 2.0.21 C
Post by: Milbo on June 05, 2013, 13:02:36 pm
On an updated demo site I added 2 demo products to a new category and when I went to update the image, the thumb url was not returned to the db and the link included (Default URL)image/etc... When I removed the (Default URL) from the url params it was inserted as normal but again returned with (Default URL)image/etc... You can save with that text now and the url in the db table is still good. Does not save the (Default URL)

This is correct. The old behviour was to store the thumbnail relative URL in the db. This URL is anyway generated. So as long you do not use an URL which is different than the default, then no URL is stored. The reason is that we can now quite comfortable change the thumbnail size. Before, when you deleted the old thumbnails, the URL was still written and no new image was generated.
Title: Re: [Updated] Release 2.0.21 C
Post by: Stonedfury on June 05, 2013, 17:47:28 pm
That brings up a question and  I also noticed an issue.

First my question. How do I now retrieve the new thumb url? I have a working customers who last bought and if VM does not insert the URL into the db my module wont load the image. Where does it store the relative url?

Bug/Issue - This is also affected other features such as latest, featured, top ten, and popular/best seller
See attached image.

www.demo.stonedfury.com Joomla 2.5.11 Virtuemart 2.0.21c php 5.3 Linux

Joomla has only one component installed (akeeba backup) 1 non stock template - VP_Promart - However currently set to use only stock Beez20 (not parks)

EDIT: I went into the BE "tool" and reset media and while this fixed sizes it did not fix the updated product media thumb as well. "hammer"  and broke all images in the module as it tries to retrieve the file_thumb_url

Product BE also not displaying thumb

[attachment cleanup by admin]
Title: Re: [Updated] Release 2.0.21 C
Post by: Milbo on June 05, 2013, 22:48:14 pm
Milbo, it looks like another bug.

If you try to call normal custom fields (non-cart attribute type) in Category page or in Product Module the custom field array ($product->customfields) sometimes return as null or empty. If only view the same product in product details view then it works fine. I tested this with VM 2.0.20b and it works fine.

This seems like a bug when you try to show of custom fields for all products in product listing pages / areas and when the call is made in loop for all products.

Can you please look into this? I will wait for your response.

I need your exact setup to reproduce it. And really exact. step by step.
Title: Re: [Updated] Release 2.0.21 C
Post by: Milbo on June 05, 2013, 22:51:40 pm
StonedFury the thumburl is stored in the media object itself and generated there. I am sorry, I do not understand your description of the problem. Did you execute the media thumb reset?
Title: Re: [Updated] Release 2.0.21 C
Post by: servlet on June 06, 2013, 08:05:19 am
Milbo please read this: http://forum.virtuemart.net/index.php?topic=116213.0
Title: Re: [Updated] Release 2.0.21 C
Post by: Stonedfury on June 06, 2013, 17:54:49 pm
StonedFury the thumburl is stored in the media object itself and generated there. I am sorry, I do not understand your description of the problem. Did you execute the media thumb reset?
Yes I did a reset in the BE. IF you look at the images I shared the thumb is not loading. I have done no modification, this is a fresh install, only virtuemart, virtuemart AIO and Akeeba are installed. In the images I shared there is "thumb" where the image should load (in the BE) and in the FE the image is not being called by the TopTen, Latest, Featured, and Best Seller as show in the first image shared.
Title: Re: [Updated] Release 2.0.21 C
Post by: Jumbo! on June 07, 2013, 12:44:47 pm
Milbo, it looks like another bug.

If you try to call normal custom fields (non-cart attribute type) in Category page or in Product Module the custom field array ($product->customfields) sometimes return as null or empty. If only view the same product in product details view then it works fine. I tested this with VM 2.0.20b and it works fine.

This seems like a bug when you try to show of custom fields for all products in product listing pages / areas and when the call is made in loop for all products.

Can you please look into this? I will wait for your response.

I need your exact setup to reproduce it. And really exact. step by step.
Add Cart Attributes to all the products in a category. Then try to show Add to Cart button in the category page along with all the cart attributes against each products. Now you will see the following error message only when you use VM 2.0.21c

Warning: Invalid argument supplied for foreach() in administrator\components\com_virtuemart\models\customfields.php on line 845

For some unknown reason $groups array in administrator\components\com_virtuemart\models\customfields.php is returning empty array from SQL query.
Title: Re: [Updated] Release 2.0.21 C
Post by: Milbo on June 07, 2013, 15:11:30 pm
Aha, okey. You use the add to cart button in the category view and and the variants. This does not work always with 2.0.x. I solved the general problems in vm2.1 (yes, I get myself mad with it).
Title: Re: [Updated] Release 2.0.21 C
Post by: Jumbo! on June 07, 2013, 16:37:56 pm
Aha, okey. You use the add to cart button in the category view and and the variants. This does not work always with 2.0.x. I solved the general problems in vm2.1 (yes, I get myself mad with it).

But it is working perfectly till 2.0.20b. If it does not work in 2.0.21c then we will have to tell our customers not to update VirtueMart.
Title: Re: [Updated] Release 2.0.21 C
Post by: Milbo on June 07, 2013, 18:20:26 pm
Then give me the template, that I can see why it happens
Title: Re: [Updated] Release 2.0.21 C
Post by: Jumbo! on June 07, 2013, 18:34:01 pm
Then give me the template, that I can see why it happens

Okay, I am sending you a link through PM for the Quick Start package of the template. You can download it and install it in your test server. It is a full package including Joomla 2.5.11 and VirtueMart  2.0.21c. Just install it like normal Joomla.
Title: Re: [Updated] Release 2.0.21 C
Post by: Stonedfury on June 07, 2013, 19:39:09 pm
the image I used hammer.jpeg had an issue becoming a thumb. I replaced the image with a different one and cleared cache, etc. Latest, top ten, best seller now loading the image thumb. I guess it just didn't like that one image I used. After resetting thumbs it is all working.
Title: Re: [Updated] Release 2.0.21 D
Post by: AH on June 10, 2013, 21:53:22 pm
Versioning-

Payment plugin file

paypal.php has been modified

But the version in the  header has not been adjusted - is this a misunderstanding on my part as to how versioning is being operated?

Code: [Select]

 * a special type of 'paypal ':
 *
 * @author Max Milbers
 * @author Valérie Isaksen
 * @version $Id: paypal.php 5177 2011-12-28 18:44:10Z alatak $
 * @package VirtueMart
 * @subpackage payment
 * @copyright Copyright (C) 2004-2008 soeren - All rights reserved.
 * @license http://www.gnu.org/copyleft/gpl.html GNU/GPL, see LICENSE.php
 * VirtueMart is free software. This version may have been modified pursuant
 * to the GNU General Public License, and as distributed it includes or
 * is derivative of works licensed under the GNU General Public License or
 * other free or open source software licenses.
 * See /administrator/components/com_virtuemart/COPYRIGHT.php for copyright notices and details.
 *
 * http://virtuemart.org

e.g.
Code: [Select]

//"return" => JROUTE::_(JURI::root() . 'index.php?option=com_virtuemart&view=pluginresponse&task=pluginresponsereceived&on=' . $order['details']['BT']->order_number . '&pm=' . $order['details']['BT']->virtuemart_paymentmethod_id . '&Itemid=' . JRequest::getInt('Itemid')),

"return" => substr(JURI::root(false,''),0,-1) . JROUTE::_( 'index.php?option=com_virtuemart&view=pluginresponse&task=pluginresponsereceived&on=' . $order['details']['BT']->order_number . '&pm=' . $order['details']['BT']->virtuemart_paymentmethod_id . '&Itemid=' . JRequest::getInt('Itemid')),
Title: Re: [Updated] Release 2.0.21 E
Post by: alatak on June 17, 2013, 08:58:54 am
Hello

Quote
But the version in the  header has not been adjusted - is this a misunderstanding on my part as to how versioning is being operated?
Txs
It is an issue with some tags with the SVN. I am going to fix it.
Title: Re: [Updated] Release 2.0.21 E
Post by: Jumbo! on June 17, 2013, 20:17:44 pm
Milbo, it looks like another bug.

If you try to call normal custom fields (non-cart attribute type) in Category page or in Product Module the custom field array ($product->customfields) sometimes return as null or empty. If only view the same product in product details view then it works fine. I tested this with VM 2.0.20b and it works fine.

This seems like a bug when you try to show of custom fields for all products in product listing pages / areas and when the call is made in loop for all products.

Can you please look into this? I will wait for your response.

I need your exact setup to reproduce it. And really exact. step by step.

Add Cart Attributes to all the products in a category. Then try to show Add to Cart button in the category page along with all the cart attributes against each products. Now you will see the following error message only when you use VM 2.0.21c

Warning: Invalid argument supplied for foreach() in administrator\components\com_virtuemart\models\customfields.php on line 845

For some unknown reason $groups array in administrator\components\com_virtuemart\models\customfields.php is returning empty array from SQL query.

Thanks Milbo. The problem is resolved with VM 2.0.21e. Now custom fields does not show that error anymore.

But I found that "Category Form Initial Display Records" field is not effecting the product listing number in Category page. Even if I set the value as 5 for category it always remain unchanged as 10. Please check.
Title: Re: [Updated] Release 2.0.21 E
Post by: AH on June 17, 2013, 21:47:17 pm
Thanks Alatak
Title: Re: [Updated] Release 2.0.21 E
Post by: dido76bg on June 18, 2013, 15:51:24 pm
Almost 2 years I have not coded for VirtueMart but now I decided to use it again.
Donloaded the last test version.
It seems to be working on IE 8, but there are some coding bugs (I am sure they are just a mistake).
For example admin are -> view\product\tmpl\product_edit_information.php => line 68 and 263 - there are more "  that they realy should be.

I will keep looking for a bugs (but right now I should finish the translation first).
Title: Re: [Updated] Release 2.0.21 E
Post by: AH on June 18, 2013, 15:56:47 pm
When editing a shipment method (debug on!)

I have 2 shipment plugins active:-

Vmplugin.php is firing this debug message:-

if ($name !== 0) {
         if ($name != $this->_name) {
            vmdebug ('selectedThis $name ' . $name . ' does not fit pluginname ' . $this->_name);
            return FALSE;
         }

The plugin selected always seems to test against the other plugin $name??

e.g.
Selected name is plugin1

this $name plugin1 does not fit pluginame plugin2

Selected name is plugin2
this $name plugin2 does not fit pluginame plugin1

If I turn off one of the plugins the message is not fired.
Title: Re: [Updated] Release 2.0.21 E
Post by: alatak on June 18, 2013, 18:30:07 pm
Hello dido76bg

Quote
For example admin are -> view\product\tmpl\product_edit_information.php => line 68 and 263 - there are more "  that they realy should be.
Txs, i am fixing it
Title: Release 2.0.21 E Bill to changes do not save in admin order
Post by: AH on June 19, 2013, 16:38:44 pm
2.0.21E

Bill to detail changes do not save "save order head"

In order admin
Code: [Select]
administrator/index.php?option=com_virtuemart&view=orders&task=edit&virtuemart_order_id=


Ship to details work fine

Title: Re: [Updated] Release 2.0.21 E
Post by: alatak on June 19, 2013, 17:46:49 pm
Hello Huston
Quote
Bill to detail changes do not save "save order head"
Txs, I have fixed it
Title: Re: [Updated] Release 2.0.21 E
Post by: AH on June 19, 2013, 17:50:00 pm

When can we have it please -
Need to know when to test it again

2.0.21f ?

Title: Re: [Updated] Release 2.0.21 E
Post by: alatak on June 19, 2013, 18:01:25 pm
Hello Huston,
yes will be included in the 2.0.21F

But the fix is simple
in file administrator/components/com_virtuemart/views/orders/view.html.php
replace line 77
Code: [Select]
$userfields = $userFieldsModel->getUserFieldsFilled(
$_userFields
,$orderbt
);

with
Code: [Select]
$userfields = $userFieldsModel->getUserFieldsFilled(
$_userFields
,$orderbt
,'BT_'
);
Title: Re: [Updated] Release 2.0.21 E
Post by: lindapowers on June 19, 2013, 18:06:41 pm
Hi just a quick comment about the search function.

It has been improved a lot so thanks for that but still at shoppers or orders page list if you search using "name" and "last name" example:

John Smith

It wont find it, you either have to write John or Smith.

You can test what I mean by searching name and last name of any of your customers at the VM2 shopper list page.

Regards
Title: Re: [Updated] Release 2.0.21 E
Post by: AH on June 19, 2013, 18:21:58 pm
Alatak - thanks
Title: Re: [Updated] Release 2.0.21 E
Post by: AH on June 19, 2013, 19:10:47 pm
Just tested bill to and ship to edit in order admin - 2.0.21f

Ship and bill to are working.  :D
Title: Re: [Updated] Release 2.0.21 f
Post by: dido76bg on June 19, 2013, 23:26:01 pm
New (2.0.21f) version. Fresh install and found styling bugs:
administrator/components/com_virtuemart/views/config/tmpl/default_shop.php - missing closing tags </label>
missing open and closing tags <tr></tr>
Just in first lines.
Please do not take it personal but why do you use <fieldset>
I think that with more clear coding style it will be easier for debuging.
I will keep looking for bugs.
Please make adding a discount easier.

Missing translation:
COM_VIRTUEMART_ADMIN_CFG_PRICE_CVARSWT_TIP

I have attached some corrected files (corrected and well stiled).

Best Regarts.

[attachment cleanup by admin]
Title: Re: [Updated] Release 2.0.21 f
Post by: alatak on June 20, 2013, 09:49:25 am
Hello
Thank you, I am fixing it.

The labels are used to separate the settings
Title: Re: [Updated] Release 2.0.21 f
Post by: dido76bg on June 20, 2013, 13:06:16 pm
Thank you, I am fixing it.
The labels are used to separate the settings
Hi!
I know what iis their function, but I think that you shouold make a better styling.
You can use the files I have corrected.
Also there are other files in view folder where the mess is the same - unnecessary table rows and cells, without table tags see product_info file.

Best Regards
Title: Re: [Updated] Release 2.0.21 f
Post by: alatak on June 20, 2013, 13:41:12 pm
Hello
Quote
I know what iis their function,
yes i guess u know :)
Quote
You can use the files I have corrected.
i have checked them, and use them.
Title: Re: [Updated] Release 2.0.21 f
Post by: RedJohn on June 20, 2013, 13:47:37 pm
I have problem with sending email message when I finish order (confirmation order).
I see that problem is in function "static public function renderMail"
"\components\com_virtuemart\helpers\shopfunctionsf.php"
I change this function (with 2.0.18b) and now it is working good.
Title: Re: [Updated] Release 2.0.21 f
Post by: Milbo on June 20, 2013, 20:41:26 pm
There are two new settings in the checkout tab for the mail. just activate it and it should work.
But annoying is in fact, it should directly work as before without checking for it. So the question is, why the correct standard values array('U','C','S','R','X') are not taken?
Title: Re: [Updated] Release 2.0.21 f
Post by: AH on June 20, 2013, 23:09:48 pm
When installing 2.0.21f

The user notify email and vendor notify email and invoice settings were reset
Title: Re: [Updated] Release 2.0.21 f
Post by: dido76bg on June 21, 2013, 00:35:59 am
Problem with category creation v2.0.21f
DB missing virtuemart_categories.limit_list_max, or may be the file is not renewed

When comment line 61 in admin => tables => categories.php everithing is ok
Title: Re: [Updated] Release 2.0.21 f
Post by: RedJohn on June 21, 2013, 08:19:01 am
There are two new settings in the checkout tab for the mail. just activate it and it should work.

Ok, thanks. Now it is working :)
Previously, there was no value and did not work, and I did not notice this option.
Title: Re: [Updated] Release 2.0.21 f
Post by: nickwiebe on June 21, 2013, 21:36:53 pm
Which one of these in the AIO update and which one is the main update.  Will this update override updates I have made to the css and default_products.php and calculationh.php?

thanks,

Nick
Title: Re: [Updated] Release 2.0.21 f
Post by: dido76bg on June 21, 2013, 21:56:27 pm
Which one of these in the AIO update and which one is the main update.  Will this update override updates I have made to the css and default_products.php and calculationh.php?

thanks,

Nick
Hi!

I think that if you make the update through installer it will overwrite everithing.

First make a backup of all your moded files, than use a program simillar to Beyond Compare to track the changes.

I do it that way...


Title: Re: [Updated] Release 2.0.21 f
Post by: Milbo on June 22, 2013, 10:20:50 am
Nieckwiebe, please post your changes of the calculationh.php to http://forum.virtuemart.net/index.php?board=139.0. The files contain the core and the aio. You should move your modified css and default_products.php to your template, then it wont be overwritten. Read here http://docs.virtuemart.net/tutorials/33-templating-layouts/78-introduction-template-system.html
Title: Re: [Updated] Release 2.0.21 f
Post by: RedJohn on June 22, 2013, 17:43:57 pm
How Can I change Default items per listing view ftom 10 to 30?
I change value in Config->Shopfront->"Default items per listing view" from 10 to 30 and it is not working.

Can someone confirm this?
Maybe this is the result of my modifications. I do not know.

EDIT

When comment
   //var $limit_list_step     = 10; (59 line)
   //var $limit_list_initial   = 10; (63 line)

in
\administrator\components\com_virtuemart\tables\categories.php

everithing is ok
Title: Re: [Updated] Release 2.0.21 f
Post by: dido76bg on June 22, 2013, 22:33:08 pm
Filter (sort field) by fetured products not working properly if there are no fetured products.
There is no possibility to change (choose other) the filter/sort field.

Anothere question: Why the build in version of jQuery i so old.  Other components use later build versions (1.9.x or 1.10.x).

Also there are too many parameters which most of the shop owners will never use, and there are parameters which are important (according to me) but missing: wish list, favourite prodict (may be identical with rating or something similar) - both to have an option to be share to everyone to to be personal, and more images (may be 3 different sizes are enough).
In admin are product listing - may be we should see the Final not the Base price without tax (or may be it should be coded as an option).


Price creation is giving mistake with "Round only display" option ON if the final price (calculated after Aply button is pressed) have more than 2 digits as decimals. If "Round only display" option is OFF it is OK (see attached).


[attachment cleanup by admin]
Title: Re: [Updated] Release 2.0.21 f
Post by: Milbo on June 23, 2013, 10:30:18 am
Anothere question: Why the build in version of jQuery i so old.  Other components use later build versions (1.9.x or 1.10.x).

LOL. Why is the world so unfair. why there are poor and rich people, why we just cant live nicely together. Easy, virtuemart is a PROJECT! If someone dont like the old version, what is todo? Install the new jquery verison, test the code, adjust the code, SHARE the code. Everyone should do what he can. I am not good in javascript, therefore I am not doing it. So the right method to talk about this topic is first to open a new topic, because it has not really something todo with the 2.0.21 releases. Then the right question is "Could someone be so nice and update the jquery? I would do it, but I am better in templating"
THAT would be the right tone. Which reason is there that we use the old version? I tell you, because we are stupid, lazy and of bad will. haha!

Also there are too many parameters which most of the shop owners will never use,
Your opinion. You made a poll? How many shopowners do you know? I repeat myself no problem "Most people only use 20% of the featueres in VM and know maybe 30% and everyone uses other 20%."

missing: wish list, favourite prodict (may be identical with rating or something similar) - both to have an option to be share to everyone to to be personal, and more images (may be 3 different sizes are enough).
And you compare configuration settings with complete own features. A wish list ist not a parameter, Favorite product? What is a favourite product, most bought? we have that. Share to everyone or to be personal? Seems you need something very special. You may ask around here. Of course EVERYONE says,.. yes we need it. Human always need everything. But ask what they would pay for it. Would they pay for it the wage they earn at a day for it?
You will see, people who really need it and would be willing to pay for it are maybe 5% of all vm users and suddenly you will understand that we concentrate FIRST ALWAYS on the things WE EXPECT to be need by more than 80% of the vm users. We call this system democratie, btw. It is a lot more social to help the majority first and then the minority.


In admin are product listing - may be we should see the Final not the Base price without tax (or may be it should be coded as an option).
Yes and in takes calcuation time and most people are not intersted in it. In the first moment everyone says "HEY, I NEED IT", but in reality, you dont need it. You must calculate your prices ALWAYS WITHOUT THE VAT! IF you do different then you are a criminal, bhooom. Regardless which country, really.
A real merchant is thinking in net prices, thinking in gross prices is noob, sorry. But it is the truth. So in what is your merchant interested? Do you every considered that it is quite hard to show the right prices in the moment you have discounts based on shoppergroups/date and so on? Or if there are multiple prices. Okey I know your answer "why not showing final price if it is clear", yeh when it is clear, why to show then the prices with simple 20% VAT on it? If you see 8,10,12,20 euro, what is the gain to see 9.6,12,14.4, 24, instead? The product with 8 euro is still the cheapest.
And what happens when, like in Europe, the people have to pay sometimes VAT and sometimes not, what is the gain then? There is no gain. It is just this thinking "the sun must be yellow", "I must see the final prices", no you need not. It is a nice to have, okey, yes. Same like showing pictures of the product in the list. Yes, looks nice, but if you want to work with it, the performance is much more important than the eye candies.

So and why just dont add it? Because it takes calculation time and most people want to browse their products, not compare prices. It makes anyway a lot more sense to check the prices in the FE, how they are for the shoppers.

Price creation is giving mistake with "Round only display" option ON if the final price (calculated after Aply button is pressed) have more than 2 digits as decimals. If "Round only display" option is OFF it is OK (see attached).

I wrote already about this a loong post. http://forum.virtuemart.net/index.php?topic=108809.msg366891#msg366891 . You should read it.
Title: Re: [Updated] Release 2.0.21 f
Post by: dido76bg on June 23, 2013, 11:02:31 am
Milbo, I really do not know why you are so angry.
However. I will not spam.
Good luck
Title: Re: [Updated] Release 2.0.21 f
Post by: Milbo on June 23, 2013, 11:28:58 am
I am sorry did76bg,

you are not of them, but I admit I am pissed by people just demanding and insisting and to top that saying that we have the duty as community or as moderators of the community todo this or that, but behaving themself not as community. this is IN YOUR case different, because you behave like a community person.

But the other stuff was really often discussed, especially the rounding stuff. Really a lot of times. Also no one likes it if a thread is suddenly takenover by different topics, which do not belong to it. Furthermore you also had an accusive stile, or not?

So you wonder why I am angry, after you accused us? hmmm. Ahh yes you dont see that you accused us.

"Filter (sort field) by fetured products not working properly if there are no fetured products.
There is no possibility to change (choose other) the filter/sort field."

This is regarding to the topic, Funny is that there is nothing to sort, if there is no product. So you say that you cannot change the filter if there is no product?

The rest of the thread is OFF topic and most time in accusive stile. "Why is the jQuery so old" and "too many ... never used", "Price creation is giving mistake with "Round only display"".
Title: Re: [Updated] Release 2.0.21 f
Post by: AH on June 23, 2013, 11:55:10 am
Milbo

Dido I think might have been trying to help, however I am pissed off on your behalf!

Code: [Select]
Another question: Why the build in version of jQuery i so old.  Other components use later build versions (1.9.x or 1.10.x).I have replaced the stock VM Jquerywith 1.7.2 - as I use cloudzoom and jQuery Tools v1.2.7 .

Everything appears to work well with this version. But why change if this is stable and works??

However Dido you fail to join the request for new Jquery and the statement below
Quote
Also there are too many parameters which most of the shop owners will never use
.  If the team don't need the latest version of Jquery, why would they install it until they needed? Just to get a whole bunch of parameters and functions they never need??

Quote
Also there are too many parameters which most of the shop owners will never use,
The more parameters the wider the user base can be (and we need a wide user base to keep the project live and interesting!)
Imagine Microsoft excel having the 80% functionality not used by most people removed!

Quote
there are parameters which are important (according to me) but missing: wish list, favourite prodict (may be identical with rating or something similar) - both to have an option to be share to everyone to to be personal
Yes but probably these fit into the "too many parameters, never used by most" category. Thus creating even more parameters.



Quote
And more images (may be 3 different sizes are enough).
Not sure where you are heading with this one - 3 is way too many for 80% of people and for a 100% if they utilise CSS IMG to re-size to what they require?


Quote
In admin are product listing - may be we should see the Final not the Base price without tax (or may be it should be coded as an option).
The issue here is valid  - Milbo, From what I can see, the Cost price not the Base price is displayed.
We have a  calculation like this:-

Suppliers RRP = Cost price $100
We get a 70% discount to this - so we apply a marge of -70%
We then want an uplift of 20% - so we apply a marge of +20%

Our Base Price becomes $24

We see in the product listing $100  :(  Not very helpful.

Code: [Select]
Price creation is giving mistake with "Round only display" option ON if the final price (calculated after Aply button is pressed) have more than 2 digits as decimals. If "Round only display" option is OFF it is OK (see attached).
I never use the round only display - it does not help improve the display the prices for my settings, so I suggest Dido you do not use it either ?


Title: Re: [Updated] Release 2.0.21 f
Post by: dido76bg on June 23, 2013, 13:22:28 pm
Hi! Please take my apologise if I doing rough but I am just trying to help as much as I am possible to.
So.... As I tested on my local host it seems that the base functionality of the component (shopping cart) is working well (I have made some small changes to admin view folder - closing and adding some missing tags, and removing some unnecessary (I will post them later).

I will reed more carefully the topics in the forum next time)
Title: Re: [Updated] Release 2.0.21 f
Post by: Milbo on June 23, 2013, 14:01:04 pm
You are welcome dido. If you understand our point we are already lucky.
Title: Re: [Updated] Release 2.0.21 f
Post by: atrus on June 24, 2013, 11:50:52 am
Hi Milbo,

Great job so far, thanks.

You know this nasty bug with the stockable variants shopper groups, any chance that this will be fixed? This is a big headache long time now.

See an example here:

1. Go to www.quality-tuning.eu
2. Login with: xondriki/xondriki (wholesale user)
3. Search for e.g. product BL206 on the upper right corner. The product will come in the results. Notice that you can see the product whosale price here.
4. Click 'Product Details'. You will see that the stockable variants don't fetch the wholesale price but the retail price..  :-\ Interesting note: you can see that they try to fetch it but immediately change to retail price instead.

Any ideas pls?

Rgrds
Title: Re: [Updated] Release 2.0.21 f
Post by: kristobal1969 on June 24, 2013, 22:46:25 pm
Hi atrus,
When did this bug come ? I am using 2.0.21c and use shopergroup prices with no problem.
This is really annoying.
looking forward for the final release.
Title: Re: [Updated] Release 2.0.21 f
Post by: Uke on June 25, 2013, 00:38:02 am
Hello!

I installed 2.0.21 f and i am trying to find the new Invoice Tool.  :'(

Can someone please tell me where it is?
Title: Re: [Updated] Release 2.0.21 f
Post by: AH on June 25, 2013, 01:43:56 am
It is in

VM> Administration > Shop > Invoices tab
Title: Re: [Updated] Release 2.0.21 f
Post by: Uke on June 25, 2013, 02:01:40 am
I have set "Multivendor" back to "none" and now i can see the invoice tab.  :)

Thanks!
Title: Re: [Updated] Release 2.0.21 f
Post by: atrus on June 25, 2013, 02:03:20 am
Hey kristobal1969,

The bug is noted in 2.0.20b but there is no indication that it is fixed in latest 2.0.21 versions.

- Are u using stockable variants with different shopper groups?

- Was everything working ok for you in 2.0.20b?

Thanks in advance!
Title: Re: [Updated] Release 2.0.21 f
Post by: kristobal1969 on June 25, 2013, 07:49:04 am
Hi Atrus,
I understand better now what the bug is, but not really sure.
Here is a link with a product with a variation though the modification is + 0 €
http://www.edp44.com/en/polypropylene-products/boats-accessories/kit-1-detail.html (http://www.edp44.com/en/polypropylene-products/boats-accessories/kit-1-detail.html)
You have a default price but when logged in with user digicon and pass digicon, you have the right price (lower than default as you are resseler with this account). No problem at all.
I am running VM 2.0.21c
Title: Re: [Updated] Release 2.0.21 f
Post by: atrus on June 26, 2013, 02:16:14 am
Hi Kristobal,

Thanks for the link; are you using stockable variants plugin? So you mean after you login as reseller, the price of the variants is lower indeed?

Rgrds,
Chris
Title: Re: [Updated] Release 2.0.21 f
Post by: kristobal1969 on June 26, 2013, 08:49:45 am
Hi !
I am not sure to understand what "stockable variants plugin" is.
Can you send a link about that ?
And for the price being lower when a reseller is logged in, this is because I have a special price for reseller.
I think we should speak by PM or skype because this forum is not the right place for this discussion.
Title: Re: [Updated] Release 2.0.21 G
Post by: Milbo on June 26, 2013, 22:04:17 pm

1. Go to www.quality-tuning.eu
2. Login with: xondriki/xondriki (wholesale user)
3. Search for e.g. product BL206 on the upper right corner. The product will come in the results. Notice that you can see the product whosale price here.
4. Click 'Product Details'. You will see that the stockable variants don't fetch the wholesale price but the retail price..  :-\ Interesting note: you can see that they try to fetch it but immediately change to retail price instead.


We fixed something like that, Please check!
Title: Re: [Updated] Release 2.0.21 G
Post by: lindapowers on June 26, 2013, 23:18:13 pm
About the G release, just installed and the invoices tab (an all the text inside) changed from spanish on previous F version to english.

Installing the language pack again solved the problem, anyway just in case this helps.

In this new version languages were correctly kept at the multilingual configuration of VM2.
Title: Re: [Updated] Release 2.0.21 G
Post by: Milbo on June 27, 2013, 11:03:19 am
yepp, and the invoice should also work for you, Kainhofer sent two small patches.
Title: Re: [Updated] Release 2.0.21 G
Post by: lindapowers on June 27, 2013, 14:20:55 pm
yepp, and the invoice should also work for you, Kainhofer sent two small patches.

Yes they work perfectly, also de print view is now displaying all fields from the invoice perfectly.

Regards
Title: Re: [Updated] Release 2.0.21 G
Post by: atrus on June 27, 2013, 16:14:01 pm

1. Go to www.quality-tuning.eu
2. Login with: xondriki/xondriki (wholesale user)
3. Search for e.g. product BL206 on the upper right corner. The product will come in the results. Notice that you can see the product whosale price here.
4. Click 'Product Details'. You will see that the stockable variants don't fetch the wholesale price but the retail price..  :-\ Interesting note: you can see that they try to fetch it but immediately change to retail price instead.


We fixed something like that, Please check!

Thanks Milbo, but just installed 2.0.21g and the problem is still there i'm afraid..
Title: Re: [Updated] Release 2.0.21 G
Post by: rayge on July 03, 2013, 17:57:24 pm
 I tried installing VM2.0.21g.. first he AIO and i get this..

Fatal error: Call to undefined method plgVmCalculationAvalara::setPluginLoggable() in /home/simba/public_html/plugins/vmcalculation/avalara/avalara.php on line 52
Title: Re: [Updated] Release 2.0.21 G
Post by: Milbo on July 03, 2013, 20:26:37 pm
I tried installing VM2.0.21g.. first he AIO and i get this..

Fatal error: Call to undefined method plgVmCalculationAvalara::setPluginLoggable() in /home/simba/public_html/plugins/vmcalculation/avalara/avalara.php on line 52

Of course, you must always install first the Core. The aio is using functions of the core.
Title: Re: [Updated] Release 2.0.21 G
Post by: rayge on July 03, 2013, 20:31:30 pm
DUH okay im being Dyslexic! Sorry trying again.
Title: Re: [Updated] Release 2.0.21 G
Post by: dido76bg on July 04, 2013, 13:43:07 pm
And what about vesion H!
I hope this one is one step before the stable version!

Regards
Title: Re: [Updated] Release 2.0.21 G
Post by: AH on July 05, 2013, 10:00:29 am
dido there are 26 letters in the alphabet so still some way to go before we have to resort to numerics
Title: Re: [Updated] Release 2.0.21 G
Post by: lindapowers on July 06, 2013, 16:11:52 pm
Well I agree with dido here, we really need a stable version out.

3rd party developers in many cases completely ignore test versions so for them the latest version is 2.020b. Much has changed in the code, much has been improved and added but please remember that this test versions are completely ignored by this programmers and until we have a stable version to mention them they won't apply changes to make their components, modules or templates compatible.

For most shops updating VM is just the first step of updating a series of components modules and templates which will in many cases require an update too.

This version seems stable even since the first release.

People are adding many hacks, posting many code changes and improvements which is great but you can always keep adding changes and improvements.

Regards
Title: Re: [Updated] Release 2.0.21 G
Post by: zainabubu on July 09, 2013, 19:15:08 pm
Using vm 2.0.20b, update to .22, and got this message;

Invalid Token, in store config
Title: Re: [Updated] Release 2.0.21 G
Post by: AH on July 09, 2013, 19:17:45 pm
Zani

You should clear the browser cash and see if that sorts it out
Title: Re: [Updated] Release 2.0.21 G
Post by: zainabubu on July 09, 2013, 19:23:02 pm
i did. still showing Invalid Token, in store config
Title: Re: [Updated] Release 2.0.21 G
Post by: dido76bg on July 09, 2013, 19:48:00 pm
Well I agree with dido here, we really need a stable version out.

And now the stable version is fact.
Thank you guys!
Today is the day I will start with my new projects because you have released a new stable version and the Joomlaworks team released their new stable version too.

Thank you once again!
I will report if something is wrong.

Best regards!
Title: Re: [Updated] Release 2.0.21 G
Post by: zainabubu on July 09, 2013, 19:49:50 pm
luckily, it did not affect current vm database, so i'm currently unable to install manually and automatically of the new stable version.
Title: Re: [Updated] Release 2.0.21 G
Post by: Stonedfury on July 09, 2013, 21:52:08 pm
I couldn't use the akeeba updater. I kept getting errors about looping. I downloaded and installed aoi and the com through joomla installer, cleared cache, re-installed template and all works sweet so far.
Title: Re: [Updated] Release 2.0.21 G
Post by: zainabubu on July 09, 2013, 22:40:57 pm
Thanks for the tip. I used the normal joomla installer, and it worked.
Title: Re: [Updated] Release 2.0.21 G
Post by: BaidareW on July 17, 2013, 18:20:08 pm
Not sure, but after update from last stable to 2.0.22a I found links changed. for example it was www.myshop.com/productcategory and not I get www.myshop.com/productcategory?Itemid=0

How can I turn off this ?Itemid=0 in the end of adress ? No configuration changes where made.
Title: Re: [Updated] Release 2.0.21 G
Post by: Jumbo! on July 17, 2013, 18:28:12 pm
Not sure, but after update from last stable to 2.0.22a I found links changed. for example it was www.myshop.com/productcategory and not I get www.myshop.com/productcategory?Itemid=0

How can I turn off this ?Itemid=0 in the end of adress ? No configuration changes where made.
You have not created any Joomla Menu Item for VirtueMart Front Page. Therefore VirtueMart category pages and also other pages is not getting the Item ID.

Create a VirtueMart Front Page menu item, clear the cache of your site. Then check. However please remember then the url will look like www.myshop.com/front-page-menu-alias/productcategory
Title: Re: [Updated] Release 2.0.21 G
Post by: zainabubu on July 23, 2013, 18:54:08 pm
using vm 2.0.22...vm keeps messing with my images. images with .jpeg end up getting resaved as .jpeg.jpg in resized folder. very frustrating business.
Title: Re: [Updated] Release 2.0.21 G
Post by: BaidareW on July 23, 2013, 20:38:41 pm
Talking about links - there is a menu item linking to virtuemart.

Another strange thing after update : no e-mails are sent when order is made. what could be the problem ?
Title: Re: [Updated] Release 2.0.21 G .... Now 2.022a
Post by: mrtfrv on July 26, 2013, 07:10:46 am
Greetings All,

First, to Milbo and all the rest involved, thank you for a great product!

My site is currently using version: 2.0.20b

Right now, all is well. I have no issue; but, I certainly wish to remain current while utilizing the latest additions.

I did received the "Invalid Token, in store config" error upon attempting to update, which lead me to this thread. I have seen the posts that advise using the Joomla Extension Manager: Install for a successful update.

Fortunately, since I have been working with Virtuemart 2x, I have never encountered any real problem updating or even any major problems within the updates themselves.

Having read the many posts on this thread, especially the most recent:

Talking about links - there is a menu item linking to virtuemart.

Another strange thing after update : no e-mails are sent when order is made. what could be the problem ?

using vm 2.0.22...vm keeps messing with my images. images with .jpeg end up getting resaved as .jpeg.jpg in resized folder. very frustrating business.

I wonder - Should I update right now or should I wait? Will I need to update through Joomla Extension Manager first to get "back on track" or at some point would the normal updater ( Akeeba Live Update, i believe) work with my version (2.0.20b). Typically, I just backup then update with my fingers crossed and do not work with a test site first; so, maybe I should be more involved and less lazy in that way.

Any feedback would be helpful to me.

But, mostly after reading all the comments in this thread, I just wanted to say:

Virtuemart is a great project involving some very patient, helpful and obviously hard working folks.... so thank you!

Title: Re: [Updated] Release 2.0.21 G
Post by: AH on July 26, 2013, 11:43:48 am
mrtfrv

The no-emails is probably due to the configuration being reset when upgrading

I would stay as current as you can (at least take stable releases)

I never use akeeba to update, I download the update files and update using the joomla extension manager.  I have never had a failure using this procedure.

Of course take backups of your database before an update and of your site files. 

I would recommend creating a local version of your site for testing purposes.

xampp will enable you to run a test apache server and mysql on a pc

You can then install your backup and practice re-installing etc
Title: Re: [Updated] Release 2.0.21 G
Post by: mrtfrv on July 27, 2013, 08:55:12 am
Thanks for the advice Hutson,

I will setup a local version. It just makes good sense.
Title: Re: [Updated] Release 2.0.21 G
Post by: servlet on September 03, 2013, 21:47:14 pm
OK, what is new? there is no changelog or bugtracker?
Please some info
Title: Re: [Updated] Release 2.0.21 G
Post by: LTCreations on October 07, 2013, 22:32:34 pm
After reading through 9 pages (I was hopeful the issue was discussed) I figured I'd better ask.

In the first page of this thread there was reference to downloading the newest version that has had (among other things) some W3C compliance addressed. I'm not sure where, but I can say that rel="vm-additional-images" is not valid.

In the /components/com_virtuemart/views/productdetails/default_images.php, line 26, jQuery("a[rel=vm-additional-images]").fancybox({ - the rel tag doesn't allow that specific term. Yes, the site works and so does the fancybox. But the fact remains, there are a lot of errors on the page simply due to the rel reference. That's a good thing, knowing that the only errors are from 1 piece of code that can be rectified - if I knew all the places where it's referenced, and, if I can find a compliant reference that fancybox also likes.

Since you guys know the code a lot better than I, can someone tell me "how many" files I'll need to edit in order to change the reference to something compliant? I found a list of what is acceptable in rel - http://microformats.org/wiki/existing-rel-values - and was considering changing to "contents". Of course changing this in just one file on the one line simply stops the fancybox from working normally.

Any help on this would be appreciated. And, by the way. I just installed the latest version of VM - 2.0.24 - which, outside of this one bug, seems to truly be a nice bit of software. I've used VM in many previous projects, but not for about a year.

Thanks.
Thomas

Title: Re: [Updated] Release 2.0.21 G
Post by: jjk on October 07, 2013, 23:04:56 pm
The W3C validator doesn't complain about "a[rel=vm-additional-images]". The various microformats and W3C are different things. And search engines like Google don't care at all about W3C complicance. Concerning images, I have many images from my VirtueMart shop showing on number one positions in Google.  ;)