VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Topic started by: reinhold on November 15, 2012, 17:41:29 PM

Title: [PATCH] Standard payment: Add <br/> to payment_name only if payment_info present
Post by: reinhold on November 15, 2012, 17:41:29 PM
Currently, the standard payment plugin unconditionally adds a <br/> between the renderPluginName and the payment_info, even if no payment_info is present:

   $dbValues['payment_name'] = $this->renderPluginName ($method) . '<br />' . $method->payment_info;

This creates an ugly line break in my PDF invoices if no payment_info is present. In comparison, the shipment plugins don't add any info, and thus never append a <br/>

Attached is a patch (relative to current svn trunk) that adds the <br/> only conditional on the payment_info being present.

Cheers,
Reinhold

PS: It seems that the forum does not allow *.patch or *.diff files to be attached to postings on the development forum (?!?!?), so I'm renaming the patch to .txt.

[attachment cleanup by admin]
Title: Re: [PATCH] Standard payment: Add <br/> to payment_name only if payment_info present
Post by: alatak on November 16, 2012, 16:33:31 PM
Hello
Ok , i have done it.
Thanks